linaro-dev March 2012

linaro-dev@lists.linaro.org

152 participants
126 discussions

Re: [PATCH 1/5] mfd : ux500 - Cleanup duplicate definitions

by Samuel Ortiz

Hi Daniel, On Tue, Feb 28, 2012 at 10:46:05PM +0100, daniel.lezcano(a)linaro.org wrote: > From: Daniel Lezcano <daniel.lezcano(a)linaro.org> > > I missed in my previous patch the A9_MASK_REQ[_MASK] were > already defined. Let's remove the duplicate definitions. > > The PRCMU_GIC_DELAY macro could be removed as it is not > really useful here. This one and the 4 other patches applied. Thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/

12 years, 2 months

Cross toolchain for lucid updated

by Marcin Juszkiewicz

Linaro cross toolchain backport PPA [1] got updated to recent Ubuntu 12.04 versions: - gcc 4.5.3 - gcc 4.6.2 - binutils 2.22 - eglibc 2.15 - linux 3.2 I tested both compiler versions against few packages, U-Boot and Linux 2.6.32. Those packages may also work under Ubuntu 10.10 'maverick' and 11.04 'natty' but it was not tested. Users of Ubuntu 11.10 'oneiric' may install libmpfr1ldbl package [2] and then use 'lucid' repository to install cross compiler while I will prepare packages for their version of Ubuntu. Please report any problems with those backported packages in launchpad [3][4][5]. 1. https://launchpad.net/~linaro-maintainers/+archive/toolchain 2. http://packages.ubuntu.com/lucid/libmpfr1ldbl 3. https://launchpad.net/ubuntu/+source/gcc-4.5-armel-cross/+bugs 4. https://launchpad.net/ubuntu/+source/gcc-4.5-armel-cross/+bugs 5. https://launchpad.net/ubuntu/+source/armel-cross-toolchain-base/+bugs

12 years, 2 months

[PATCH 0/2] add ehci-s5p AHB burst function

by Sangwook Lee

Enable burst transfer from AHB for EHCI. This fixes data transfer issue of USB Ethernet with EHCI. Without this patch, ping works and network utilities such as scp hardly works. It was tested on Origen board with the following configs. root@linaro-alip:~# lsusb -t /: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=exynos-ohci/3p, 12M /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=s5p-ehci/3p, 480M |__ Port 1: Dev 2, If 0, Class=vend., Driver=MOSCHIP usb-ethernet driver, 480M Sangwook Lee (2): ARM: EXYNOS: Add EHCI AHB burst function USB: ehci-s5p: add function for burst arch/arm/mach-exynos/setup-usb-phy.c | 6 ++++++ arch/arm/plat-samsung/devs.c | 2 ++ arch/arm/plat-samsung/include/plat/ehci.h | 19 +++++++++++++++++++ drivers/usb/host/ehci-s5p.c | 3 +++ 4 files changed, 30 insertions(+), 0 deletions(-) -- 1.7.4.1

12 years, 2 months

[PATCH v2 2/2] USB: ehci-s5p: add DMA burst support

by Jingoo Han

DMA burst support is added to improve performance in EHCI data transfer. The USB EHCI controller on Exynos SoCs can use INCR16, INCR8, and INCR4 mode. These modes of INSNREG00 register should be set in order to enable DMA burst transfer. This feature is also related to AHB spec. Signed-off-by: Jingoo Han <jg1.han(a)samsung.com> Cc: Sangwook Lee <sangwook.lee(a)linaro.org> --- v2: change the definition name from EHCI_ENA_xxx to EHCI_INSNREG00_ENA_xxx. drivers/usb/host/ehci-s5p.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c index 293f741..b337f72 100644 --- a/drivers/usb/host/ehci-s5p.c +++ b/drivers/usb/host/ehci-s5p.c @@ -16,6 +16,7 @@ #include <linux/platform_device.h> #include <plat/ehci.h> #include <plat/usb-phy.h> +#include <mach/regs-usb-host.h> struct s5p_ehci_hcd { struct device *dev; @@ -128,6 +129,9 @@ static int __devinit s5p_ehci_probe(struct platform_device *pdev) ehci->regs = hcd->regs + HC_LENGTH(ehci, readl(&ehci->caps->hc_capbase)); + /* DMA burst Enable */ + writel(EHCI_INSNREG00_ENABLE_DMA_BURST, EHCI_INSNREG00(hcd->regs)); + dbg_hcs_params(ehci, "reset"); dbg_hcc_params(ehci, "reset"); @@ -234,6 +238,9 @@ static int s5p_ehci_resume(struct device *dev) if (pdata && pdata->phy_init) pdata->phy_init(pdev, S5P_USB_PHY_HOST); + /* DMA burst Enable */ + writel(EHCI_INSNREG00_ENABLE_DMA_BURST, EHCI_INSNREG00(hcd->regs)); + if (time_before(jiffies, ehci->next_statechange)) msleep(100); -- 1.7.1

12 years, 2 months

[PATCH 1/2] ARM: EXYNOS: Add USB HOST register definitions

by Jingoo Han

This patch adds USB HOST register definitions. The definition for EHCI INSNREG00 regiser and corresponding bit field definitions are added. Signed-off-by: Jingoo Han <jg1.han(a)samsung.com> --- arch/arm/mach-exynos/include/mach/regs-usb-host.h | 23 +++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-exynos/include/mach/regs-usb-host.h diff --git a/arch/arm/mach-exynos/include/mach/regs-usb-host.h b/arch/arm/mach-exynos/include/mach/regs-usb-host.h new file mode 100644 index 0000000..1a60f27 --- /dev/null +++ b/arch/arm/mach-exynos/include/mach/regs-usb-host.h @@ -0,0 +1,23 @@ +/* + * Copyright (C) 2012 Samsung Electronics Co.Ltd + * http://www.samsung.com + * + * EXYNOS - USB HOST register definitions + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#ifndef __REGS_USB_HOST_H +#define __REGS_USB_HOST_H __FILE__ + +#define EHCI_INSNREG00(base) (base + 0x90) +#define EHCI_ENA_INCR16 (0x1 << 25) +#define EHCI_ENA_INCR8 (0x1 << 24) +#define EHCI_ENA_INCR4 (0x1 << 23) +#define EHCI_ENA_INCRX_ALIGN (0x1 << 22) +#define EHCI_ENABLE_DMA_INCR (EHCI_ENA_INCR16 | EHCI_ENA_INCR8| \ + EHCI_ENA_INCR4 | EHCI_ENA_INCRX_ALIGN) + +#endif /* __REGS_USB_HOST_H */ -- 1.7.1

12 years, 2 months

[PATCH] module: debugging check for runaway kthreads

by Dmitry Antipov

Debugging option CONFIG_MODULE_KTHREAD_CHECK provides a way to check whether all kernel threads created by the module and have used module code as a thread worker function are really exited when the module is unloaded. The following pseudo-code contains example of an error which is likely to be catched with this debugging check: static struct task_struct *tsk; static DECLARE_COMPLETION(done); static void *func(void *unused) { while (!kthread_should_stop()) real_work(); complete(&done); } static int __init modinit(void) { tsk = kthread_run(func, NULL, "func"); return IS_ERR(tsk) ? PTR_ERR(tsk) : 0; } static void __exit modexit(void) { wait_for_completion(&done); } Reviewed-by: Andrew Morton <akpm(a)linux-foundation.org> Signed-off-by: Dmitry Antipov <dmitry.antipov(a)linaro.org> --- include/linux/kthread.h | 3 ++ kernel/kthread.c | 38 +++++++++++++++++++++++++++++++++++ kernel/module.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++ lib/Kconfig.debug | 9 ++++++++ 4 files changed, 101 insertions(+), 0 deletions(-) diff --git a/include/linux/kthread.h b/include/linux/kthread.h index 0714b24..202fe14 100644 --- a/include/linux/kthread.h +++ b/include/linux/kthread.h @@ -13,6 +13,9 @@ struct task_struct *kthread_create_on_node(int (*threadfn)(void *data), #define kthread_create(threadfn, data, namefmt, arg...) \ kthread_create_on_node(threadfn, data, -1, namefmt, ##arg) +#ifdef CONFIG_MODULE_KTHREAD_CHECK +unsigned long get_kthread_func(struct task_struct *tsk); +#endif /** * kthread_run - create and wake a thread. diff --git a/kernel/kthread.c b/kernel/kthread.c index 3d3de63..e6f7977 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -38,6 +38,13 @@ struct kthread_create_info struct kthread { int should_stop; +#ifdef CONFIG_MODULE_KTHREAD_CHECK + /* + * Kthread worker function, i.e. first argument + * passed to kthread_create() and kthread_run(). + */ + void *fn; +#endif void *data; struct completion exited; }; @@ -45,6 +52,32 @@ struct kthread { #define to_kthread(tsk) \ container_of((tsk)->vfork_done, struct kthread, exited) +#ifdef CONFIG_MODULE_KTHREAD_CHECK + +/* + * Assuming the task is a kernel thread, try to get it's worker + * function, i.e. the first argument of kthread_create()/kthread_run(). + */ +unsigned long get_kthread_func(struct task_struct *tsk) +{ + struct kthread *kt; + unsigned long addr; + + get_task_struct(tsk); + BUG_ON(!(tsk->flags & PF_KTHREAD)); + kt = to_kthread(tsk); + barrier(); + /* + * Note kt is valid only if vfork_done is initialized. + * See kthread() to check why it's so. + */ + addr = tsk->vfork_done ? (unsigned long)kt->fn : 0UL; + put_task_struct(tsk); + return addr; +} + +#endif /* CONFIG_MODULE_KTHREAD_CHECK */ + /** * kthread_should_stop - should this kthread return now? * @@ -106,8 +139,13 @@ static int kthread(void *_create) int ret; self.should_stop = 0; +#ifdef CONFIG_MODULE_KTHREAD_CHECK + /* Will be used by get_kthread_func(). */ + self.fn = threadfn; +#endif self.data = data; init_completion(&self.exited); + /* Setup self so to_kthread() macro may be used. */ current->vfork_done = &self.exited; /* OK, tell user we're spawned, wait for stop or wakeup */ diff --git a/kernel/module.c b/kernel/module.c index 2c93276..7ad8a03 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -45,6 +45,7 @@ #include <linux/string.h> #include <linux/mutex.h> #include <linux/rculist.h> +#include <linux/kthread.h> #include <asm/uaccess.h> #include <asm/cacheflush.h> #include <asm/mmu_context.h> @@ -223,6 +224,8 @@ extern const unsigned long __start___kcrctab_unused[]; extern const unsigned long __start___kcrctab_unused_gpl[]; #endif +static void check_kthreads(struct module *mod); + #ifndef CONFIG_MODVERSIONS #define symversion(base, idx) NULL #else @@ -831,6 +834,7 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user, blocking_notifier_call_chain(&module_notify_list, MODULE_STATE_GOING, mod); async_synchronize_full(); + check_kthreads(mod); /* Store the name of the last unloaded module for diagnostic purposes */ strlcpy(last_unloaded_module, mod->name, sizeof(last_unloaded_module)); @@ -3274,8 +3278,55 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, } return 0; } + +#else /* not CONFIG_KALLSYMS */ + +static inline const char *get_ksymbol(struct module *mod, + unsigned long addr, + unsigned long *size, + unsigned long *offset) +{ + return "<unknown>"; +} + #endif /* CONFIG_KALLSYMS */ +#ifdef CONFIG_MODULE_KTHREAD_CHECK + +static void check_kthreads(struct module *mod) +{ + unsigned long flags; + struct task_struct *g, *p; + + read_lock_irqsave(&tasklist_lock, flags); + do_each_thread(g, p) { + const char *name; + unsigned long addr, offset, size; + + /* Note kthreadd is special. Other kthreads should + have their struct kthread on the stack until + do_exit() calls schedule() for the last time. */ + if (p->mm || p == kthreadd_task) + continue; + + addr = get_kthread_func(p); + if (__module_text_address(addr) == mod) { + name = get_ksymbol(mod, addr, &size, &offset); + printk(KERN_WARNING "kthread %p[%s:%d] running " + "0x%lx(%s) is still alive, fix module %s, " + "crash possible\n", p, p->comm, p->pid, + addr, name, mod->name); + } + } while_each_thread(g, p); + read_unlock_irqrestore(&tasklist_lock, flags); +} + +#else + +static void check_kthreads(struct module *mod) {} + +#endif /* CONFIG_MODULE_KTHREAD_CHECK */ + static char *module_flags(struct module *mod, char *buf) { int bx = 0; diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 8745ac7..f082a76 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1121,6 +1121,15 @@ config SYSCTL_SYSCALL_CHECK to properly maintain and use. This enables checks that help you to keep things correct. +config MODULE_KTHREAD_CHECK + bool "Check for runaway kernel threads at module unload" + depends on MODULE_UNLOAD && EXPERIMENTAL && DEBUG_KERNEL + help + This option allows you to check whether all kernel threads created + by the module and have used module code as a thread worker function + are really exited when the module is unloaded. This is mainly for + module developers. If insure, say N. + source mm/Kconfig.debug source kernel/trace/Kconfig -- 1.7.7.6

12 years, 2 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev March 2012