== Progress ==
CARD-1489: Migrating the arndale android builds to 4.9 toolchain. Built the
code. need to verify on the HW.
== Plans ==
CARD-1489: Test verify the binaries which got built with linaro toolchain
v4.9.
== Issues ==
None
--
Thanks and Regards,
HariGopal G
Android Engineer
Recently there was a patch (commit
f5b9bdcb530a8871e6c65a617d41001b39bf4912), to fix
resource leak on dir_topology.
Now, the below code segment is either unnecessary or it should call
opendir on 'newpath' instead of 'path'?
dir_topology = opendir(path);
if (!dir_topology)
continue;
closedir(dir_topology);
Please comment.
--
Thanks,
-Meraj
Fix for the below issues -
1. valgrind reports memory leaks in
export_free_gpios. 'line' pointer was never freed.
==5732== 120 bytes in 1 blocks are definitely lost in loss record 130 of 271
==5732== at 0x482CBB8: malloc (vg_replace_malloc.c:270)
==5732== by 0x48CC633: getdelim (iogetdelim.c:67)
==5732== by 0xB303: export_free_gpios (stdio.h:117)
==5732== by 0xB3DD: gpio_init (gpio.c:376)
==5732== by 0x97F5: main (powerdebug.c:264)
2. Open files need to be closed.
diff --git a/gpio.c b/gpio.c
index 39480b0..076b260 100644
--- a/gpio.c
+++ b/gpio.c
@@ -353,7 +353,15 @@ void export_free_gpios(void)
if (system(command) < 0)
printf("error: failed to export gpio-%d\n", i);
}
+
+ free(line);
out:
+ if(fgpio)
+ fclose(fgpio);
+
+ if(fgpio_export)
+ fclose(fgpio_export);
+
return;
}
--
Thanks,
-Meraj
Hi all,
As a bit of a test for myself, I'm trying to run openstack tests on top
of the mostly-ready PSCI support the virtualization team has been
working on. I've built myself an Ubuntu kernel with the needed patches
(actually all of kvm/next) and now need a matching qemu. I fished these
patches:
http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg04514.html
out of patchwork and applied them on top of the qemu that's in trusty
but it fails to build. I guess these patches depends that are in qemu
git but not in 2.0.0? In any case, before I dive into trying to fix
this myself, does anyone have binaries or even better debs with those
patches in?
Cheers,
mwh