linaro-dev June 2014

linaro-dev@lists.linaro.org

39 participants
60 discussions

by Mohammad Merajul Islam Molla

Patch to fix some minor issues in idlestat tool - - use USEC_PER_SEC instead of hardcoded value - replace 'f' with 'stderr' - check for root only if idlestat is run in trace mode - increase MAXCSTATE & MAXPSTATE to 16 as per Daniel's suggestion. Needs to be dynamically determined in future. diff --git a/idlestat.c b/idlestat.c index 787d7b0..e9f556b 100644 --- a/idlestat.c +++ b/idlestat.c @@ -47,6 +47,7 @@ #include "topology.h" #define IDLESTAT_VERSION "0.3" +#define USEC_PER_SEC 1000000 static char irq_type_name[][8] = { "irq", @@ -193,7 +194,7 @@ static struct cpuidle_data *intersection(struct cpuidle_data *data1, data->begin = begin; data->end = end; data->duration = end - begin; - data->duration *= 1000000; + data->duration *= USEC_PER_SEC; return data; } @@ -510,7 +511,6 @@ static void open_next_pstate(struct cpufreq_pstates *ps, int s, double time) open_current_pstate(ps, time); } -#define USEC_PER_SEC 1000000 static void close_current_pstate(struct cpufreq_pstates *ps, double time) { int c = ps->current; @@ -617,7 +617,7 @@ static int store_data(double time, int state, int cpu, return 0; /* convert to us */ - data->duration *= 1000000; + data->duration *= USEC_PER_SEC; cstate->min_time = MIN(cstate->min_time, data->duration); @@ -1110,7 +1110,7 @@ static int idlestat_store(const char *path) f = fopen(path, "w+"); if (!f) { - fprintf(f, "%s: failed to open '%s': %m\n", __func__, path); + fprintf(stderr, "%s: failed to open '%s': %m\n", __func__, path); return -1; } @@ -1230,7 +1230,7 @@ int main(int argc, char *argv[], char *const envp[]) return 1; /* We have to manipulate some files only accessible to root */ - if (getuid()) { + if ((options.mode == TRACE) && getuid()) { fprintf(stderr, "must be root to run the tool\n"); return -1; } diff --git a/idlestat.h b/idlestat.h index 74238ff..1977ab4 100644 --- a/idlestat.h +++ b/idlestat.h @@ -29,8 +29,8 @@ #define BUFSIZE 256 #define NAMELEN 16 -#define MAXCSTATE 8 -#define MAXPSTATE 8 +#define MAXCSTATE 16 +#define MAXPSTATE 16 #define MAX(A, B) (A > B ? A : B) #define MIN(A, B) (A < B ? A : B) #define AVG(A, B, I) ((A) + ((B - A) / (I)))

9 years, 11 months

[PATCH POWERDEBUG] display free gpios info

by Mohammad Merajul Islam Molla

- Displays information about free gpios by exporting & unexporting Also, attached. diff --git a/gpio.c b/gpio.c index 4a42cb7..eb69f56 100644 --- a/gpio.c +++ b/gpio.c @@ -46,6 +46,7 @@ struct gpio_info { static struct tree *gpio_tree = NULL; static bool gpio_error = false; +int gpio_max; static struct gpio_info *gpio_alloc(void) { @@ -320,16 +321,17 @@ static struct display_ops gpio_ops = { .change = gpio_change, }; -void export_gpios(void) +void export_free_gpios(void) { - FILE *fgpio, *fgpio_export; - int gpio[256], num = 0; + FILE *fgpio = NULL, *fgpio_export = NULL; + int i; char *line = NULL; - ssize_t read, len; + ssize_t read; + size_t len; fgpio = fopen("/sys/kernel/debug/gpio", "r"); if (!fgpio) { - printf("failed to read debugfs gpio file\n"); + printf("failed to read open debugfs gpio file\n"); goto out; } @@ -340,17 +342,51 @@ void export_gpios(void) } /* export the gpios */ - while (read = getline(&line, &len, fgpio) != -1) { - char *str; - - if (strstr(line, "gpio-")) { - str = strtok(line, " "); - sscanf(str, "gpio-%d", &gpio[num]); - fprintf(fgpio_export, "%d", gpio[num]); - num++; - } + while ((read = getline(&line, &len, fgpio)) != -1) { + if (strstr(line, "GPIOs")) + sscanf(line, "%*[^-]-%d%*s", &gpio_max); + } + + printf("log: total gpios = %d\n", gpio_max); + for (i = 0 ; i <= gpio_max ; i++) { + char command[50] = ""; + + sprintf(command, "echo %d > /sys/class/gpio/export", i); + if (system(command) < 0) + printf("error: failed to export gpio-%d\n", i); } out: + if (fgpio) + fclose(fgpio); + + if (fgpio_export) + fclose(fgpio_export); + + return; +} + +void unexport_free_gpios(void) +{ + FILE *fgpio_unexport = NULL; + int i; + + fgpio_unexport = fopen("/sys/class/gpio/unexport", "w"); + if (!fgpio_unexport) { + printf("failed to write open gpio-unexport file\n"); + goto out; + } + + for (i = 0 ; i <= gpio_max ; i++) { + char command[50] = ""; + + sprintf(command, "echo %d > /sys/class/gpio/unexport", i); + if (system(command) < 0) + printf("error: failed to unexport gpio-%d\n", i); + } +out: + if (fgpio_unexport) + fclose(fgpio_unexport); + return; } @@ -368,7 +404,7 @@ int gpio_init(void) if (access(SYSFS_GPIO, F_OK)) gpio_error = true; /* set the flag */ - export_gpios(); + export_free_gpios(); gpio_tree = tree_load(SYSFS_GPIO, gpio_filter_cb, false); if (!gpio_tree) @@ -377,5 +413,7 @@ int gpio_init(void) if (fill_gpio_tree()) return -1; + unexport_free_gpios(); + return ret; } -- Thanks, - Meraj

9 years, 11 months

[ACTIVITY] week 23

by Andrey Konovalov

== Progress == * upload the schedule for ll updates in 2014.06, did the updates to llct and ll trees (CARD-788, 50%) * bug 1282076 - tried to narrow down the issue, but failed to reproduce it even using the older, "known to fail" Image. Maybe the kernel update on the host machine is the cause (bug 1282076, 10%) * time off (40%) == Plans == * time off 60% * usual updates to ll / llct (CARD-788) * try the recently posted patch set for the "Add ILP32 support for ARM64 to Linaro engineering builds" card (CARD-1161) * update the wiki doc for DEVPLAT-204 == Issues == * None

9 years, 11 months

[ACTIVITY] week 23

by Dileep Katta

== Progress == * Enabling UEFI Fastboot on Panda - Tested Fastboot App & DXE protocol (CARD-198: 20 %) * Flash support on u-boot fastboot - Analysis (CARD-1103: 70%) * Testing u-boot fastboot on Panda/BBB, In Progress (10%) == Plans == * CARD-198: Pause (0%) * U-boot Fastboot for Panda/Beaglebone - Test the commands (CARD-1103: 20%) * Flash support on u-boot fastboot (CARD-1103: 80%) == Issues == * None

9 years, 11 months

[ACTIVITY] Week23

by Wookey

== Progress == * Finally got QT4 built and uploaded (DEVPLAT-217: 20%) * Gettext bug filed, maintainer chivied. Now uploaded (DEVPLAT-217: 10%) * 'Nothing to build on buildds'. Worked on better ways to find out what blockers are (DEVPLAT-217: 15%) * R built, dependencies building. repo passed 6000 packages. (5%) * Buildd jammed up. PDU not working. Got that sorted. (DEVPLAT-221: 10%) * Feedback on Chen's arm64 fixes until good. Built and uploaded ~20 packages (DEVPLAT-221: 15%) * Build, Tag 0.1 release, upload cross-binutils package to debian (DEVPLAT-220: 15%) * Got access to new arm64 platform for testing. (DEVPLAT-219: 5%) * More broken timesheeting faff (2%) * Provided some internal crossbuilding advice (5%) * Chivied people on bootstrap sprint org (3%) == Plans == * Build poppler. (DEVPLAT-221) * Build webkit (DEVPLAT-217) * Build kdelibs (DEVPLAT-217) == Issues == * Too many packages are buildable but not rebuildable. * Having to build NMUs twice in slightly different formats for debian-ports unreleased and debian proper bug/upload is a pain. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/

9 years, 11 months

[ACTIVITY] week 23

by Riku Voipio

== Progress == * Xen packaging fix (BUG-1317155 10%) * KVM CI simplifying 30% * Added repo.linaro.org to trusty images (20%) * Qemu buildfixes for 4.9 (10%) * Testing perf with OE (CARD-1220 20%) == Plans == * Xen and KVM for armv8 (CARD-736, CARD-346) * Closeout of CARD-1220 == Issues == * None

9 years, 11 months

[Activity] week 23

by Vishal Bhoj

== Progress == * Got Android booting on ARMv8 FVP Base models with Trusted Firmware + u-boot (CARD-1049, 60%) * Android 4.4.3 Rebasing (DEVPLAT-225, 40%) == Plans == * Setup an Android build of with u-boot for ARMv8 (CARD-1049) * Finish Android 4.4.3 rebasing. == Issues == * None

9 years, 11 months

[Activity] week 23

by Koen Kooi

== Progress == * OE baseline work (CARD-787: 90%) * GCC 4.9 integration * Patch review * Juno CI loop (CARD-1441: 10%) == Plans == * Finish Juno CI loop == Issues == * CI maintenance -- Koen Kooi Builds and Baselines | Release Manager Linaro.org | Open source software for ARM SoCs

9 years, 11 months

[ACTIVITY] week 23

by Bernhard Rosenkränzer

== Progress == * Added libatomic to Android toolchain (DEVPLAT-101(?), 30%) * Revamped Android toolchain build to use Bionic from master branch (needed for v8 support), adapt to changes there (DEVPLAT-101(?), 30%) * Cleaned up Android toolchain build scripts while at it (DEVPLAT-101, 20%) * Hunted down fixes for 2 gcc 4.9 bugs that are showstoppers for Android (DEVPLAT-101(?), 10%) * Helped with "Android Toolchain: Member Expectations" document (DEVPLAT-101(?), 10%) == Plans == * Toolchain binary release (DEVPLAT-101) * Android toolchain release (DEVPLAT-101(?)) * Update NDK build scripts to match Android toolchain improvements (DEVPLAT-101(?)) * Investigate any compiler bugs that (might) show up with the new Android toolchain * Finish porting AArch64 Bionic optimizations to ARMv7 (DEVPLAT-104) == Issues == * Not sure the scope of DEVPLAT-101 is wide enough to include all work done last week and upcoming work (esp. NDK), may want to create a few related cards.

9 years, 11 months

[PATCH IDLESTAT] fix execute() function

by Mohammad Merajul Islam Molla

Patch to fix the below two issues - 1. Fix the part where parent waits to fetch child status. In case SIGALRM is received, fetch new status after killing child so that subsequent check for termination status passes. 2. In case of normal termination, just check if program exited normally (checking exit status is not necessary) diff --git a/idlestat.c b/idlestat.c index 787d7b0..179e7a7 100644 --- a/idlestat.c +++ b/idlestat.c @@ -1196,12 +1196,12 @@ static int execute(int argc, char *argv[], char *const envp[], alarm(options->duration); again: if (waitpid(pid, &status, 0) < 0) { - if (errno != EINTR || !sigalrm) - goto again; - kill(pid, SIGTERM); + if (errno == EINTR && sigalrm) + kill(pid, SIGTERM); + goto again; } - if (WIFEXITED(status) && !WEXITSTATUS(status)) { + if (WIFEXITED(status)) { /* * Cancel the timer in case the program * finished before the timeout -- Thanks, -Meraj

9 years, 11 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev June 2014