linaro-dev July 2014

linaro-dev@lists.linaro.org

23 participants
48 discussions

by Dileep Katta

== Progress == * Enabling UEFI Fastboot on Panda - on hold (CARD-198: 0 %) * CARD 1103: Flash support on u-boot fastboot, downlload of image is working in case of Flash command. Shared the code with Andrey (CARD-1103: 60%) * CARD 1103: Flash support on u-boot fastboot, Adding DFU APIs is in progress (CARD-1103: 40%) == Plans == * CARD-198: Pause (0%) * CARD 1103: Flash support on u-boot fastboot, Add DFU code and submit for review, re-order the functionality as per review comments (CARD-1103: 100%) == Issues == * None

10 years, 5 months

detecting long multiply overflow

by Edward Nevill

Hi, Does anyone know of a nice way to detect 64 x 64 -> 64 multiply overflow on aarch64? On x86 you can just use the V flag, but aarch64 seems to have no option to set the flags after a MUL instruction which I find very odd. The only solution I can think of is to do the equivalent of r = a * b; if (r/a != b) overflow(); There is some short circuiting you can do to avoid the div if you know there is no possibility it could have overflowed. Eg. if (clz(labs(a)) + clz(labs(b)) < 32) { r = a * b; if (r/a != b) overflow(); } Then there is the special case of a = 0x8000000000000000 and b == -1. All in all its a mess just to detect overflow. Regards, Ed.

10 years, 5 months

[ACTIVITY] week 27

by Bernhard Rosenkränzer

== Progress == * More Bionic optimizations * Installed Android L preview on my Nexus 7, looked at the GPL code bits that were released * Code review+different approach for zlib optimizations * Checked upstream git for indications of how the NDK will handle 64bit systems (but the related code isn't there yet) == Plans == * Start cbuildv2 toolchain builds for testing * Restore Galaxy Nexus support * Check if the new aarch64 strchr in glibc 2014.07 can be reused in Bionic * Follow up on zlib optimizations etc. == Issues == * ci.linaro.org is broken

10 years, 5 months

[PATCH v4] pm-qa/cpuhotplug: Enable cpuhotplug on cpu0

by Lisa Nguyen

By default, cpuhotplug does not run on cpu0. However, if we want to allow cpuhotplug to run on cpu0, then we must pass the parameter, hotplug_allow_cpu0=1, to make check. Signed-off-by: Lisa Nguyen <lisa.nguyen(a)linaro.org> --- Changes from v3 to v4: - Remove =~ symbol and rewrote test condition in check_cpuhotplug_files() function Changes from v2 to v3: - Renamed is_cpu0_allowed() function to is_cpu0_hotplug_allowed() - Removed $cpu parameter from is_cpu0_allowed function() - Modified test condition in check_cpuhotplug_files() function Changes from v1 to v2: - Rename the parameter from hotplug_cpu_start to hotplug_allow_cpu0 - Add is_cpu0_allowed() function to check if we want to start running test scripts from cpu0..cpuN --- Makefile | 4 ++-- cpuhotplug/Makefile | 2 +- cpuhotplug/cpuhotplug_02.sh | 2 +- cpuhotplug/cpuhotplug_03.sh | 2 +- cpuhotplug/cpuhotplug_04.sh | 2 +- cpuhotplug/cpuhotplug_05.sh | 2 +- cpuhotplug/cpuhotplug_06.sh | 2 +- cpuhotplug/cpuhotplug_07.sh | 2 +- cpuhotplug/cpuhotplug_08.sh | 6 +++++- include/functions.sh | 20 ++++++++++++++++---- 10 files changed, 30 insertions(+), 14 deletions(-) diff --git a/Makefile b/Makefile index 731619d..d76deb7 100644 --- a/Makefile +++ b/Makefile @@ -21,14 +21,14 @@ # Torez Smith <torez.smith(a)linaro.org> (IBM Corporation) # - initial API and implementation # - +hotplug_allow_cpu0?=0 all: @(cd utils; $(MAKE)) check: @(cd utils; $(MAKE) check) @(cd cpufreq; $(MAKE) check) - @(cd cpuhotplug; $(MAKE) check) + @(cd cpuhotplug; $(MAKE) hotplug_allow_cpu0=${hotplug_allow_cpu0} check) @(cd cpuidle; $(MAKE) check) # @(cd suspend; $(MAKE) check) @(cd thermal; $(MAKE) check) diff --git a/cpuhotplug/Makefile b/cpuhotplug/Makefile index df0b8f4..6ee600d 100644 --- a/cpuhotplug/Makefile +++ b/cpuhotplug/Makefile @@ -21,5 +21,5 @@ # Daniel Lezcano <daniel.lezcano(a)linaro.org> (IBM Corporation) # - initial API and implementation # - +export hotplug_allow_cpu0?=0 include ../Test.mk diff --git a/cpuhotplug/cpuhotplug_02.sh b/cpuhotplug/cpuhotplug_02.sh index 3157307..d2bb5b4 100755 --- a/cpuhotplug/cpuhotplug_02.sh +++ b/cpuhotplug/cpuhotplug_02.sh @@ -34,7 +34,7 @@ check_state() { shift 1 if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi set_offline $cpu diff --git a/cpuhotplug/cpuhotplug_03.sh b/cpuhotplug/cpuhotplug_03.sh index 13a0ce9..2a5ae48 100755 --- a/cpuhotplug/cpuhotplug_03.sh +++ b/cpuhotplug/cpuhotplug_03.sh @@ -34,7 +34,7 @@ check_affinity_fails() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi set_offline $cpu diff --git a/cpuhotplug/cpuhotplug_04.sh b/cpuhotplug/cpuhotplug_04.sh index 394a512..7938e7d 100755 --- a/cpuhotplug/cpuhotplug_04.sh +++ b/cpuhotplug/cpuhotplug_04.sh @@ -37,7 +37,7 @@ check_task_migrate() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi taskset 0x$cpumask $CPUBURN $cpu & diff --git a/cpuhotplug/cpuhotplug_05.sh b/cpuhotplug/cpuhotplug_05.sh index a8eb312..4042f2c 100755 --- a/cpuhotplug/cpuhotplug_05.sh +++ b/cpuhotplug/cpuhotplug_05.sh @@ -33,7 +33,7 @@ check_procinfo() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi set_offline $cpu diff --git a/cpuhotplug/cpuhotplug_06.sh b/cpuhotplug/cpuhotplug_06.sh index 347906d..0461e37 100755 --- a/cpuhotplug/cpuhotplug_06.sh +++ b/cpuhotplug/cpuhotplug_06.sh @@ -33,7 +33,7 @@ check_procinfo() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi set_offline $cpu diff --git a/cpuhotplug/cpuhotplug_07.sh b/cpuhotplug/cpuhotplug_07.sh index eaeba77..a3526be 100755 --- a/cpuhotplug/cpuhotplug_07.sh +++ b/cpuhotplug/cpuhotplug_07.sh @@ -35,7 +35,7 @@ check_notification() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi # damn ! udevadm is buffering the output, we have to use a temp file diff --git a/cpuhotplug/cpuhotplug_08.sh b/cpuhotplug/cpuhotplug_08.sh index 9e2c355..00315a4 100755 --- a/cpuhotplug/cpuhotplug_08.sh +++ b/cpuhotplug/cpuhotplug_08.sh @@ -28,7 +28,11 @@ source ../include/functions.sh function randomize() { - echo $[ ( $RANDOM % $1 ) + 1 ] + if [ $hotplug_allow_cpu0 -eq 0 ]; then + echo $[ ( $RANDOM % $1 ) + 1 ] + else + echo $[ ( $RANDOM % $1 ) ] + fi } random_stress() { diff --git a/include/functions.sh b/include/functions.sh index 6d75e34..dd716ef 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -285,10 +285,12 @@ check_cpuhotplug_files() { shift 1 for i in $@; do - # skip check for cpu0 - if [ `echo $dirpath | grep -c "cpu0"` -eq 1 ]; then - continue - fi + if [ `echo $dirpath | grep -c "cpu0"` -eq 1 ]; then + if [ $hotplug_allow_cpu0 -eq 0 ]; then + continue + fi + fi + check_file $i $dirpath || return 1 done @@ -372,3 +374,13 @@ is_root() { fi return $ret } + +is_cpu0_hotplug_allowed() { + local status=$1 + + if [ $status -eq 1 ]; then + return 0 + else + return 1 + fi +} -- 1.7.9.5

10 years, 5 months

Redistributable ARM Mali GPU binary drivers

by Siarhei Siamashka

Hello, In the Q & A session at the AnandTech website, Jem Davies promised to deliver the redistributable binary drivers for the Mali GPU via Linaro, or at least he liked this idea very much: http://anandtech.com/comments/8226/ask-the-experts-arm-fellow-jem-davies-an… Does anybody have an estimate when this is going to happen? Or if this has already happened, could somebody help me to navigate the Linaro website to find the binaries accompanied with the appropriate license, which explicitly permits redistribution? So far I could only find the presumably outdated notices stating that "Ubuntu flavoured images released as Linaro engineering builds are not for production use, modification or redistribution, but are to be used for evaluation purposes only". Thanks. -- Best regards, Siarhei Siamashka

10 years, 5 months

[PATCH v3] pm-qa/cpuhotplug: Enable cpuhotplug on cpu0

by Lisa Nguyen

By default, cpuhotplug does not run on cpu0. However, if we want to allow cpuhotplug to run on cpu0, then we must pass the parameter, hotplug_allow_cpu0=1, to make check. Signed-off-by: Lisa Nguyen <lisa.nguyen(a)linaro.org> --- Changes from v2 to v3: - Renamed is_cpu0_allowed() function to is_cpu0_hotplug_allowed() - Removed $cpu parameter from is_cpu0_allowed function() - Modified test condition in check_cpuhotplug_files() function Changes from v1 to v2: - Rename the parameter from hotplug_cpu_start to hotplug_allow_cpu0 - Add is_cpu0_allowed() function to check if we want to start running test scripts from cpu0..cpuN --- Makefile | 4 ++-- cpuhotplug/Makefile | 2 +- cpuhotplug/cpuhotplug_02.sh | 2 +- cpuhotplug/cpuhotplug_03.sh | 2 +- cpuhotplug/cpuhotplug_04.sh | 2 +- cpuhotplug/cpuhotplug_05.sh | 2 +- cpuhotplug/cpuhotplug_06.sh | 2 +- cpuhotplug/cpuhotplug_07.sh | 2 +- cpuhotplug/cpuhotplug_08.sh | 6 +++++- include/functions.sh | 18 ++++++++++++++---- 10 files changed, 28 insertions(+), 14 deletions(-) diff --git a/Makefile b/Makefile index 731619d..d76deb7 100644 --- a/Makefile +++ b/Makefile @@ -21,14 +21,14 @@ # Torez Smith <torez.smith(a)linaro.org> (IBM Corporation) # - initial API and implementation # - +hotplug_allow_cpu0?=0 all: @(cd utils; $(MAKE)) check: @(cd utils; $(MAKE) check) @(cd cpufreq; $(MAKE) check) - @(cd cpuhotplug; $(MAKE) check) + @(cd cpuhotplug; $(MAKE) hotplug_allow_cpu0=${hotplug_allow_cpu0} check) @(cd cpuidle; $(MAKE) check) # @(cd suspend; $(MAKE) check) @(cd thermal; $(MAKE) check) diff --git a/cpuhotplug/Makefile b/cpuhotplug/Makefile index df0b8f4..6ee600d 100644 --- a/cpuhotplug/Makefile +++ b/cpuhotplug/Makefile @@ -21,5 +21,5 @@ # Daniel Lezcano <daniel.lezcano(a)linaro.org> (IBM Corporation) # - initial API and implementation # - +export hotplug_allow_cpu0?=0 include ../Test.mk diff --git a/cpuhotplug/cpuhotplug_02.sh b/cpuhotplug/cpuhotplug_02.sh index 3157307..d2bb5b4 100755 --- a/cpuhotplug/cpuhotplug_02.sh +++ b/cpuhotplug/cpuhotplug_02.sh @@ -34,7 +34,7 @@ check_state() { shift 1 if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi set_offline $cpu diff --git a/cpuhotplug/cpuhotplug_03.sh b/cpuhotplug/cpuhotplug_03.sh index 13a0ce9..2a5ae48 100755 --- a/cpuhotplug/cpuhotplug_03.sh +++ b/cpuhotplug/cpuhotplug_03.sh @@ -34,7 +34,7 @@ check_affinity_fails() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi set_offline $cpu diff --git a/cpuhotplug/cpuhotplug_04.sh b/cpuhotplug/cpuhotplug_04.sh index 394a512..7938e7d 100755 --- a/cpuhotplug/cpuhotplug_04.sh +++ b/cpuhotplug/cpuhotplug_04.sh @@ -37,7 +37,7 @@ check_task_migrate() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi taskset 0x$cpumask $CPUBURN $cpu & diff --git a/cpuhotplug/cpuhotplug_05.sh b/cpuhotplug/cpuhotplug_05.sh index a8eb312..4042f2c 100755 --- a/cpuhotplug/cpuhotplug_05.sh +++ b/cpuhotplug/cpuhotplug_05.sh @@ -33,7 +33,7 @@ check_procinfo() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi set_offline $cpu diff --git a/cpuhotplug/cpuhotplug_06.sh b/cpuhotplug/cpuhotplug_06.sh index 347906d..0461e37 100755 --- a/cpuhotplug/cpuhotplug_06.sh +++ b/cpuhotplug/cpuhotplug_06.sh @@ -33,7 +33,7 @@ check_procinfo() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi set_offline $cpu diff --git a/cpuhotplug/cpuhotplug_07.sh b/cpuhotplug/cpuhotplug_07.sh index eaeba77..a3526be 100755 --- a/cpuhotplug/cpuhotplug_07.sh +++ b/cpuhotplug/cpuhotplug_07.sh @@ -35,7 +35,7 @@ check_notification() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_hotplug_allowed $hotplug_allow_cpu0 || return 0 fi # damn ! udevadm is buffering the output, we have to use a temp file diff --git a/cpuhotplug/cpuhotplug_08.sh b/cpuhotplug/cpuhotplug_08.sh index 9e2c355..00315a4 100755 --- a/cpuhotplug/cpuhotplug_08.sh +++ b/cpuhotplug/cpuhotplug_08.sh @@ -28,7 +28,11 @@ source ../include/functions.sh function randomize() { - echo $[ ( $RANDOM % $1 ) + 1 ] + if [ $hotplug_allow_cpu0 -eq 0 ]; then + echo $[ ( $RANDOM % $1 ) + 1 ] + else + echo $[ ( $RANDOM % $1 ) ] + fi } random_stress() { diff --git a/include/functions.sh b/include/functions.sh index 6d75e34..d44706f 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -285,10 +285,10 @@ check_cpuhotplug_files() { shift 1 for i in $@; do - # skip check for cpu0 - if [ `echo $dirpath | grep -c "cpu0"` -eq 1 ]; then - continue - fi + if [[ $dirpath =~ cpu0$ && $hotplug_allow_cpu0 -eq 0 ]]; then + continue + fi + check_file $i $dirpath || return 1 done @@ -372,3 +372,13 @@ is_root() { fi return $ret } + +is_cpu0_hotplug_allowed() { + local status=$1 + + if [ $status -eq 1 ]; then + return 0 + else + return 1 + fi +} -- 1.7.9.5

10 years, 5 months

[PATCH POWERTOP] Fix various resource leaks

by Mohammad Merajul Islam Molla

Fixes some resource leaks detected by valgrind and coverity scan. diff --git a/src/devices/ahci.cpp b/src/devices/ahci.cpp index ac06460..7f704b6 100644 --- a/src/devices/ahci.cpp +++ b/src/devices/ahci.cpp @@ -64,8 +64,10 @@ static string disk_name(char *path, char *target, char *shortname) sprintf(line, "%s/%s/model", pathname, dirent->d_name); file = fopen(line, "r"); if (file) { - if (fgets(line, 4096, file) == NULL) + if (fgets(line, 4096, file) == NULL) { + fclose(file); break; + } fclose(file); c = strchr(line, '\n'); if (c) diff --git a/src/devices/devfreq.cpp b/src/devices/devfreq.cpp index e16951c..23c4b0c 100644 --- a/src/devices/devfreq.cpp +++ b/src/devices/devfreq.cpp @@ -238,6 +238,7 @@ void create_all_devfreq_devices(void) callback fn = &devfreq_dev_callback; process_directory(p.c_str(), fn); + closedir(dir); } void initialize_devfreq(void) diff --git a/src/perf/perf_bundle.cpp b/src/perf/perf_bundle.cpp index b0e982b..cf1ae11 100644 --- a/src/perf/perf_bundle.cpp +++ b/src/perf/perf_bundle.cpp @@ -142,8 +142,10 @@ static void parse_event_format(const char *event_name) buf = read_file(file); free(file); - if (!buf) + if (!buf) { + free(name); return; + } pevent_parse_event(perf_event::pevent, buf, strlen(buf), sys); free(name); diff --git a/src/tuning/bluetooth.cpp b/src/tuning/bluetooth.cpp index e0bdf12..5100a8a 100644 --- a/src/tuning/bluetooth.cpp +++ b/src/tuning/bluetooth.cpp @@ -144,8 +144,10 @@ int bt_tunable::good_bad(void) if (file) { char line[2048]; /* first line is standard header */ - if (fgets(line, 2047, file) == NULL) + if (fgets(line, 2047, file) == NULL) { + pclose(file); goto out; + } memset(line, 0, 2048); if (fgets(line, 2047, file) == NULL) { result = last_check_result = TUNE_GOOD; -- Thanks, -Meraj

10 years, 5 months

[PATCH v2] pm-qa/cpuhotplug: Run cpuhotplug on all cpus

by Lisa Nguyen

Run the cpuhotplug test suite on all cpus including cpu0. If we wish to skip cpu0, pass the parameter, hotplug_allow_cpu0=1, to make check like in these examples: sudo make -C cpuhotplug hotplug_allow_cpu0=1 check sudo make hotplug_allow_cpu0=1 check Changes from v1 to v2: - Rename the parameter from hotplug_cpu_start to hotplug_allow_cpu0 - Add is_cpu0_allowed() function to check if we want to start running test scripts from cpu0..cpuN Signed-off-by: Lisa Nguyen <lisa.nguyen(a)linaro.org> --- Makefile | 3 ++- cpuhotplug/Makefile | 2 +- cpuhotplug/cpuhotplug_02.sh | 3 +-- cpuhotplug/cpuhotplug_03.sh | 2 +- cpuhotplug/cpuhotplug_04.sh | 2 +- cpuhotplug/cpuhotplug_05.sh | 4 ++-- cpuhotplug/cpuhotplug_06.sh | 4 ++-- cpuhotplug/cpuhotplug_07.sh | 2 +- cpuhotplug/cpuhotplug_08.sh | 7 ++++++- include/functions.sh | 12 ++++++++++++ 10 files changed, 29 insertions(+), 12 deletions(-) diff --git a/Makefile b/Makefile index 731619d..9f26fd3 100644 --- a/Makefile +++ b/Makefile @@ -21,6 +21,7 @@ # Torez Smith <torez.smith(a)linaro.org> (IBM Corporation) # - initial API and implementation # +hotplug_allow_cpu0?=0 all: @(cd utils; $(MAKE)) @@ -28,7 +29,7 @@ all: check: @(cd utils; $(MAKE) check) @(cd cpufreq; $(MAKE) check) - @(cd cpuhotplug; $(MAKE) check) + @(cd cpuhotplug; $(MAKE) hotplug_allow_cpu0=${hotplug_allow_cpu0} check) @(cd cpuidle; $(MAKE) check) # @(cd suspend; $(MAKE) check) @(cd thermal; $(MAKE) check) diff --git a/cpuhotplug/Makefile b/cpuhotplug/Makefile index df0b8f4..6ee600d 100644 --- a/cpuhotplug/Makefile +++ b/cpuhotplug/Makefile @@ -21,5 +21,5 @@ # Daniel Lezcano <daniel.lezcano(a)linaro.org> (IBM Corporation) # - initial API and implementation # - +export hotplug_allow_cpu0?=0 include ../Test.mk diff --git a/cpuhotplug/cpuhotplug_02.sh b/cpuhotplug/cpuhotplug_02.sh index 3157307..58e1f02 100755 --- a/cpuhotplug/cpuhotplug_02.sh +++ b/cpuhotplug/cpuhotplug_02.sh @@ -24,7 +24,6 @@ # # URL : https://wiki.linaro.org/WorkingGroups/PowerManagement/Resources/TestSuite/P… - source ../include/functions.sh check_state() { @@ -34,7 +33,7 @@ check_state() { shift 1 if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_allowed $cpu $hotplug_allow_cpu0 || return 0 fi set_offline $cpu diff --git a/cpuhotplug/cpuhotplug_03.sh b/cpuhotplug/cpuhotplug_03.sh index 13a0ce9..b29ff8e 100755 --- a/cpuhotplug/cpuhotplug_03.sh +++ b/cpuhotplug/cpuhotplug_03.sh @@ -34,7 +34,7 @@ check_affinity_fails() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_allowed $cpu $hotplug_allow_cpu0 || return 0 fi set_offline $cpu diff --git a/cpuhotplug/cpuhotplug_04.sh b/cpuhotplug/cpuhotplug_04.sh index 394a512..543853f 100755 --- a/cpuhotplug/cpuhotplug_04.sh +++ b/cpuhotplug/cpuhotplug_04.sh @@ -37,7 +37,7 @@ check_task_migrate() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_allowed $cpu $hotplug_allow_cpu0 || return 0 fi taskset 0x$cpumask $CPUBURN $cpu & diff --git a/cpuhotplug/cpuhotplug_05.sh b/cpuhotplug/cpuhotplug_05.sh index a8eb312..2f33a0c 100755 --- a/cpuhotplug/cpuhotplug_05.sh +++ b/cpuhotplug/cpuhotplug_05.sh @@ -33,9 +33,9 @@ check_procinfo() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_allowed $cpu $hotplug_allow_cpu0 || return 0 fi - + set_offline $cpu TAB=$(printf "\t"); grep "processor$TAB: $cpuid" /proc/cpuinfo diff --git a/cpuhotplug/cpuhotplug_06.sh b/cpuhotplug/cpuhotplug_06.sh index 347906d..528aeca 100755 --- a/cpuhotplug/cpuhotplug_06.sh +++ b/cpuhotplug/cpuhotplug_06.sh @@ -33,9 +33,9 @@ check_procinfo() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_allowed $cpu $hotplug_allow_cpu0 || return 0 fi - + set_offline $cpu grep "CPU$cpuid" /proc/interrupts diff --git a/cpuhotplug/cpuhotplug_07.sh b/cpuhotplug/cpuhotplug_07.sh index eaeba77..00fd009 100755 --- a/cpuhotplug/cpuhotplug_07.sh +++ b/cpuhotplug/cpuhotplug_07.sh @@ -35,7 +35,7 @@ check_notification() { local ret= if [ "$cpu" == "cpu0" ]; then - return 0 + is_cpu0_allowed $cpu $hotplug_allow_cpu0 || return 0 fi # damn ! udevadm is buffering the output, we have to use a temp file diff --git a/cpuhotplug/cpuhotplug_08.sh b/cpuhotplug/cpuhotplug_08.sh index 9e2c355..0b1b9b6 100755 --- a/cpuhotplug/cpuhotplug_08.sh +++ b/cpuhotplug/cpuhotplug_08.sh @@ -28,7 +28,12 @@ source ../include/functions.sh function randomize() { - echo $[ ( $RANDOM % $1 ) + 1 ] + #if we are skipping cpu0 + if [ $hotplug_allow_cpu0 -ne 0 ]; then + echo $[ ( $RANDOM % $1 ) + 1 ] + else + echo $[ ( $RANDOM % $1 ) ] + fi } random_stress() { diff --git a/include/functions.sh b/include/functions.sh index 6d75e34..3ec2270 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -372,3 +372,15 @@ is_root() { fi return $ret } + +is_cpu0_allowed() { + local cpu=$1 + local status=$2 + + # Allow cpu0 to be tested + if [[ "$cpu" == "cpu0" && $status -eq 0 ]]; then + return 0 + else + return 1 + fi +} -- 1.7.9.5

10 years, 5 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev July 2014