linaro-dev August 2014

linaro-dev@lists.linaro.org

27 participants
43 discussions

by Wookey

= Progress == * Buildd-tending: Debian arm64 is at 84% built (DEVPLAT-226: 5%) http://buildd.debian-ports.org/stats/graph-quarter-big.png * binNMUed packages for arm64 debian-installer builds * rt-app accepted in debian. Asked rt-app authors to clarify GPL2/GPL2+ licencing * Fix and uploaded previously failed uploads: gtkgl2, exiv2 (DEVPLAT-226: 10%) * Unblocked blender cycle with opencolorio/openimageio * Doubled memory on 2nd buildd (but ghc builds still run out). (DEVPLAT-226: 2%) * Built ghc manually on bigger buildd (DEVPLAT-226: 5%) * Investigated persistently failing package builds (DEVPLAT-221: 15%) * Fixed libfm, rrdtool breakge (DEVPLAT-221: 10%) * Found rdeps of mpi-defaults. Did 15 binnmus +giveback to transition: (DEVPLAT-221: 10%) * Worked on openjade (crufty codebase need autofoo updates). (DEVPLAT-226: 20%) * Wrote card for official debian bootstrap * Investigated gcc-4.9 failure. Bug filed (DEVPLAT-226: 5%) * Tracked notmuch failure down to gdb/ptrace/kernel issue. Bug filed. (DEVPLAT-221: 10%) * Made current list/set of binaries to prime official new buildds with * GSOC catch-up with student after hols * BUilt updated cross-binutils packages - uploaded (DEVPLAT-220: 5%) * Worked on breakage in current cross-gcc packages for upcoming sprint: (DEVPLAT-220: 5%) == Plans == * Get cross-toolchain packages into buildable state * Add multiarch builds to sbuild * Fix/NMU remaining packages in SCC http://people.debian.org/~wookey/bootstrap/blockerlist == Issues == Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/

9 years, 8 months

[PATCH PM-QA] Simplify code to obtain number of cpus for a platform

by Lisa Nguyen

Create a global variable that will look for number of cpus for a platform and use it in multiple functions to make the code simplier to read. Signed-off-by: Lisa Nguyen <lisa.nguyen(a)linaro.org> --- cpufreq/cpufreq_05.sh | 6 +++--- cpuhotplug/cpuhotplug_sanity.sh | 1 - include/functions.sh | 13 +++++-------- include/thermal_functions.sh | 4 ++-- 4 files changed, 10 insertions(+), 14 deletions(-) diff --git a/cpufreq/cpufreq_05.sh b/cpufreq/cpufreq_05.sh index 93fce78..1f0dd8d 100755 --- a/cpufreq/cpufreq_05.sh +++ b/cpufreq/cpufreq_05.sh @@ -62,7 +62,7 @@ supported=$(cat $CPU_PATH/cpu0/cpufreq/scaling_available_governors | grep "ondem if [ -z "$supported" ]; then log_skip "ondemand not supported" else - for cpu in $(ls $CPU_PATH | grep "cpu[0-9].*"); do + for cpu in $cpus; do switch_ondemand $cpu done check_governor $cpu 'ondemand' @@ -72,7 +72,7 @@ supported=$(cat $CPU_PATH/cpu0/cpufreq/scaling_available_governors | grep "conse if [ -z "$supported" ]; then log_skip "conservative not supported" else - for cpu in $(ls $CPU_PATH | grep "cpu[0-9].*"); do + for cpu in $cpus; do switch_conservative $cpu done check_governor $cpu 'conservative' @@ -82,7 +82,7 @@ supported=$(cat $CPU_PATH/cpu0/cpufreq/scaling_available_governors | grep "users if [ -z "$supported" ]; then log_skip "userspace not supported" else - for cpu in $(ls $CPU_PATH | grep "cpu[0-9].*"); do + for cpu in $cpus; do switch_userspace $cpu done diff --git a/cpuhotplug/cpuhotplug_sanity.sh b/cpuhotplug/cpuhotplug_sanity.sh index d9b6af8..2ad24ff 100755 --- a/cpuhotplug/cpuhotplug_sanity.sh +++ b/cpuhotplug/cpuhotplug_sanity.sh @@ -33,7 +33,6 @@ fi check_cpuhotplug_sysfs_entry() { - cpus=$(ls $CPU_PATH | grep "cpu[0-9].*") cpunum=$(ls $CPU_PATH | grep "cpu[0-9].*" -c) if [ $cpunum -eq 1 ]; then diff --git a/include/functions.sh b/include/functions.sh index e0f08fb..74b2294 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -30,6 +30,7 @@ TEST_NAME=$(basename ${0%.sh}) PREFIX=$TEST_NAME INC=0 CPU= +cpus=$(ls $CPU_PATH | grep "cpu[0-9].*") pass_count=0 fail_count=0 skip_count=0 @@ -86,7 +87,6 @@ for_each_cpu() { local func=$1 shift 1 - cpus=$(ls $CPU_PATH | grep "cpu[0-9].*") for cpu in $cpus; do INC=0 CPU=/$cpu @@ -339,8 +339,8 @@ save_governors() { governors_backup= local index=0 - for i in $(ls $CPU_PATH | grep "cpu[0-9].*"); do - governors_backup[$index]=$(cat $CPU_PATH/$i/cpufreq/scaling_governor) + for cpu in $cpus; do + governors_backup[$index]=$(cat $CPU_PATH/$cpu/cpufreq/scaling_governor) index=$((index + 1)) done } @@ -350,9 +350,9 @@ restore_governors() { local index=0 local oldgov= - for i in $(ls $CPU_PATH | grep "cpu[0-9].*"); do + for cpu in $cpus; do oldgov=${governors_backup[$index]} - echo $oldgov > $CPU_PATH/$i/cpufreq/scaling_governor + echo $oldgov > $CPU_PATH/$cpu/cpufreq/scaling_governor index=$((index + 1)) done } @@ -361,8 +361,6 @@ save_frequencies() { frequencies_backup= local index=0 - local cpus=$(ls $CPU_PATH | grep "cpu[0-9].*") - local cpu= for cpu in $cpus; do frequencies_backup[$index]=$(cat $CPU_PATH/$cpu/cpufreq/scaling_cur_freq) @@ -374,7 +372,6 @@ restore_frequencies() { local index=0 local oldfreq= - local cpus=$(ls $CPU_PATH | grep "cpu[0-9].*") for cpu in $cpus; do oldfreq=${frequencies_backup[$index]} diff --git a/include/thermal_functions.sh b/include/thermal_functions.sh index a51240b..c25e1d8 100644 --- a/include/thermal_functions.sh +++ b/include/thermal_functions.sh @@ -184,7 +184,7 @@ check_scaling_freq() { local index=0 local flag=0 - for cpu in $(ls $CPU_PATH | grep "cpu[0-9].*"); do + for cpu in $cpus; do if [ $before_freq_list[$index] -ne $afterf_req_list[$index] ] ; then flag=1 fi @@ -197,7 +197,7 @@ store_scaling_maxfreq() { scale_freq= local index=0 - for cpu in $(ls $CPU_PATH | grep "cpu[0-9].*"); do + for cpu in $cpus; do scale_freq[$index]=$(cat $CPU_PATH/$cpu/cpufreq/scaling_max_freq) index=$((index + 1)) done -- 1.7.9.5

9 years, 8 months

[PATCH PM-QA] Remove increment variables from check function

by Lisa Nguyen

Remove the pass and fail count variables from the check() function as all the pass/fail/skip counts are done inside the log_end() function. Signed-off-by: Lisa Nguyen <lisa.nguyen(a)linaro.org> --- Note: This was supposed to be part of the refactored pass/skip/fail code, but it got overlooked. include/functions.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/functions.sh b/include/functions.sh index 82d8139..e0f08fb 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -265,13 +265,11 @@ check() { $func $@ if [ $? -ne 0 ]; then - log_end "Err" - fail_count=$(($fail_count + 1)) - return 1 + log_end "Err" + return 1 fi log_end "Ok" - pass_count=$(($pass_count + 1)) return 0 } -- 1.7.9.5

9 years, 8 months

[ACTIVITY] Week 32

by Vishal Bhoj

== Progress == * Integrate VPS into the build (CARD-789, 20%) * Setup Juno build based on master snapshot from 29th July (CARD-789, 20%) * Visa Documentation and submission (20%) == Plans == * CI and LAVA for SWG - ARMv7 TEE testing (CARD-1109) Regards, Vishal

9 years, 8 months

[ACTIVITY] Week 32

by Riku Voipio

== Progress == * Documented KVM ARMv8 CI loop (CARD-346 20%) * https://wiki.linaro.org/LEG/Engineering/Virtualization/Testing/KVM * Documented Xen ARMv8 CI loop (CARD-736 20%) * Debugged TC2 booting mainline kernels in lab (20%) * KVM CI fixes (30%) == Plans == * Set experimental build for gcov/arm (CARD-1488) * fix TC2 kvm tests == Issues ==

9 years, 8 months

[PATCH] Check the terminal window size is greater or equal to 80 columns

by Daniel Lezcano

All the output assumes the terminal width is 80 cols min, check the terminal size in order to detect a smaller terminal and prevent to have a nested output. Signed-off-by: Daniel Lezcano <daniel.lezcano(a)linaro.org> --- idlestat.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/idlestat.c b/idlestat.c index a0ef2dd..245be9e 100644 --- a/idlestat.c +++ b/idlestat.c @@ -34,6 +34,7 @@ #include <sched.h> #include <string.h> #include <float.h> +#include <sys/ioctl.h> #include <sys/time.h> #include <sys/types.h> #include <sys/resource.h> @@ -1380,6 +1381,23 @@ static int execute(int argc, char *argv[], char *const envp[], return -1; } +static int check_window_size(void) +{ + struct winsize winsize; + + /* Output is redirected */ + if (!isatty(STDOUT_FILENO)) + return 0; + + /* Get terminal window size */ + ioctl(STDOUT_FILENO, TIOCGWINSZ, &winsize); + + if (winsize.ws_col >= 80) + return 0; + + return -1; +} + int main(int argc, char *argv[], char *const envp[]) { struct cpuidle_datas *datas; @@ -1397,6 +1415,12 @@ int main(int argc, char *argv[], char *const envp[]) return -1; } + if (check_window_size()) { + fprintf(stderr, "The terminal must be at least " + "80 columns wide\n"); + return -1; + } + /* init cpu topoinfo */ init_cpu_topo_info(); -- 1.7.9.5

9 years, 9 months

[PATCH PM-QA v4] Refactor pass/fail/skip code in PM-QA

by Lisa Nguyen

Focus on returning the results of each test script rather than the results of each subtest. This will help to keep the number of PM-QA test results consistent across multiple boards regardless of number of frequencies, cores, etc. Examples before the refactoring: https://validation.linaro.org/dashboard/streams /anonymous/lisatn/bundles/331786fb33a49b060adccf51bb509d5f286422e7/ Examples after the refactoring: https://validation.linaro.org/dashboard/streams/anonymous /lisatn/bundles/076a3f890e58727f01a23e30d6eb438172b69c7d/ Once this patch is accepted and merged, then there will be a follow up patch to update the pwrmgmt test definition, so LAVA can record PM-QA results accurately. Signed-off-by: Lisa Nguyen <lisa.nguyen(a)linaro.org> --- Changes from v3 to v4: - Fix syntax errors that were undetected (e.g. space between a condition and end square bracket in an if statement) that affected the pass/fail/skip count Change from v2 to v3: - Fix a silly increment error for skip count cause I didn't look closely enough Changes from v1 to v2: - Rewrite test_status_show() function - Add description and log_skip() function in thermal_05 - Moved skip/fail/pass counts to log_end() function cpufreq/cpufreq_07.sh | 2 +- include/functions.sh | 35 ++++++++++++++++++++++++++++++----- thermal/thermal_05.sh | 3 ++- thermal/thermal_06.sh | 2 +- 4 files changed, 34 insertions(+), 8 deletions(-) diff --git a/cpufreq/cpufreq_07.sh b/cpufreq/cpufreq_07.sh index f8f9e8e..b65d212 100755 --- a/cpufreq/cpufreq_07.sh +++ b/cpufreq/cpufreq_07.sh @@ -74,7 +74,7 @@ check_ondemand() { supported=$(cat $CPU_PATH/cpu0/cpufreq/scaling_available_governors | grep "ondemand") if [ -z "$supported" ]; then log_skip "ondemand not supported" - exit 0 + return 0 fi save_governors diff --git a/include/functions.sh b/include/functions.sh index 417c725..3f5acf4 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -32,14 +32,31 @@ INC=0 CPU= pass_count=0 fail_count=0 +skip_count=0 +test_script_status="pass" test_status_show() { - echo "-------- total = $(($pass_count + $fail_count))" - echo "-------- pass = $pass_count" - # report failure only if it is there - if [ $fail_count -ne 0 ] ; then - echo "-------- fail = $fail_count" + if [ $fail_count -ne 0 ]; then + test_script_status="fail" + else + if [ $skip_count -ne 0 ]; then + if [ $pass_count -ne 0 ]; then + test_script_status="pass" + else + test_script_status="skip" + fi + fi + fi + + echo " " + if [[ "$test_script_status" == "fail" ]]; then + echo "$TEST_NAME: fail" + elif [[ "$test_script_status" == "skip" ]]; then + echo "$TEST_NAME: skip" + else + echo "$TEST_NAME: pass" fi + echo " " } log_begin() { @@ -49,6 +66,14 @@ log_begin() { log_end() { printf "$*\n" + + if [[ "$*" == "Err" ]]; then + fail_count=$((fail_count + 1)) + elif [[ "$*" == "skip" ]]; then + skip_count=$((skip_count + 1)) + else + pass_count=$((pass_count + 1)) + fi } log_skip() { diff --git a/thermal/thermal_05.sh b/thermal/thermal_05.sh index 05f83d1..52a0ac2 100755 --- a/thermal/thermal_05.sh +++ b/thermal/thermal_05.sh @@ -36,7 +36,8 @@ verify_cpufreq_cooling_device_action() { local cpufreq_cdev=$(cat $dirpath/type) cat $dirpath/type | grep cpufreq if [ $? -ne 0 ] ; then - return 0 + log_skip "Cannot find cpufreq in $cdev_name..." + return 0 fi local max_state=$(cat $dirpath/max_state) diff --git a/thermal/thermal_06.sh b/thermal/thermal_06.sh index 92c987a..d8877f0 100755 --- a/thermal/thermal_06.sh +++ b/thermal/thermal_06.sh @@ -30,7 +30,7 @@ source ../include/thermal_functions.sh if [ "$thermal_try_max" -eq 0 ]; then log_skip "test of trip points being crossed" - exit 0 + return 0 fi TEST_LOOP=100 -- 1.7.9.5

9 years, 9 months

[PATCH PMQA] cpufreq: consider sampling rate to calculate scaling time

by Sanjay Singh Rawat

- add the governor sampling rate with the frequency transition latency to make sure tansition happens. - bug 77 Signed-off-by: Sanjay Singh Rawat <sanjay.rawat(a)linaro.org> --- include/functions.sh | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/include/functions.sh b/include/functions.sh index 417c725..5823a81 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -123,6 +123,17 @@ wait_latency() { local dirpath=$CPU_PATH/$cpu/cpufreq local latency= local nrfreq= + local sampling_rate= + local sleep_time= + local gov=$(cat $dirpath/scaling_governor) + + # consider per-policy governor case + if [ -e $CPU_PATH/$cpu/cpufreq/$gov ]; then + sampling_rate=$(cat $CPU_PATH/$cpu/cpufreq/$gov/sampling_rate) + else + sampling_rate=$(cat $CPU_PATH/cpufreq/$gov/sampling_rate) + fi + sampling_rate=$((sampling_rate * 1000)) # unit nsec latency=$(cat $dirpath/cpuinfo_transition_latency) if [ $? -ne 0 ]; then @@ -135,7 +146,10 @@ wait_latency() { fi nrfreq=$((nrfreq + 1)) - ../utils/nanosleep $(($nrfreq * $latency)) + + sleep_time=$(($latency + $sampling_rate)) + + ../utils/nanosleep $(($nrfreq * $sleep_time)) } frequnit() { -- 1.8.3.2

9 years, 9 months

[Activity] Week 31

by Dileep Katta

== Progress == * Enabling UEFI Fastboot on Panda - on hold (CARD-198: 0 %) * CARD 1103: Flash support on u-boot fastboot (CARD-1103: 100%) - Fixed build errors on omap3 beagle config - consolidated the patches into two, and submitted patches for review http://lists.denx.de/pipermail/u-boot/2014-August/185194.html http://lists.denx.de/pipermail/u-boot/2014-August/185195.html == Plans == * CARD-198: Start working on the activity on Panda/BBB (40%) * CARD 1103: Send the patches for review to u-boot mailing list and upstream. (CARD-1103: 60%) - Fix the review comments and code standard related issues == Issues == * None

9 years, 9 months

[ACTIVITY] week 31

by Vishal Bhoj

== Progress == * 14.07 Release (card-789, 30%) * LSK-CI for 3.14 (CARD-789, 10%) * Integrating VPS in android-build ci (CARD-789, 20%) == Plans == * Finish VPS integration. == Issues == * None Regards, Vishal

9 years, 9 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev August 2014