On Tue, Nov 15, 2011 at 6:36 AM, Rajendra Nayak rnayak@ti.com wrote:
Fix some minor typos in the pinctrl documentation.
(...)
-the pins from 0 in the upper left corner to 63 in the lower right corner, +the pins from 0 in the lower left corner to 63 in the upper right corner,
It's the PINCTRL_PIN() defintions that are wrong, this text is correct.
So it should be:
const struct pinctrl_pin_desc foo_pins[] = { PINCTRL_PIN(0, "A8"), PINCTRL_PIN(1, "B8"), PINCTRL_PIN(2, "C8"), ... PINCTRL_PIN(61, "F1"), PINCTRL_PIN(62, "G1"), PINCTRL_PIN(63, "H1"), };
Fixed this, will send another patch.
-static struct pinctrl_gpio_range gpio_range_a = { +static struct pinctrl_gpio_range gpio_range_b = {
OK fixed this.
.name = "chip b", .id = 0, .base = 48, @@ -762,42 +762,42 @@ case), we define a mapping like this: .name "2bit" .ctrl_dev_name = "pinctrl.0", .function = "mmc0",
- .group = "mmc0_0_grp",
- .group = "mmc0_1_grp",
.dev_name = "foo-mmc.0", }, { .name "4bit" .ctrl_dev_name = "pinctrl.0", .function = "mmc0",
- .group = "mmc0_0_grp",
- .group = "mmc0_1_grp",
.dev_name = "foo-mmc.0", }, { .name "4bit" .ctrl_dev_name = "pinctrl.0", .function = "mmc0",
- .group = "mmc0_1_grp",
- .group = "mmc0_2_grp",
.dev_name = "foo-mmc.0", }, { .name "8bit" .ctrl_dev_name = "pinctrl.0", .function = "mmc0",
- .group = "mmc0_0_grp",
- .group = "mmc0_1_grp",
.dev_name = "foo-mmc.0", }, { .name "8bit" .ctrl_dev_name = "pinctrl.0", .function = "mmc0",
- .group = "mmc0_1_grp",
- .group = "mmc0_2_grp",
.dev_name = "foo-mmc.0", }, { .name "8bit" .ctrl_dev_name = "pinctrl.0", .function = "mmc0",
- .group = "mmc0_2_grp",
- .group = "mmc0_3_grp",
.dev_name = "foo-mmc.0", },
OK fixed this...
I'll submit a separate patch with your Reported-by: and Randy's fixes folded in.
Thanks, Linus Walleij