Hi, Arnd,
On Fri, Mar 11, 2011 at 8:10 PM, Arnd Bergmann arnd@arndb.de wrote:
On Friday 11 March 2011, Jason Hui wrote:
Alternatively, it could be done the other way round: rename the identifiers in the file from mx51_ to mx5_, and make sure that they don't contain any mx51 specific settings but always refer to properties in the device tree for the differences.
I saw that your V4 still implements neither Shawn's suggestion nor mine.
As you said, I don't want to make thing complex too. I don't want to have mx51_dt or mx53_dt as Shawn Suggests and I still don't want to make it change to mx5 now as you suggest Since this patch only support mx51 currently. I think it's easy to make change later once mx53 in-deed added in DT support, what do you think?
It would also be easy to rename the file from mx51_dt to board_dt when it becomes more generic. I don't consider it a show-stopper though and am comfortable with leaving it to your own judgement.
Thanks for the comments. I will keep as it's now.
Generally speaking, you don't have to do everything that reviewers suggest, but please reply to explain your reasons if you disagree.
Yes, correct. :)
Arnd