On Mon, Oct 10, 2011 at 10:23:53AM +0200, Linus Walleij wrote:
On Sun, Oct 9, 2011 at 11:36 AM, Shawn Guo shawn.guo@freescale.com wrote:
- @hog_on_boot: if this is set to true, the regulator subsystem will itself
^^^^^^^^^ s/regulator/pinmux?
Yep!
+#endif /* !CONFIG_PINCTRL */
s/!CONFIG_PINCTRL/CONFIG_PINMUX?
Yep!
Foldes into original patch with a fixup comment.
Can I have your Reviewed-by: tag on this subsystem?
Sorry, not yet. This is not a full review. I'm trying to migrate imx pinctrl to the subsystem. And all these are just some random spotting.
Another couple of typo on pinctrl.txt?
diff --git a/Documentation/pinctrl.txt b/Documentation/pinctrl.txt new file mode 100644 index 0000000..2915fea --- /dev/null +++ b/Documentation/pinctrl.txt @@ -0,0 +1,951 @@
[...]
+The example 8x8 PGA package above will have pin numbers 0 thru 63 assigned to +its physical pins. It will name the pins { A1, A2, A3 ... H6, H7, H8 } using +pinctrl_register_pins_[sparse|dense]() and a suitable data set as shown
It should just be pinctrl_register_pins()?
+earlier.
[...]
+System pinmux hogging +=====================
+A system pinmux map entry, i.e. a pinmux setting that does not have a device +associated with it, can be hogged by the core when the pin controller is +registered. This means that the core will attempt to call regulator_get() and +regulator_enable() on it immediately after the pin control device has been +registered.
s/regulator_get/pinmux_get, and s/regulator_enable/pinmux_enable