Re: [PATCH] sched/fair: Set se->vruntime directly in place_entity()

On 8 November 2012 13:33, Viresh Kumar viresh.kumar@linaro.org wrote:

We are first storing the new vruntime in a variable and then storing it in se->vruntime. Simply update se->vruntime directly.

Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

kernel/sched/fair.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index a319d56c..820a2f1 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1454,9 +1454,7 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int initial) }

    /* ensure we never gain time by being placed backwards. */

•   vruntime = max_vruntime(se->vruntime, vruntime);
  

•   se->vruntime = vruntime;
  

•   se->vruntime = max_vruntime(se->vruntime, vruntime);
  

}

Ping!!