6 Feb
2012
6 Feb
'12
6:16 a.m.
Hi, As there are no changes in other patches. So is it fine to only send this patch.
On 4 February 2012 01:01, Mike Frysinger vapier@gentoo.org wrote:
On Friday 03 February 2012 11:05:57 Chander Kashyap wrote:
board/samsung/smdk5250/tools/mkexynos_image.c | 117 create mode 100644 tools/mksmdk5250spl.c
something funky in your diffstat ... says you're creating tools/ but the diffstat shows board/.../tools/. but the diff below looks correct.
--- /dev/null +++ b/tools/mksmdk5250spl.c
you could still name it "mkexynos_image". up to you.
- if (fstat(ifd, &stat)) {
- close(ifd);
- close(ofd);
- }
looks like you should issue a warning + exit here -mike
--
with warm regards,
Chander Kashyap