On Wed, Mar 21, 2012 at 10:13 AM, Jean Delvare khali@linux-fr.org wrote:
On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote:
Basically without this patch changing the mode of thermal zone is not possible as wrong string size is passed to strncmp.
Actually it is possible, $ echo -n disabled > mode works fine. But it fails without the -n, your patch would fix that.
Acked-by: Jean Delvare khali@linux-fr.org
Note that a quick grep suggests that drivers/misc/ad525x_dpot.c, security/selinux/hooks.c and arch/m68k/sun3/prom/console.c suffer from the same issue, if you want to fix them too.
I do see that we use sizeof() for strings in the selinux code, but I don't see a place that it is a bug. If you see a bug let me know and I'd be happy to fix it!
-Eric