Re: [Patch v2 04/11]Power: DA9052 battery driver

On Thu, Aug 04, 2011 at 06:17:52PM +0530, ashishj3 wrote:

On Fri, 2011-07-22 at 18:22 +0530, ashishj3 wrote:

...

Driver for DA9052 battery charger. This driver depends on DA9052 MFD core dirver for definitions and methods.

Signed-off-by: David Dajun Chen dchen@diasemi.com Signed-off-by: Ashish Jangam ashish.jangam@kpitcummins.com

---

Changes since v2

• Correct code styling for inline functions
• Remove averaging algorithm
• Set use_for_apm thru board specific parameter

---

Any comments on this patch?

Despite some cosmetic issues, the patch looks OK to me.

So, I'm fine if it goes via MFD tree.

Although, if you ever need to respin this patch, try to make the code fully conform to the Linux coding style.

Thanks,