On Wed, 2011-03-09 at 09:38 +0100, Arnd Bergmann wrote:
On Wednesday 09 March 2011 03:32:35 John Stultz wrote:
Thoughts and feedback (or alternate approaches) would be appreciated.
thanks -john
CC: Grant Likely grant.likely@secretlab.ca CC: Jason Hui jason.hui@linaro.org CC: patches@linaro.org Signed-off-by: John Stultz john.stultz@linaro.org
The patch looks fine to me (as far as my little Kconfig knowledge goes). Two comments about the submission form though:
- Ideally, the initial description is split into two parts: one
that is suitable as a changelog and the other that is your personal comment, including the "thanks" part, and put it below the --- line, so that git can automatically cut it.
Yea, although early on I tend to be a little more informal, I do usually clean up the commit log before actually submitting anything more then RFC level code.
- I think you should also Cc the Kconfig maintainer, Roman
Zippel zippel@linux-m68k.org, and linux-kbuild@vger.kernel.org.
This patch was actually submitted to both a few weeks ago. In this case, as I'm trying to RFC the overview of what I'm trying to accomplish specifically on the linaro list, I trimmed the cc list. Once I sort out the Linaro distro policy bits, and can drop the last quarter of the patch set, I'll likely resubmit the entirety to the kbuild list (and Roman, although he seems to be MIA these days).
thanks for the feedback! -john