Re: [PATCH 3/3] sched: cfs.nr_running does not contain the intended metric

Fixing linaro dev address

On 16 May 2013 22:18, Chris Redpath chris.redpath@arm.com wrote:

rq->nr_running is the actual number of runnable tasks we wish to use to determine if a task is alone on a CPU.

Change-Id: Icaf3022e02924ecdc94e14d4146c6fadd9580e2b Signed-off-by: Chris Redpath chris.redpath@arm.com

---

kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 3a53343..861c98d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3871,7 +3871,7 @@ static inline unsigned int hmp_offload_down(int cpu, struct sched_entity *se) return NR_CPUS;

    /* Is the task alone on the cpu? */

•   if (cpu_rq(cpu)->cfs.nr_running < 2)
  

•   if (cpu_rq(cpu)->nr_running < 2)
            return NR_CPUS;
  
    /* Is the task actually starving? */
  

-- 1.7.9.5