On 10/30/2012 08:55 AM, Viresh Kumar wrote:
On 30 October 2012 13:23, Daniel Lezcano daniel.lezcano@linaro.org wrote:
From: Viresh Kumar viresh.kumar@linaro.org
config NET_DSA_TAG_DSA
bool
bool "Original DSA packet tagging format"select NET_DSttypo NET_DSA
Unbelievable mistake :(
Will fix it after some reviews now :)
Yeah, has to be ! ;)
It is very curious if we disable all the configs option, a slave creation raise a BUG (cf. dsa_slave_create). IIUC, booting with NET_DSA enabled and none of the NET_DSA_TAG* enabled will raise a BUG in the probe function, right ?
Maybe we should force at least one config when none are set ?
diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig index 274791c..86326e3 100644 --- a/net/dsa/Kconfig +++ b/net/dsa/Kconfig @@ -1,8 +1,9 @@ -config NET_DSA +menuconfig NET_DSA tristate "Distributed Switch Architecture support" default n depends on EXPERIMENTAL && NETDEVICES && !S390 select PHYLIB + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA && !NET_DSA_TAG_TRAILER) ---help--- This allows you to use hardware switch chips that use the Distributed Switch Architecture. @@ -12,15 +13,15 @@ if NET_DSA
# tagging formats config NET_DSA_TAG_DSA - bool + bool "tag dsa" default n
config NET_DSA_TAG_EDSA - bool + bool "tag edsa" default n
config NET_DSA_TAG_TRAILER - bool + bool "tag trailer" default n
endif