On Wed, Mar 21, 2012 at 6:49 PM, Jean Pihet jean.pihet@newoldbits.com wrote:
Hi Santosh, Daniel,
On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar santosh.shilimkar@ti.com wrote:
Daniel,
On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote:
This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not change the behavior of the driver itself.
A couple a things call my intention. Why the cpuidle device is set for cpu0 only and why the WFI is not used ?
Daniel Lezcano (7): ARM: OMAP4: cpuidle - Remove unused valid field ARM: OMAP4: cpuidle - Declare the states with the driver declaration ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at boot time
The series looks fine to me in general. This clean-up is applicable for OMAP3 cpuidle code as well.
I want Jean to look at this series because some of his earlier clean up has introduced those custom functions which are getting removed in this series.
I am OK with the patch set, I only have minor remarks to the individual patches.
Reviewed-by: Jean Pihet j-pihet@ti.com
Thanks Jean for looking at it.
Daniel, Feel free to add. Reviewed-by: Santosh Shilimkar santosh.shilimkar@ti.com