21 Apr
2011
21 Apr
'11
8:17 a.m.
On Tue, Apr 19, 2011 at 12:21:01PM +0200, Wolfram Sang wrote:
+static int __devinit sdhci_esdhc_probe(struct platform_device *pdev) +{
- struct sdhci_host *host;
- int ret;
- host = sdhci_pltfm_init(pdev, &sdhci_esdhc_pdata);
- if (!host)
return -ENOMEM;Just noticed: Since pltfm_init may fail due to various reasons, maybe ERRPTR might be a good idea?
Ok.
[...]
+static int __init sdhci_hlwd_init(void) +{
- return platform_driver_register(&sdhci_hlwd_driver);
+} +module_init(sdhci_hlwd_init);
+static void __exit sdhci_hlwd_exit(void) +{
- platform_driver_unregister(&sdhci_hlwd_driver);
+} +module_exit(sdhci_hlwd_exit);
+MODULE_DESCRIPTION("Secure Digital Host Controller Interface OF driver"); +MODULE_AUTHOR("Xiaobo Xie X.Xie@freescale.com, "
"Anton Vorontsov <avorontsov@ru.mvista.com>");+MODULE_LICENSE("GPL v2");
Please double check the authors. It is based on the fsl driver, but the copyright should go to
- Copyright (C) 2009 The GameCube Linux Team
- Copyright (C) 2009 Albert Herranz
I think.
Sorry, I misread the current copyright in sdhci-of-hlwd.c. You are right.
--
Regards,
Shawn