Re: [PATCH v2 6/7] clk: Add initial WM831x clock driver

On Sat, Sep 24, 2011 at 10:08:36PM -0600, Grant Likely wrote:

On Thu, Sep 22, 2011 at 03:27:01PM -0700, Mike Turquette wrote:

...

• ret = platform_driver_register(&wm831x_clk_driver);
• if (ret != 0)

• pr_err("Failed to register WM831x clock driver: %d\n", ret);
  

• return ret;

No need for this song-and-dance. The driver core is pretty well debugged. Just use "return platform_driver_register(...);"

No, that's not helpful. The issue isn't the device probe code itself, the issue is things like module unload not doing what they're supposed to do and leaving the device lying around or something - there's rather more going on than just the plain API call.