On Tue, 13 Dec 2011, Turquette, Mike wrote:
On Tue, Dec 13, 2011 at 8:27 PM, Paul Walmsley paul@pwsan.com wrote:
On Tue, 13 Dec 2011, Mike Turquette wrote:
omap_clk_get_by_name must die.
You do realize that it exists for a reason? That hardware clock names don't have anything to do with the Linux device model?
We have a tree structure of clks in the new common clk code, and a list of clks in clkdev (which admittedly is meant to be a subset, but in reality we register every OMAP clk with it), and then the omap clk list which is only really used by omap_get_clk_by_name for hwmod and some initialization stuff. What I'd really like to do is get rid of the OMAP clk code keeping track of it's clks in a separate list, which seems quite wasteful.
Clock lookups that only involve a hardware clock name, with no device, should be the province of the clock code itself, not clkdev. The clkdev code may handle this today in the OMAP code, but this is simply due to legacy reasons.
In general, on OMAP, we've got much faster ways now to implement clk_get().
- Paul