Dear Chander Kashyap,
On 25 January 2012 14:25, Chander Kashyap chander.kashyap@linaro.org wrote:
It updates the missing gpio configuration of UART port.
Signed-off-by: Chander Kashyap chander.kashyap@linaro.org Cc: HeungJun, Kim riverful.kim@samsung.com
board/samsung/trats/trats.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c index f795ff0..4c9773d 100644 --- a/board/samsung/trats/trats.c +++ b/board/samsung/trats/trats.c @@ -337,7 +337,7 @@ static void board_uart_init(void) int i;
/* UART0-UART1 GPIOs (part1) : 0x22222222 */
- for (i = 0; i < 7; i++) {
- for (i = 0; i < 8; i++) {
s5p_gpio_set_pull(&gpio1->a0, i, GPIO_PULL_NONE); s5p_gpio_cfg_pin(&gpio1->a0, i, GPIO_FUNC(0x2)); } @@ -347,7 +347,7 @@ static void board_uart_init(void) * GPA1CON[3] = I2C_3_SCL (3) * GPA1CON[2] = I2C_3_SDA (3) */
- for (i = 0; i < 5; i++) {
- for (i = 0; i < 6; i++) {
s5p_gpio_set_pull(&gpio1->a1, i, GPIO_PULL_NONE); s5p_gpio_cfg_pin(&gpio1->a1, i, GPIO_FUNC((i == 2 || i == 3) ? 0x3 : 0x2)); --
Actually we don't have to set all of UARTs. Because, we only use UART2 for serial. I will post new patch for it.
Thanks Minkyu Kang.