Re: [PATCH] Fix NULL-dereference introduced by OMAP4 PMU patch

On 06/14/2011 10:41 AM, Somebody in the thread at some point said:

Hi -

This patch fixes a NULL-dereference introduced by commit 457520e ("arm: pmu: support pmu/perf on OMAP4").

Some platforms (e.g. vexpress) neither need nor have an instance of arm_pmu_platdata (plat). Perf support on these platforms was broken by the original commit.

This patch adds a check for plat before dereferencing any fields.

Looks like a good idea...

• } else if (plat->enable_irq)
  

• } else if (plat&&  plat->enable_irq) {
  plat->enable_irq(irq);
  

• }
  

...you can lose the { } though

-Andy