On 1 March 2012 03:24, Tushar Behera tushar.behera@linaro.org wrote:
On 02/29/2012 06:31 PM, Thomas Abraham wrote:
Hi Sangwook,
On 29 February 2012 18:11, Sangwook Lee sangwook.lee@linaro.org wrote:
Enable burst transfer from AHB for EHCI. This fixes data transfer of USB Ethernet with EHCI. Without this patch, scp hardly works.
Signed-off-by: Sangwook Lee sangwook.lee@linaro.org
arch/arm/mach-exynos/setup-usb-phy.c | 6 ++++++ arch/arm/plat-samsung/devs.c | 2 ++ arch/arm/plat-samsung/include/plat/ehci.h | 19 +++++++++++++++++++ 3 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos/setup-usb-phy.c
b/arch/arm/mach-exynos/setup-usb-phy.c
index 41743d2..5a20460 100644 --- a/arch/arm/mach-exynos/setup-usb-phy.c +++ b/arch/arm/mach-exynos/setup-usb-phy.c @@ -18,6 +18,7 @@ #include <mach/regs-usb-phy.h> #include <plat/cpu.h> #include <plat/usb-phy.h> +#include <plat/ehci.h>
static atomic_t host_usage;
@@ -149,3 +150,8 @@ int s5p_usb_phy_exit(struct platform_device *pdev,
int type)
return -EINVAL;}
+void s5p_ehci_burst_enable(struct platform_device *pdev, void __iomem
*base)
+{
writel(EHCI_INSNREG00_ENABLE_BURST, base + EHCI_INSNREG00);+}
This functionality can be added in ehci-s5p itself and avoid adding a new platform callback in platform data. If this is specific to exynos, driver data could be added in ehci-s5p to indicate platforms that need this to be enabled.
Am I right in assuming that ehci-s5p driver can also be used for mach-s5pv210?
The related bit-fields are reserved in S5PV210. So, won't it cause any side-effects?
do we use ehci-s5p.c in CPU 64xx series ?
Thanks, Thomas.
[...]
To unsubscribe from this list: send the line "unsubscribe
linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Tushar Behera