Re: [PATCH] usb: musb: ux500: set dma config for both src and dst

On 08/02/2011 05:33 PM, Per FORLIN wrote:

From: Per Forlinper.forlin@linaro.org

The dma driver requires both src and dst to be set. This fix is needed in order to run gadget mass storage. Patch is verified on snowball.

Signed-off-by: Per Forlinper.forlin@linaro.org

drivers/usb/musb/ux500_dma.c | 16 +++++++--------- 1 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/musb/ux500_dma.c b/drivers/usb/musb/ux500_dma.c index cecace4..2313475 100644 --- a/drivers/usb/musb/ux500_dma.c +++ b/drivers/usb/musb/ux500_dma.c @@ -133,15 +133,13 @@ static bool ux500_configure_channel(struct dma_channel *channel, DMA_SLAVE_BUSWIDTH_4_BYTES;

slave_conf.direction = direction;

• if (direction == DMA_FROM_DEVICE) {

• slave_conf.src_addr = usb_fifo_addr;
  

• slave_conf.src_addr_width = addr_width;
  

• slave_conf.src_maxburst = 16;
  

• } else {

• slave_conf.dst_addr = usb_fifo_addr;
  

• slave_conf.dst_addr_width = addr_width;
  

• slave_conf.dst_maxburst = 16;
  

• }

• slave_conf.src_addr = usb_fifo_addr;
• slave_conf.src_addr_width = addr_width;
• slave_conf.src_maxburst = 16;
• slave_conf.dst_addr = usb_fifo_addr;
• slave_conf.dst_addr_width = addr_width;
• slave_conf.dst_maxburst = 16;
• dma_chan->device->device_control(dma_chan, DMA_SLAVE_CONFIG, (unsigned long)&slave_conf);

Acked-by: Mian Yousaf Kaukab mian.yousaf.kaukab@stericsson.com

Thanks,