Em Fri, Jun 08, 2012 at 04:23:27PM +0400, Dmitry Antipov escreveu:
Use trace_find_event to find event name before looking through /sys files. This helps 'perf report' to show real event names instead of 'unknown:unknown' when processing perf.data recorded on another machine.
We have to somehow tell perf_evlist__tty_browse_hists that it should try to figure out the name of the event by looking at _either_ /sys (local events) or what came in the perf.data file.
That is because 'perf top' and 'perf report' uses perf_evlist__tty_browse_hists. One is for local events (top) and the other for perf.data files, that may or not be for local (in the sense of running the same kernel for record + report) or for "remote" (running on the same machine but with a different kernel at record than the one used at report) or from a different machine altogether, perhaps even different arch.
So I think that what needs to be done is to cache the right event name before getting to the hists browser. I.e. when setting up the events locally or when reading the events from the perf.data header, this way perf_evsel__name() can be used everywhere and will just return event->name, BUG_ON if event->name is NULL, i.e. wasn't resolved already.
- Arnaldo
Signed-off-by: Dmitry Antipov dmitry.antipov@linaro.org
tools/perf/builtin-report.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 8c767c6..a6fd309 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -24,6 +24,7 @@ #include "util/evlist.h" #include "util/evsel.h" #include "util/header.h" +#include "util/trace-event.h" #include "util/session.h" #include "util/tool.h" @@ -314,7 +315,8 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist, list_for_each_entry(pos, &evlist->entries, node) { struct hists *hists = &pos->hists;
const char *evname = event_name(pos);
struct event_format *event = trace_find_event(pos->attr.config);const char *evname = event ? event->name : event_name(pos);hists__fprintf_nr_sample_events(hists, evname, stdout); hists__fprintf(hists, NULL, false, true, 0, 0, stdout); -- 1.7.7.6