Re: [PATCH] [RFC]: mfd: Implement DT Support for AB8500 Btemp and fg

On 29/06/12 20:44, Rajanikanth HV wrote:

thanks for your review comments, i will post it on public branch, how about a review from abx500 bm data structure perspective ref: arch/arm/mach-ux500/board-mop500-bm.c

I already did:

...

It looks like you've just taken values for all of the possible combinations. Is this to support different batteries, or different platforms/machines?

The values you put into the Device Tree should be Snowball specific, but it looks like you've loaded it up with _everything_. You need to make sure that all of the information you put in makes sense when booting the Snowball board. Any values which will never be used need to be extracted.

Kind regards, Lee