On Mon, 12 Sep 2011 14:21:26 -0500 Rob Clark rob.clark@linaro.org wrote:
From: Rob Clark rob@ti.com
Signed-off-by: Rob Clark rob@ti.com
Generally looks sensible but:
1. This is a staging driver, so good practise is to cc the staging maintainer and preferably the author (though I'm on dri-devel so its ok). It needs to be co-ordinated with existing staging changes and the maintainer needs to know what is going on
2. It needs a changelog. Your 0/6 won't be in the git tree and someone chasing regressions may only see the individual patch changelog and not be sure what it relates to. From/Signed off by alone is not helpful.
3. GMA500 used the old way of doing things because last mail conversation I had with Hugh the cleaned up interfaces could not guarantee the page is mapped in the low 32bits and for any of the GMA500/600 series devices.
Has that changed ? I think I'd also prefer it if the methods had a BUG_ON() getting a high page when they asked for DMA32.
Alan