On 11/07/2012 07:45 PM, Rajanikanth H V wrote:
On Thu, 1 Nov 2012, Francesco Lavra wrote: [...]
- btech = of_get_property(np_bat_supply,
"stericsson,battery-type", NULL);- if (!btech) {
dev_warn(dev, "missing property battery-name/type\n");strcpy(bat_tech, "UNKNOWN");- } else {
strcpy(bat_tech, btech);- }
I don't get the point of declaring the char array and copying the string in it, when you could simply use just the pointer returned by of_get_property().
I am considering a corner case where in 'battery-type' property is not present and battery is connected.In this case i promote battery to UNKNOWN from null.
You could achieve the same result without using the char array, with this assignment:
btech = "UNKNOWN";
FYI: Further, btemp driver will identify the connected battery based on resistance value and decide to use. Ref: ab8500_btemp_id(...) ab8500_btemp.c
Anyway, if the string property is longer than 8 characters, you are writing past the size of the destination array.
i believe it is safe as power_supply.h comprises defines having battery technology type in 4 characters length which is normally the case and 7 chars length being "UNKNOWN" seldom referred
You should be able to handle whatever the device tree contains, and if it contains unexpected data this is not a good excuse for locking up the system.
-- Francesco