Re: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

On Wed, Sep 14, 2011 at 9:07 AM, Tushar Behera tushar.behera@linaro.org wrote: ...

Will this be better?

static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, \                                        unsigned int power) {        int ret;        unsigned long flag = power ? GPIOF_OUT_INIT_HIGH : \                                        GPIOF_OUT_INIT_LOW;

ret = gpio_request_one(EXYNOS4_GPE3(4), flag, "GPE3_4");

if (ret)                printk(KERN_ERR "Could not request gpio for LCD power"); }

Looks better. You can use pr_err instead of printk(KERN_ERR .

Regards,

Fabio Estevam