On 01 Apr 15 18:20, Vincent Guittot wrote:
On 1 April 2015 at 17:41, Lisa Nguyen lisa.nguyen@linaro.org wrote:
Gentle ping and friendly reminder that I need someone to ack Larry's cpu capacity script before I can merge it :)
I'm not sure that the beg of the output file which displays the steps to compute capacity is really necessary (min, max middle value). We are only interested in final result: cpu num: X capacity YYYY expected capacity ZZZZ cputopology_04.0: checking expected capacity for cpuX equal to computed capacity... Ok
Agreed, I'll submit a v3 with the extra printfs removed. I left them in so that if there were problems on platforms Lisa (or anyone else) tested for me, it would be easier for me to debug, and also so reviewers could see the intermediate calculations if they wanted to.
Apart from that it's ok for me
Thanks.
Larry