Re: [Powertop] [PATCH v2] conditionally disable pci if not supported

On 25 June 2012 21:34, Arjan van de Ven arjan@linux.intel.com wrote:

On 6/25/2012 9:00 AM, Rajagopal Venkat wrote:

<no commit message .. why? one sentence is cheap>

Ok. Taken care.

...

diff --git a/src/lib.h b/src/lib.h index 588c023..d354151 100644 --- a/src/lib.h +++ b/src/lib.h @@ -30,6 +30,10 @@ #endif #include <stdint.h>

+#if HAVE_CONFIG_H +#include "config.h" +#endif

#ifndef DISABLE_I18N #define _(STRING) gettext(STRING) #else

ok this chunk I do not understand; the rest of your patch looks very reasonable. why is config.h inside an if ?

config.h is auto generated by autoconf and is not applicable for Android build. Yes. it should be wrapped in ifdef.