Hi Daniel,
Thanks for this set. These changes look good in general. Please see comments below.
On 11 Jun 08, Daniel Lezcano wrote:
This patchset introduce a tree structure to store information found in the different directories we are looking for the power management.
The code clock has been replaced by a new code based on this tree.
The result is a code modular and generic enough to be used for the other power management blocks and to add more blocks like the gpio and the thermal framework.
The patch 'rewrite the powerdebug clock code' has been folded in a single one because it was too hard to review the patchset itself.
The display code has been reworked to be generic too but it is still focused on the clock display for the moment.
The following bugs were fixed too:
- https://bugs.launchpad.net/linaro-pm-wg/+bug/794725
- https://bugs.launchpad.net/linaro-pm-wg/+bug/794726
- https://bugs.launchpad.net/linaro-pm-wg/+bug/794728
- https://bugs.launchpad.net/linaro-pm-wg/+bug/794731
The drawback is the find clock interface is broken so it is disabled for the moment. It will be enabled again with the next patchset coming next week.
Daniel Lezcano (23): move clock_info structure definition reorganize code to prevent forward declaration provide a clock allocator remove unused variable fix segfault when the default window is not the clock
This patch doesn't apply. I also find that in your personal tree[1], there are the following additional patches before this series. Should these be part of the series as well?
2ef06e969eb9674b55d1b9704587505ed0e8198e compute next and previous window with modulo arithmetic 3b42b5e49b687837d4ffeabdd6fae207202afb1c make the keyscan code human readable df51b2fe4486032edca1e8f64e4ab61c668e8691 fix display when the default display is not the clock 4b6690736b5d6efe367299df67d2e9b1741e78cf nit : fix output hexadecimal format 00af33efcffc0a52a902d0e181343532f350129d Remove pointless compiler flags
[1] git://git.linaro.org/people/dlezcano/powerdebug.git
refresh the windows instead of killing them and recreate tree structure abstraction for directory hierarchies function helper to read the files use the tree code to dump the clocks Remove old clock tree dump code add 'find' function for the tree use 'find' tree function remove unused parameter remove unused parameter 'options->dump' remove unused code and parameter for clock dump function remove unused 'verbose' option add a function to browse at reverse order the tree make the mainloop immune against the signals add a tree function to return a list of elements compute the number of children for a specific node document the tree code rewrite the powerdebug clock code remove unused 'hrow' and 'selected' parameters
Makefile | 2 +- clocks.c | 639 ++++++++++++++++++++++++---------------------------------- clocks.h | 13 -- display.c | 229 +++++++++++++++------- powerdebug.c | 90 +++++---- powerdebug.h | 26 ++- tree.c | 353 ++++++++++++++++++++++++++++++++ tree.h | 54 +++++ 8 files changed, 890 insertions(+), 516 deletions(-) create mode 100644 tree.c create mode 100644 tree.h