-----Original Message----- From: Arnd Bergmann [mailto:arnd@arndb.de] Sent: Wednesday, June 29, 2011 5:57 PM To: Ashish Jangam Cc: Mark Brown; sameo@openedhand.com; linux-kernel@vger.kernel.org; Dajun; linaro-dev@lists.linaro.org Subject: Re: [PATCH 1/11] MFD: DA9052 MFD core module v1
On Tuesday 28 June 2011, ashishj3 wrote:
The DA9052 is a highly integrated PMIC subsystem with supply domain
flexibility
to support wide range of high performance application.
It provides voltage regulators, GPIO controller, Touch Screen, RTC, Battery control and other functionality.
Signed-off-by: David Dajun Chen dchen@diasemi.com Signed-off-by: Ashish Jangam ashish.jangam@kpitcummins.com
Hi Ashish and Dajun,
As we discussed last time, I think it would be important to lay out the drivers in a way that also works with the da9053 chip that has recently been submitted in another thread.
This does not mean that you have to support both from the start, but I would expect you to look at the differences and for each file decide whether they are completely different (e.g. one of them has backlight, the other one doesn't) or similar enough to be handled by one driver with a few conditional functions. My guess is that the da9052-core.c file would be different for each chip, while both the front-end (spi, i2c) and the back-end drivers (hwmon, backlight, regulator, ...) can be shared.
Please rename the files and the identifiers accordingly, and document in the changelog which hardware they can eventually support. I would expect a lot of the identfiers to become da905x or even da90xx.
DA9053 chip submission was done by Linaro and now they have agreed that we will be only responsible for DA9053 submission too so now we can skip the posted DA9053 patch.
Regarding file naming convention da9052 seems to be appropriate since DA9053 chip is update of DA9052 and also DA9052 is the umbrella name for the whole family.
Ashish