Hi,
Here small set of patches which fix:
- Build time dependencies. Application actually depend on json-c - Add __aarch64__ sched_setget|set_attr syscall numbers. - Fixed "suspend" event definition in example files. JSON expect object of type string after event definition.
Hopefully I get it right. If you have any questions or/and comments, please let me know.
Regards, Ivan
Ivan T. Ivanov (3): fixup json-c dependencies add get/setattr for __aarch64__ fix suspend event definitions
configure.ac | 12 ++++++------ doc/examples/browser.json | 8 ++++---- doc/examples/example4.json | 4 ++-- doc/examples/mp3.json | 8 ++++---- doc/examples/test.json | 4 ++-- libdl/dl_syscalls.h | 5 +++++ src/rt-app_parse_config.h | 2 +- 7 files changed, 24 insertions(+), 19 deletions(-)
--- configure.ac | 12 ++++++------ src/rt-app_parse_config.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac index afaedd9..50d6f76 100644 --- a/configure.ac +++ b/configure.ac @@ -24,13 +24,13 @@ AS_IF([test "x$with_deadline" != xno], ])
LIBJSON= - AC_CHECK_LIB([json], [json_object_from_file], - [AC_SUBST([LIBJSON], ["-ljson"]) - AC_DEFINE([JSON], [1], [Define if you have libjson]) + AC_CHECK_LIB([json-c], [json_object_from_file], + [AC_SUBST([LIBJSON], ["-ljson-c"]) + AC_DEFINE([JSON], [1], [Define if you have libjson-c]) ], - [AC_MSG_FAILURE([libjson test failed (use --without-json to disable or install json-c)])], - [-ljson] - ) + [AC_MSG_FAILURE([libjson-c test failed (use --without-json-c to disable or install json-c)])], + [-ljson-c] + )
AM_CONDITIONAL([AMJSON], [ test x$with_json != xno])
diff --git a/src/rt-app_parse_config.h b/src/rt-app_parse_config.h index 3a175ee..023cabd 100644 --- a/src/rt-app_parse_config.h +++ b/src/rt-app_parse_config.h @@ -37,7 +37,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. #ifdef DLSCHED #include "dl_syscalls.h" #endif -#include <json/json.h> +#include <json-c/json.h>
#define DEFAULT_THREAD_PRIORITY 10 #define DEFAULT_THREAD_NICE 0
--- libdl/dl_syscalls.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/libdl/dl_syscalls.h b/libdl/dl_syscalls.h index 8d70056..85dc1e9 100644 --- a/libdl/dl_syscalls.h +++ b/libdl/dl_syscalls.h @@ -39,6 +39,11 @@ #define __NR_sched_getattr 381 #endif
+#ifdef __aarch64__ +#define __NR_sched_setattr 380 +#define __NR_sched_getattr 381 +#endif + #define SF_SIG_RORUN 2 #define SF_SIG_DMISS 4 #define SF_BWRECL_DL 8
--- doc/examples/browser.json | 8 ++++---- doc/examples/example4.json | 4 ++-- doc/examples/mp3.json | 8 ++++---- doc/examples/test.json | 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/doc/examples/browser.json b/doc/examples/browser.json index a5b4dee..533c738 100644 --- a/doc/examples/browser.json +++ b/doc/examples/browser.json @@ -90,7 +90,7 @@ "Binder-display" : { "priority" : -6, "loop" : -1, - "suspend", + "suspend" : "Binder-display", "run" : 300, "resume" : "Event-Browser", "resume" : "Event-Display", @@ -98,7 +98,7 @@ "Event-Browser" : { "priority" : -9, "loop" : -1, - "suspend", + "suspend" : "Event-Browser", "run" : 50, "sleep" : 16000, "run" : 50, @@ -107,7 +107,7 @@ "Event-Display" : { "priority" : -9, "loop" : -1, - "suspend", + "suspend" : "Event-Display", "run" : 50, "sleep" : 16000, "run" : 50, @@ -116,7 +116,7 @@ "Display" : { "priority" : -8, "loop" : -1, - "suspend", + "suspend" : "Display", "run" : 16000, }, }, diff --git a/doc/examples/example4.json b/doc/examples/example4.json index 2865075..28d7c3d 100644 --- a/doc/examples/example4.json +++ b/doc/examples/example4.json @@ -8,13 +8,13 @@ "loop" : -1, "run" : 10000, "resume" : "thread1", - "suspend", + "suspend" : "thread0", }, "thread1" : { "loop" : -1, "run" : 10000, "resume" : "thread0", - "suspend", + "suspend" : "thread1", }, }, } diff --git a/doc/examples/mp3.json b/doc/examples/mp3.json index c1b40f0..0cf0513 100644 --- a/doc/examples/mp3.json +++ b/doc/examples/mp3.json @@ -1,6 +1,6 @@ { "tasks" : { - "AudioTick" : { + "AudioTick" : { "priority" : -19, "loop" : -1, "phases" : { @@ -21,19 +21,19 @@ "run" : 275, "resume" : "AudioTrack", "run" : 4725, - "suspend", + "suspend" : "AudioOut", }, "AudioTrack" : { "priority" : -16, "loop" : -1, - "suspend", + "suspend" : "AudioTrack", "run" : 300, "resume" : "mp3.decoder", }, "mp3.decoder" : { "priority" : -2, "loop" : -1, - "suspend", + "suspend" : "mp3.decoder", "run" : 1000, "lock" : "mutex", "signal" : "queue", diff --git a/doc/examples/test.json b/doc/examples/test.json index 11adcb0..169cfff 100644 --- a/doc/examples/test.json +++ b/doc/examples/test.json @@ -30,9 +30,9 @@ "wait": { "ref": "queue", "mutex": "mutex" }, "unlock": "mutex", "run": 10000, - "suspend", + "suspend" : "thread1", "run": 10000, - "suspend", + "suspend" : "thread1", "run": 10000, }, },
Hi,
On Fri, 2014-10-24 at 17:45 +0300, Ivan T. Ivanov wrote:
Hi,
Here small set of patches which fix:
- Build time dependencies. Application actually depend on json-c
- Add __aarch64__ sched_setget|set_attr syscall numbers.
- Fixed "suspend" event definition in example files. JSON expect object of type string after event definition.
Hopefully I get it right. If you have any questions or/and comments, please let me know.
Any comments or remarks?
Regards, Ivan
Hi Ivan,
Our main developer was on holidays this week. We'll review these next week.
Thanks for the patches.
Regards, Amit
On Fri, Oct 31, 2014 at 7:50 PM, Ivan T. Ivanov iivanov@mm-sol.com wrote:
Hi,
On Fri, 2014-10-24 at 17:45 +0300, Ivan T. Ivanov wrote:
Hi,
Here small set of patches which fix:
- Build time dependencies. Application actually depend on json-c
- Add __aarch64__ sched_setget|set_attr syscall numbers.
- Fixed "suspend" event definition in example files. JSON expect object of type string after event definition.
Hopefully I get it right. If you have any questions or/and comments, please let me know.
Any comments or remarks?
Regards, Ivan
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
On 24 October 2014 16:45, Ivan T. Ivanov iivanov@mm-sol.com wrote:
libdl/dl_syscalls.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/libdl/dl_syscalls.h b/libdl/dl_syscalls.h index 8d70056..85dc1e9 100644 --- a/libdl/dl_syscalls.h +++ b/libdl/dl_syscalls.h @@ -39,6 +39,11 @@ #define __NR_sched_getattr 381 #endif
+#ifdef __aarch64__ +#define __NR_sched_setattr 380 +#define __NR_sched_getattr 381 +#endif
Hi Ivan,
we have same values for __arm__, can't we merge both declaration on one ?
Vincent
#define SF_SIG_RORUN 2 #define SF_SIG_DMISS 4
#define SF_BWRECL_DL 8
1.9.1
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
On 24 October 2014 16:45, Ivan T. Ivanov iivanov@mm-sol.com wrote:
configure.ac | 12 ++++++------ src/rt-app_parse_config.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac index afaedd9..50d6f76 100644 --- a/configure.ac +++ b/configure.ac @@ -24,13 +24,13 @@ AS_IF([test "x$with_deadline" != xno], ])
LIBJSON=
AC_CHECK_LIB([json], [json_object_from_file],[AC_SUBST([LIBJSON], ["-ljson"])AC_DEFINE([JSON], [1], [Define if you have libjson])
AC_CHECK_LIB([json-c], [json_object_from_file],[AC_SUBST([LIBJSON], ["-ljson-c"])AC_DEFINE([JSON], [1], [Define if you have libjson-c]) ],
[AC_MSG_FAILURE([libjson test failed (use --without-json to disable or install json-c)])],[-ljson])
[AC_MSG_FAILURE([libjson-c test failed (use --without-json-c to disable or install json-c)])],[-ljson-c])
Could you explain why you want to change from libjson0 to libjson-c ?
Vincent
AM_CONDITIONAL([AMJSON], [ test x$with_json != xno])
diff --git a/src/rt-app_parse_config.h b/src/rt-app_parse_config.h index 3a175ee..023cabd 100644 --- a/src/rt-app_parse_config.h +++ b/src/rt-app_parse_config.h @@ -37,7 +37,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. #ifdef DLSCHED #include "dl_syscalls.h" #endif -#include <json/json.h> +#include <json-c/json.h>
#define DEFAULT_THREAD_PRIORITY 10
#define DEFAULT_THREAD_NICE 0
1.9.1
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
On Monday 03 November 2014 12:06:06 Vincent Guittot wrote:
On 24 October 2014 16:45, Ivan T. Ivanov iivanov@mm-sol.com wrote:
libdl/dl_syscalls.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/libdl/dl_syscalls.h b/libdl/dl_syscalls.h index 8d70056..85dc1e9 100644 --- a/libdl/dl_syscalls.h +++ b/libdl/dl_syscalls.h @@ -39,6 +39,11 @@ #define __NR_sched_getattr 381 #endif
+#ifdef __aarch64__ +#define __NR_sched_setattr 380 +#define __NR_sched_getattr 381 +#endif
Hi Ivan,
we have same values for __arm__, can't we merge both declaration on one ?
arm64 uses 274 and 275 instead of 380 and 381.
Why can't libdl just include asm/unistd.h to get the numbers for the architecture it's compiling for?
Arnd
On 3 November 2014 12:32, Arnd Bergmann arnd@arndb.de wrote:
On Monday 03 November 2014 12:06:06 Vincent Guittot wrote:
On 24 October 2014 16:45, Ivan T. Ivanov iivanov@mm-sol.com wrote:
libdl/dl_syscalls.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/libdl/dl_syscalls.h b/libdl/dl_syscalls.h index 8d70056..85dc1e9 100644 --- a/libdl/dl_syscalls.h +++ b/libdl/dl_syscalls.h @@ -39,6 +39,11 @@ #define __NR_sched_getattr 381 #endif
+#ifdef __aarch64__ +#define __NR_sched_setattr 380 +#define __NR_sched_getattr 381 +#endif
Hi Ivan,
we have same values for __arm__, can't we merge both declaration on one ?
arm64 uses 274 and 275 instead of 380 and 381.
Why can't libdl just include asm/unistd.h to get the numbers for the architecture it's compiling for?
you're right, it should. IIRC, this header file has been created because the syscall was not yet defined and available when the tool has been created
Vincent
Arnd
On Mon, 2014-11-03 at 12:09 +0100, Vincent Guittot wrote:
On 24 October 2014 16:45, Ivan T. Ivanov iivanov@mm-sol.com wrote:
configure.ac | 12 ++++++------ src/rt-app_parse_config.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac index afaedd9..50d6f76 100644 --- a/configure.ac +++ b/configure.ac @@ -24,13 +24,13 @@ AS_IF([test "x$with_deadline" != xno], ])
LIBJSON=
AC_CHECK_LIB([json], [json_object_from_file],[AC_SUBST([LIBJSON], ["-ljson"])AC_DEFINE([JSON], [1], [Define if you have libjson])
AC_CHECK_LIB([json-c], [json_object_from_file],[AC_SUBST([LIBJSON], ["-ljson-c"])AC_DEFINE([JSON], [1], [Define if you have libjson-c]) ],
[AC_MSG_FAILURE([libjson test failed (use --without-json to disableor install json-c)])],
[-ljson])
[AC_MSG_FAILURE([libjson-c test failed (use --without-json-c todisable or install json-c)])],
[-ljson-c])Could you explain why you want to change from libjson0 to libjson-c ?
Isn't json-c library which was actually used? json-c was the library against which I was able to compile this in buildroot environment.
JSON library probably should not be optional, right?
Regards, Ivan
Hi Ivan,
I have intentionally not put the string of "suspend" key in the example because the workgen script will do the check and others (like unique key id) before calling rt-app. Adding a detailed documentation of how to use rt-app and workgen is my top priority action of my todo list
Regards, Vincent
On 24 October 2014 16:45, Ivan T. Ivanov iivanov@mm-sol.com wrote:
doc/examples/browser.json | 8 ++++---- doc/examples/example4.json | 4 ++-- doc/examples/mp3.json | 8 ++++---- doc/examples/test.json | 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/doc/examples/browser.json b/doc/examples/browser.json index a5b4dee..533c738 100644 --- a/doc/examples/browser.json +++ b/doc/examples/browser.json @@ -90,7 +90,7 @@ "Binder-display" : { "priority" : -6, "loop" : -1,
"suspend",
"suspend" : "Binder-display", "run" : 300, "resume" : "Event-Browser", "resume" : "Event-Display",@@ -98,7 +98,7 @@ "Event-Browser" : { "priority" : -9, "loop" : -1,
"suspend",
"suspend" : "Event-Browser", "run" : 50, "sleep" : 16000, "run" : 50,@@ -107,7 +107,7 @@ "Event-Display" : { "priority" : -9, "loop" : -1,
"suspend",
"suspend" : "Event-Display", "run" : 50, "sleep" : 16000, "run" : 50,@@ -116,7 +116,7 @@ "Display" : { "priority" : -8, "loop" : -1,
"suspend",
"suspend" : "Display", "run" : 16000, }, },diff --git a/doc/examples/example4.json b/doc/examples/example4.json index 2865075..28d7c3d 100644 --- a/doc/examples/example4.json +++ b/doc/examples/example4.json @@ -8,13 +8,13 @@ "loop" : -1, "run" : 10000, "resume" : "thread1",
"suspend",
"suspend" : "thread0", }, "thread1" : { "loop" : -1, "run" : 10000, "resume" : "thread0",
"suspend",
"suspend" : "thread1", }, },} diff --git a/doc/examples/mp3.json b/doc/examples/mp3.json index c1b40f0..0cf0513 100644 --- a/doc/examples/mp3.json +++ b/doc/examples/mp3.json @@ -1,6 +1,6 @@ { "tasks" : {
"AudioTick" : {
"AudioTick" : { "priority" : -19, "loop" : -1, "phases" : {@@ -21,19 +21,19 @@ "run" : 275, "resume" : "AudioTrack", "run" : 4725,
"suspend",
"suspend" : "AudioOut", }, "AudioTrack" : { "priority" : -16, "loop" : -1,
"suspend",
"suspend" : "AudioTrack", "run" : 300, "resume" : "mp3.decoder", }, "mp3.decoder" : { "priority" : -2, "loop" : -1,
"suspend",
"suspend" : "mp3.decoder", "run" : 1000, "lock" : "mutex", "signal" : "queue",diff --git a/doc/examples/test.json b/doc/examples/test.json index 11adcb0..169cfff 100644 --- a/doc/examples/test.json +++ b/doc/examples/test.json @@ -30,9 +30,9 @@ "wait": { "ref": "queue", "mutex": "mutex" }, "unlock": "mutex", "run": 10000,
"suspend",
"suspend" : "thread1", "run": 10000,
"suspend",
"suspend" : "thread1", "run": 10000, }, },-- 1.9.1
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
On 3 November 2014 13:30, Ivan T. Ivanov iivanov@mm-sol.com wrote:
On Mon, 2014-11-03 at 12:09 +0100, Vincent Guittot wrote:
On 24 October 2014 16:45, Ivan T. Ivanov iivanov@mm-sol.com wrote:
configure.ac | 12 ++++++------ src/rt-app_parse_config.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac index afaedd9..50d6f76 100644 --- a/configure.ac +++ b/configure.ac @@ -24,13 +24,13 @@ AS_IF([test "x$with_deadline" != xno], ])
LIBJSON=
AC_CHECK_LIB([json], [json_object_from_file],[AC_SUBST([LIBJSON], ["-ljson"])AC_DEFINE([JSON], [1], [Define if you have libjson])
AC_CHECK_LIB([json-c], [json_object_from_file],[AC_SUBST([LIBJSON], ["-ljson-c"])AC_DEFINE([JSON], [1], [Define if you have libjson-c]) ],
[AC_MSG_FAILURE([libjson test failed (use --without-json to disableor install json-c)])],
[-ljson])
[AC_MSG_FAILURE([libjson-c test failed (use --without-json-c todisable or install json-c)])],
[-ljson-c])Could you explain why you want to change from libjson0 to libjson-c ?
Isn't json-c library which was actually used? json-c was the library against which I was able to compile this in buildroot environment.
Personally, i use libjson0 but I haven't tried buildroot. Do you mean that you haven't been able to use libjson0 with buildroot or just that you have only tried libjson-c ?
JSON library probably should not be optional, right?
yes
Regards, Ivan
Hi,
On Mon, 2014-11-03 at 13:08 +0100, Vincent Guittot wrote:
On 3 November 2014 12:32, Arnd Bergmann arnd@arndb.de wrote:
On Monday 03 November 2014 12:06:06 Vincent Guittot wrote:
On 24 October 2014 16:45, Ivan T. Ivanov iivanov@mm-sol.com wrote:
libdl/dl_syscalls.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/libdl/dl_syscalls.h b/libdl/dl_syscalls.h index 8d70056..85dc1e9 100644 --- a/libdl/dl_syscalls.h +++ b/libdl/dl_syscalls.h @@ -39,6 +39,11 @@ #define __NR_sched_getattr 381 #endif
+#ifdef __aarch64__ +#define __NR_sched_setattr 380 +#define __NR_sched_getattr 381 +#endif
Hi Ivan,
we have same values for __arm__, can't we merge both declaration on one ?
arm64 uses 274 and 275 instead of 380 and 381.
Probably I have been mistaken by arch/arm64/include/asm/unistd32.h which uses same numbers like arm.
Why can't libdl just include asm/unistd.h to get the numbers for the architecture it's compiling for?
you're right, it should.
Just for my clarification. We are talking about headers installed by linux kernel or provided by compiler tool chain? I am unable to find above syscall numbers in gcc-linaro-arm-linux-gnueabihf-4.9-2014.09, for example.
Regards, Ivan
IIRC, this header file has been created because the syscall was not yet defined and available when the tool has been created
Vincent
Arnd
On Mon, 2014-11-03 at 13:42 +0100, Vincent Guittot wrote:
On 3 November 2014 13:30, Ivan T. Ivanov iivanov@mm-sol.com wrote:
On Mon, 2014-11-03 at 12:09 +0100, Vincent Guittot wrote:
On 24 October 2014 16:45, Ivan T. Ivanov iivanov@mm-sol.com wrote:
configure.ac | 12 ++++++------ src/rt-app_parse_config.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac index afaedd9..50d6f76 100644 --- a/configure.ac +++ b/configure.ac @@ -24,13 +24,13 @@ AS_IF([test "x$with_deadline" != xno], ])
LIBJSON=
AC_CHECK_LIB([json], [json_object_from_file],[AC_SUBST([LIBJSON], ["-ljson"])AC_DEFINE([JSON], [1], [Define if you have libjson])
AC_CHECK_LIB([json-c], [json_object_from_file],[AC_SUBST([LIBJSON], ["-ljson-c"])AC_DEFINE([JSON], [1], [Define if you have libjson-c]) ],
[AC_MSG_FAILURE([libjson test failed (use --without-json todisable or install json-c)])],
[-ljson])
[AC_MSG_FAILURE([libjson-c test failed (use --without-json-c todisable or install json-c)])],
[-ljson-c])Could you explain why you want to change from libjson0 to libjson-c ?
Isn't json-c library which was actually used? json-c was the library against which I was able to compile this in buildroot environment.
Personally, i use libjson0 but I haven't tried buildroot. Do you mean that you haven't been able to use libjson0 with buildroot or just that you have only tried libjson-c ?
If I am not mistaken buildroot have 2 options for JSON providers libjson [1] and json-c [2]. API used by rt-app is provided by json-c. Library installed from json-c is libjson-c.so. libjson0 looks like Debian/Ubuntu modification.
Regards, Ivan
[1] http://sourceforge.net/projects/libjson/ [2] http://oss.metaparadigm.com/json-c/
Hi,
On Mon, 2014-11-03 at 13:37 +0100, Vincent Guittot wrote:
Hi Ivan,
I have intentionally not put the string of "suspend" key in the example because the workgen script will do the check
So is it supposed to emit error, or what?
and others (like unique key id) before calling rt-app. Adding a detailed documentation of how to use rt-app and workgen is my top priority action of my todo list
Ok. probably I have not understood purpose of the workgen script. Is is supposed to be executed on the target machine? This will be really to bad, it will be pain to compile/install python on my little target :-)
Regards, Ivan
On Monday 03 November 2014 14:48:56 Ivan T. Ivanov wrote:
On Mon, 2014-11-03 at 13:08 +0100, Vincent Guittot wrote:
On 3 November 2014 12:32, Arnd Bergmann arnd@arndb.de wrote:
On Monday 03 November 2014 12:06:06 Vincent Guittot wrote:
On 24 October 2014 16:45, Ivan T. Ivanov iivanov@mm-sol.com wrote:
libdl/dl_syscalls.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/libdl/dl_syscalls.h b/libdl/dl_syscalls.h index 8d70056..85dc1e9 100644 --- a/libdl/dl_syscalls.h +++ b/libdl/dl_syscalls.h @@ -39,6 +39,11 @@ #define __NR_sched_getattr 381 #endif
+#ifdef __aarch64__ +#define __NR_sched_setattr 380 +#define __NR_sched_getattr 381 +#endif
Hi Ivan,
we have same values for __arm__, can't we merge both declaration on one ?
arm64 uses 274 and 275 instead of 380 and 381.
Probably I have been mistaken by arch/arm64/include/asm/unistd32.h which uses same numbers like arm.
Yes, this defines the numbers that arm64 emulates when running arm32 binaries.
Why can't libdl just include asm/unistd.h to get the numbers for the architecture it's compiling for?
you're right, it should.
Just for my clarification. We are talking about headers installed by linux kernel or provided by compiler tool chain? I am unable to find above syscall numbers in gcc-linaro-arm-linux-gnueabihf-4.9-2014.09, for example.
On my system, this header is provided by the linux-libc-dev-arm64-cross package and installed to /usr/aarch64-linux-gnu/include/asm/unistd.h.
This package contains the headers from the kernel that are required for building a toolchain.
Arnd
On 3 November 2014 14:13, Ivan T. Ivanov iivanov@mm-sol.com wrote:
Hi,
On Mon, 2014-11-03 at 13:37 +0100, Vincent Guittot wrote:
Hi Ivan,
I have intentionally not put the string of "suspend" key in the example because the workgen script will do the check
So is it supposed to emit error, or what?
It will not emit an error with workgen but the script will add the missing name to the "suspend" key if no present. So both formats are accepted if you use workgen whereas the thread name is mandatory if you directly call rt-app The goal is to keep the example files simple. In the case of "suspend", the primary goal is to suspend the thread that contains the "suspend" so we can easily add it at runtime with a script.
and others (like unique key id) before calling rt-app. Adding a detailed documentation of how to use rt-app and workgen is my top priority action of my todo list
Ok. probably I have not understood purpose of the workgen script. Is is supposed to be executed on the target machine? This will be really to bad, it will be pain to compile/install python on my little target :-)
Yes the goal is to use workgen on the target. I also admit that some people (like you) don't want to install a lot of things on their little target. I can add the name in the examples file so it can be use directly with rt-app
But you will have another potential issue: having a unique key id at each json object level. workgen also takes care of that and i'm not sure that all the example comply with this constraint.
Nevertheless, we can add an option into workgen to only check use case file and output a corrected file instead of calling rt-app. So, you use workgen on your host to check/update the use case files and call rt-app with the checked file on the target
Vincent
Regards, Ivan
On Mon, 2014-11-03 at 14:46 +0100, Vincent Guittot wrote:
On 3 November 2014 14:13, Ivan T. Ivanov iivanov@mm-sol.com wrote:
<snip>
Ok. probably I have not understood purpose of the workgen script. Is is supposed to be executed on the target machine? This will be really to bad, it will be pain to compile/install python on my little target :-)
Yes the goal is to use workgen on the target. I also admit that some people (like you) don't want to install a lot of things on their little target. I can add the name in the examples file so it can be use directly with rt-app
But you will have another potential issue: having a unique key id at each json object level. workgen also takes care of that and i'm not sure that all the example comply with this constraint.
I have tried to add this to rt-app itself, but the patch was too intrusive :-).
Nevertheless, we can add an option into workgen to only check use case file and output a corrected file instead of calling rt-app. So, you use workgen on your host to check/update the use case files and call rt-app with the checked file on the target
Thanks, this will be nice.
Regards, Ivan
-
Amit Kucheria -
Arnd Bergmann -
Ivan T. Ivanov -
Vincent Guittot