On Wed, Oct 1, 2014 at 11:12 AM, Howard Chen howard.chen@linaro.org wrote:

From: Howard Chen howard.chen@lianro.org

Please review section 12 of https://www.kernel.org/doc/Documentation/SubmittingPatches on how to sign your work. Sections 13 and 14 might be useful to look at, too. Try to avoid adding Signed-off-by manually (note the typo in email address above!). Easiest way to get Signed-off-by yourself is to use the -s option when running git commit, assuming you have configured your email and name properly into git.

Please include at least a brief description of what you are fixing, right now I would have to go and find the bug entry to find out what is wrong in the first place. As there is no information on what your are fixing and how you are trying to fix it, I have no idea if the code matches or not, thus I cannot review this.

Tuukka

---

idlestat.c | 6 ++++++ topology.c | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/idlestat.c b/idlestat.c index da615cb..e609e86 100644 --- a/idlestat.c +++ b/idlestat.c @@ -242,6 +242,10 @@ static int display_pstates(void *arg, char *cpu) bool cpu_header = false; struct cpufreq_pstates *pstates = arg;

•   if(!strstr(cpu, "cpu")){
  

•           display_cpu_header(cpu, 64);
  

•           return 0;
  

•   }
    for (i = 0; i < pstates->max; i++) {
  
            struct cpufreq_pstate *p = &(pstates->pstate[i]);
  

@@ -299,6 +303,8 @@ static int display_wakeup(void *arg, char *cpu) struct wakeup_info *wakeinfo = &cstates->wakeinfo; struct wakeup_irq *irqinfo = wakeinfo->irqinfo;

•   if(!strstr(cpu, "cpu"))
  

•           display_cpu_header(cpu, 44);
    for (i = 0; i < wakeinfo->nrdata; i++, irqinfo++) {
  
            if (!cpu_header) {
  

diff --git a/topology.c b/topology.c index 92521e1..47c6983 100644 --- a/topology.c +++ b/topology.c @@ -458,8 +458,7 @@ int dump_cpu_topo_info(int (*dump)(void *, char *), int cstate)

            sprintf(tmp, "cluster%c", s_phy->physical_id + 'A');

•           if (cstate)
  

•                   dump(s_phy->cstates, tmp);
  

•           dump(s_phy->cstates, tmp);
  
            list_for_each_entry(s_core, &s_phy->core_head, list_core) {
                    if (s_core->is_ht && cstate) {
  

-- 1.9.1

---

linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev