(CC'd "inaro-dev" as opposed to "linaro-dev" as I guess that was a previous typo)
On 14 May 2012 14:41, Deao, Douglas d-deao@ti.com wrote:
Andy,
The commit to my clone was right after "config tilt stm and omap driver" on tracking-topic-stm. I used "git format-patch -1" to generate the patch.
I sent my patch before Ryan's showed up on the landing team site.
My patches are only a new "driver" (stm_arm.c) and the Kconfig/makefile changes needed.
This new driver doesn't do anything yet, BTW, it's just a load of debug code. But it shouldn't effect your patch merging over the top of your existing stm_fw.c as I haven't touched that file.
The Framework driver is not using /sys in any way, just /debugfs, so anything with /sys was added by Ryan.
Not guilty :-) I think Andy was simply referring to the /debugfs stuff, but called it /sys.
The Framework driver has always had a debugfs fops API. The first release supported only character based messages, but the new patch supports binary transfers using the same fops API. Trying to keep it easy to use for both cases.
Regards, Doug
-----Original Message----- From: Andy Green [mailto:andy.green@linaro.org] Sent: Sunday, May 13, 2012 10:29 PM To: Deao, Douglas Cc: inaro-dev@lists.linaro.org; Ryan Harkin; Arnd Bergmann Subject: Re: FW: STM Drviers update patch
On 11/05/12 01:29, Somebody in the thread at some point said:
(looping Ryan and Arnd)
This time without the copy/paste error.
-----Original Message----- From: Deao, Douglas Sent: Thursday, May 10, 2012 12:26 PM To: 'Andy Green' Cc: 'mailto:patches@linaro.org'; 'mailto:linaro-dev@lists.linaro.org' Subject: STM Drviers update patch
Andy,
Just found the Linaro "Process/UpstreamPatches" page.
Anything else that's not obvious to a newbie I need to be aware of?
Hi Doug -
I'm not sure I'm the integration point for these patches or it should be Ryan... he has sent some refactor patches for omap support recently for OMAP5 testing.
Either way patches@linaro.org only cares about patches when they're sent upstream, and we're not there yet.
I wasn't able to get this patch to apply to tracking-topic-stm with or without Ryan's changes... is it intended to replace what's there? That's fine if so, otherwise what should it apply to? Is it aware of Ryan's changes?
http://git.linaro.org/gitweb?p=landing- teams/working/ti/kernel.git;a=shortlog;h=refs/heads/tracking-topic-stm
Something I noticed when testing for Ryan was there's a kind of shell command type interface via /sys nodes, with commandlines like
echo "rm xyz" > /sys/blah
In the past, I believe there has been some resistance to this kind of thing upstream, with a hardline one-token-one-sys-node approach demanded. In other /sys based subsystems, they seem to use the idea of elaborating the possible commands as /sys nodes themselves, so you would echo > /sys/.../rm to delete. Maybe Arnd can guide us if that's still a problem.
Also while we're bothering Arnd, IIRC at one point there was a char device, but I can't see it any more with a quick look through the framework code. Did you replace it? If so what's the way to transfer the bulk data now?
-Andy
-----Original Message----- From: Deao, Douglas Sent: Tuesday, May 08, 2012 4:40 PM To: Andy Green Cc: Loic Pallardy; scott.bambrough@linaro.org; Ryan Harkin; Lee
Jones; Philippe Langlais
Subject: STM Drviers update patch
Andy,
I have attached a patch for tracking-topic-stm that contains both my
latest updates and feedback/patches I merged from Loic Pallardy.
This patch includes:
- Binary data transport
- mmap support for mapping channels to user space
- PID change notification
- Added patched/feedback provided by Loic Pallardy for: echo support improvement API improvements
Let me know if there is any additional process for adding patches
beyond simply sending you the patch.
P.S Just noticed you have a change to stm_omap_ti1.0.c that I did not
manage to update. Let me know if applying the patch causes you any grief.
Thanks, Doug
-- Andy Green | TI Landing Team Leader Linaro.org │ Open source software for ARM SoCs | Follow Linaro http://facebook.com/pages/Linaro/155974581091106 - http://twitter.com/#%21/linaroorg - http://linaro.org/linaro-blog
Ryan,
No worries. I have not updated yet to pick up your patches, so I had no idea what Andy was referencing.
Regards, Doug
From: Ryan Harkin [mailto:ryan.harkin@linaro.org] Sent: Monday, May 14, 2012 8:58 AM To: Deao, Douglas Cc: Andy Green; linaro-dev@lists.linaro.org; Arnd Bergmann Subject: Re: FW: STM Drviers update patch
(CC'd "inaro-dev" as opposed to "linaro-dev" as I guess that was a previous typo)
On 14 May 2012 14:41, Deao, Douglas <d-deao@ti.commailto:d-deao@ti.com> wrote: Andy,
The commit to my clone was right after "config tilt stm and omap driver" on tracking-topic-stm. I used "git format-patch -1" to generate the patch.
I sent my patch before Ryan's showed up on the landing team site.
My patches are only a new "driver" (stm_arm.c) and the Kconfig/makefile changes needed.
This new driver doesn't do anything yet, BTW, it's just a load of debug code. But it shouldn't effect your patch merging over the top of your existing stm_fw.c as I haven't touched that file.
The Framework driver is not using /sys in any way, just /debugfs, so anything with /sys was added by Ryan.
Not guilty :-) I think Andy was simply referring to the /debugfs stuff, but called it /sys.
The Framework driver has always had a debugfs fops API. The first release supported only character based messages, but the new patch supports binary transfers using the same fops API. Trying to keep it easy to use for both cases.
Regards, Doug
-----Original Message----- From: Andy Green [mailto:andy.green@linaro.orgmailto:andy.green@linaro.org] Sent: Sunday, May 13, 2012 10:29 PM To: Deao, Douglas Cc: inaro-dev@lists.linaro.orgmailto:inaro-dev@lists.linaro.org; Ryan Harkin; Arnd Bergmann Subject: Re: FW: STM Drviers update patch
On 11/05/12 01:29, Somebody in the thread at some point said:
(looping Ryan and Arnd)
This time without the copy/paste error.
-----Original Message----- From: Deao, Douglas Sent: Thursday, May 10, 2012 12:26 PM To: 'Andy Green' Cc: 'mailto:patches@linaro.orgmailto:patches@linaro.org'; 'mailto:linaro-dev@lists.linaro.orgmailto:linaro-dev@lists.linaro.org' Subject: STM Drviers update patch
Andy,
Just found the Linaro "Process/UpstreamPatches" page.
Anything else that's not obvious to a newbie I need to be aware of?
Hi Doug -
I'm not sure I'm the integration point for these patches or it should be Ryan... he has sent some refactor patches for omap support recently for OMAP5 testing.
Either way patches@linaro.orgmailto:patches@linaro.org only cares about patches when they're sent upstream, and we're not there yet.
I wasn't able to get this patch to apply to tracking-topic-stm with or without Ryan's changes... is it intended to replace what's there? That's fine if so, otherwise what should it apply to? Is it aware of Ryan's changes?
http://git.linaro.org/gitweb?p=landing- teams/working/ti/kernel.git;a=shortlog;h=refs/heads/tracking-topic-stm
Something I noticed when testing for Ryan was there's a kind of shell command type interface via /sys nodes, with commandlines like
echo "rm xyz" > /sys/blah
In the past, I believe there has been some resistance to this kind of thing upstream, with a hardline one-token-one-sys-node approach demanded. In other /sys based subsystems, they seem to use the idea of elaborating the possible commands as /sys nodes themselves, so you would echo > /sys/.../rm to delete. Maybe Arnd can guide us if that's still a problem.
Also while we're bothering Arnd, IIRC at one point there was a char device, but I can't see it any more with a quick look through the framework code. Did you replace it? If so what's the way to transfer the bulk data now?
-Andy
-----Original Message----- From: Deao, Douglas Sent: Tuesday, May 08, 2012 4:40 PM To: Andy Green Cc: Loic Pallardy; scott.bambrough@linaro.orgmailto:scott.bambrough@linaro.org; Ryan Harkin; Lee
Jones; Philippe Langlais
Subject: STM Drviers update patch
Andy,
I have attached a patch for tracking-topic-stm that contains both my
latest updates and feedback/patches I merged from Loic Pallardy.
This patch includes:
- Binary data transport
- mmap support for mapping channels to user space
- PID change notification
- Added patched/feedback provided by Loic Pallardy for: echo support improvement API improvements
Let me know if there is any additional process for adding patches
beyond simply sending you the patch.
P.S Just noticed you have a change to stm_omap_ti1.0.c that I did not
manage to update. Let me know if applying the patch causes you any grief.
Thanks, Doug
-- Andy Green | TI Landing Team Leader Linaro.org │ Open source software for ARM SoCs | Follow Linaro http://facebook.com/pages/Linaro/155974581091106 - http://twitter.com/#%21/linaroorghttp://twitter.com/#%21/linaroorg - http://linaro.org/linaro-blog
-
Deao, Douglas -
Ryan Harkin