Hi John,
I have been struggling since some time "who creates source directory in my kernel tree"? And i thought to clean up the mess today and found running merge_config.sh creates it.. And it isn't cleaned up even by running make mrproper...
PS: I am not using O=../ option.
On 04/02/2013 11:26 PM, Viresh Kumar wrote:
Hi John,
I have been struggling since some time "who creates source directory in my kernel tree"? And i thought to clean up the mess today and found running merge_config.sh creates it.. And it isn't cleaned up even by running make mrproper...
PS: I am not using O=../ option.
I'm not sure I'm following this at all. Could you explain in more detail whats going on?
thanks -john
On 3 April 2013 21:41, John Stultz john.stultz@linaro.org wrote:
On 04/02/2013 11:26 PM, Viresh Kumar wrote:
Hi John,
I have been struggling since some time "who creates source directory in my kernel tree"? And i thought to clean up the mess today and found running merge_config.sh creates it.. And it isn't cleaned up even by running make mrproper...
PS: I am not using O=../ option.
I'm not sure I'm following this at all. Could you explain in more detail whats going on?
My bad...
So whenever i run merge_config.sh with or without O= option, a link called "source" is created in kernel directory, which points to the kernel directory. And git status complains about it every time as new directory.
eg:
lrwxrwxrwx 1 viresh arm 59 Apr 3 22:30 source -> /home/arm/work/kernel/linaro/linux-linaro-big-LITTLE-MP.git/
On 04/03/2013 10:01 AM, Viresh Kumar wrote:
On 3 April 2013 21:41, John Stultz john.stultz@linaro.org wrote:
On 04/02/2013 11:26 PM, Viresh Kumar wrote:
Hi John,
I have been struggling since some time "who creates source directory in my kernel tree"? And i thought to clean up the mess today and found running merge_config.sh creates it.. And it isn't cleaned up even by running make mrproper...
PS: I am not using O=../ option.
I'm not sure I'm following this at all. Could you explain in more detail whats going on?
My bad...
So whenever i run merge_config.sh with or without O= option, a link called "source" is created in kernel directory, which points to the kernel directory. And git status complains about it every time as new directory.
eg:
lrwxrwxrwx 1 viresh arm 59 Apr 3 22:30 source -> /home/arm/work/kernel/linaro/linux-linaro-big-LITTLE-MP.git/
Huh. I'm totally unfamiliar with this.
Looks like when adding support for the -O option, if its not used, we end up passing -O=. to make, which generates the unnecessary source softlink.
Does the attached patch fix it for you?
thanks -john
On 3 April 2013 22:53, John Stultz john.stultz@linaro.org wrote:
Huh. I'm totally unfamiliar with this.
Looks like when adding support for the -O option, if its not used, we end up passing -O=. to make, which generates the unnecessary source softlink.
Does the attached patch fix it for you?
Yes it does.. Thanks. And you will be pushing that upstream and linux-linaro too?
On 04/03/2013 09:27 PM, Viresh Kumar wrote:
On 3 April 2013 22:53, John Stultz john.stultz@linaro.org wrote:
Huh. I'm totally unfamiliar with this.
Looks like when adding support for the -O option, if its not used, we end up passing -O=. to make, which generates the unnecessary source softlink.
Does the attached patch fix it for you?
Yes it does.. Thanks. And you will be pushing that upstream and linux-linaro too?
Yea, I'll push it upstream and send it to Andrey for Linux Linaro. Thanks for the testing.
thanks -john
On 5 April 2013 00:18, John Stultz john.stultz@linaro.org wrote:
Yea, I'll push it upstream and send it to Andrey for Linux Linaro. Thanks for the testing.
There are more problems than this i believe...
Everytime i run merge_config.sh even with O=../ option, i have to run make mrproper to clean other stuff otherwise compilation doesn't succeed and complains to run make mrproper.
Make mrproper gave this:
viresh@blr-linut-001:$ make mrproper CLEAN scripts/basic CLEAN scripts/kconfig CLEAN include/config CLEAN .config
On 04/04/2013 06:34 PM, Viresh Kumar wrote:
On 5 April 2013 00:18, John Stultz john.stultz@linaro.org wrote:
Yea, I'll push it upstream and send it to Andrey for Linux Linaro. Thanks for the testing.
There are more problems than this i believe...
Everytime i run merge_config.sh even with O=../ option, i have to run
O=../ ?
make mrproper to clean other stuff otherwise compilation doesn't succeed and complains to run make mrproper.
Make mrproper gave this:
viresh@blr-linut-001:$ make mrproper CLEAN scripts/basic CLEAN scripts/kconfig CLEAN include/config CLEAN .config
Sorry, still not sure I understand the problem.
Could you send me the config fragments and commands you're using cause compilation problems?
thanks -john
On 5 April 2013 07:58, John Stultz john.stultz@linaro.org wrote:
On 04/04/2013 06:34 PM, Viresh Kumar wrote:
Everytime i run merge_config.sh even with O=../ option, i have to run
O=../ ?
Hmm.. when we compile kernel we can give O=../output-folder as an parameter and so image/binaries will be created in ../output-folder..
I believe the same is true for merge_config.sh also, isn't it?
make mrproper to clean other stuff otherwise compilation doesn't succeed and complains to run make mrproper.
Make mrproper gave this:
viresh@blr-linut-001:$ make mrproper CLEAN scripts/basic CLEAN scripts/kconfig CLEAN include/config CLEAN .config
Sorry, still not sure I understand the problem.
Could you send me the config fragments and commands you're using cause compilation problems?
Try this:
make mrproper ARCH=arm O=../btc2 scripts/kconfig/merge_config.sh linaro/configs/linaro-base.conf linaro/configs/vexpress.conf linaro/configs/ubuntu-minimal.conf make mrproper
You will still see some files being cleaned up by last make mrproper.
On 04/04/2013 07:53 PM, Viresh Kumar wrote:
On 5 April 2013 07:58, John Stultz john.stultz@linaro.org wrote:
On 04/04/2013 06:34 PM, Viresh Kumar wrote:
Everytime i run merge_config.sh even with O=../ option, i have to run
O=../ ?
Hmm.. when we compile kernel we can give O=../output-folder as an parameter and so image/binaries will be created in ../output-folder..
I believe the same is true for merge_config.sh also, isn't it?
make mrproper to clean other stuff otherwise compilation doesn't succeed and complains to run make mrproper.
Make mrproper gave this:
viresh@blr-linut-001:$ make mrproper CLEAN scripts/basic CLEAN scripts/kconfig CLEAN include/config CLEAN .config
Sorry, still not sure I understand the problem.
Could you send me the config fragments and commands you're using cause compilation problems?
Try this:
make mrproper ARCH=arm O=../btc2 scripts/kconfig/merge_config.sh linaro/configs/linaro-base.conf linaro/configs/vexpress.conf linaro/configs/ubuntu-minimal.conf make mrproper
You will still see some files being cleaned up by last make mrproper.
Try: $ make mrproper $ ARCH=arm ./scripts/kconfig/merge_config.sh -O ../btc2 linaro/configs/linaro-base.conf linaro/configs/vexpress.conf linaro/configs/ubuntu-minimal.conf $ make mrproper
I think the problem is the script takes a "-O <dir>" argument and doesn't use a "O=<dir>" environment prefix.
That said, I see the same behavior you describe with: $make mrproper $O=../tmp/ make defconfig $make mrproper
Where as it seems to work as expected with: $make mrproper $make O=../tmp/ defconfig $make mrproper
Let me know if you are still seeing anything differently from me, and we'll try to sort it out.
We do still create a tmp file in the build directory, but we clean that up ourselves. So it might be worth moving that tmp file to the output directory as well (since one might be building in a ro source directory?).
thanks -john
-
John Stultz -
Viresh Kumar