Hi All,
Matthias and I have been throught the Ubuntu GCC 4.4 patch set and decided what to do with each of them in Linaro GCC 4.4 and 4.5. Some patches will be integrated into Linaro, and some will remain Debian/Ubuntu local.
The patches can be found here:
http://svn.debian.org/viewsvn/gcccvs/branches/sid/gcc-4.4/debian/patches/?pa...
Here are the patches in alphabetical order, and whether to apply to linaro gcc (yes/no) or already in 4.5 (upstream):
PATCH Linaro 4.4 4.5 ---------------------------------------------------------------- ada-acats.diff yes yes ada-arm-eabi.diff yes upstream ada-bug564232.diff no no ada-default-project-path.diff no no ada-driver-check.diff no no ada-gcc-name.diff [1] no no ada-gnatvsn.diff [7] maybe maybe ada-libgnatprj.diff no no ada-libgnatvsn.diff no no ada-library-project-files-soname.diff no no ada-link-lib.diff no no ada-mips.diff no no ada-nobiarch-check.diff no no ada-polyorb-dsa.diff maybe upstream ada-sjlj.diff no no ada-symbolic-tracebacks.diff [2] maybe maybe alpha-ieee.diff no no alpha-ieee-doc.diff no no alpha-no-ev4-directive.diff no no arm-boehm-gc-locks.diff yes upstream armel-hilo-union-class.diff [8] maybe maybe arm-gcc-gcse-cs.diff yes upstream arm-unbreak-eabi-armv4t.diff no no boehm-gc-getnprocs.diff [1] maybe maybe boehm-gc-nocheck.diff no no cell-branch.diff [9] no upstream cell-branch-doc.diff [9] no upstream config-ml.diff no no cross-fixes.diff no no cross-include.diff no no deb-protoize.diff no no fix-warnings.diff no no gcc-arm-implicit-it.diff [5] maybe maybe gcc-arm-thumb2-sched.diff [10] yes upstream gcc-atom.diff in CS upstream gcc-atom-doc.diff in CS upstream gcc-build-id.diff yes upstream gcc-cloog-dl-cs.diff no no gcc-default-format-security.diff [1] no no gcc-default-fortify-source.diff [1] no no gcc-default-relro.diff [1] no no gcc-default-ssp.diff [1] no no gcc-d-lang.diff no no gcc-driver-extra-langs.diff no no gcc-hash-style-both.diff [1] no no gcc-hash-style-gnu.diff [1] no no gcc-ice-apport.diff no no gcc-ice-hack.diff [3] no no gcc-ix86-asm-generic32.diff no no gcc-multiarch-cs.diff no no gcc-multiarch-i686-cs.diff no no gcc-multilib64dir.diff no no gcc-pascal-lang.diff no no gcc-stack_chk_fail-check.diff yes upstream gcc-textdomain.diff [1] no no gcc-unwind-debug-hook.diff yes upstream gcj-use-atomic-builtins.diff yes upstream gcj-use-atomic-builtins-doc.diff yes upstream gold-and-ld.diff no no gold-and-ld-doc.diff no no hurd-changes.diff no no hurd-pthread.diff no no ignore-comp-fail.diff no no kbsd-gnu-ada.diff no no kbsd-gnu.diff no no libgomp-omp_h-multilib.diff [3] no no libjava-armel-unwind.diff no no libjava-atomic-builtins-eabi.diff yes upstream libjava-disable-plugin.diff no upstream libjava-disable-static.diff no upstream libjava-fixed-symlinks.diff no upstream libjava-jnipath.diff no no libjava-josm-fixes.diff yes upstream libjava-nobiarch-check.diff no no libjava-rpath.diff no no libjava-sjlj.diff no no libjava-stacktrace.diff [1,2] no no libjava-subdir.diff no no libstdc++-arm-no-check.diff no no libstdc++-arm-wno-abi.diff no no libstdc++-doclink.diff no no libstdc++-ldbl-compat.diff [4] yes yes libstdc++-man-3cxx.diff no no libstdc++-pic.diff no no libstdc++-test-installed.diff [5] maybe maybe libsupc++-vmi_class_type_info.diff yes upstream link-libs.diff no no m68k-allow-gnu99.diff no no mips-fix-loongson2f-nop-cs.diff no no mips-triarch.diff no no mudflap-nocheck.diff no no note-gnu-stack.diff [3] no no powerpc-biarch.diff no no pr25509.diff no upstream pr25509-doc.diff no upstream pr38333.diff no upstream pr39429.diff yes upstream pr39491.diff no no pr40133.diff yes upstream pr40134.diff [2,6] yes yes pr40521-revert-workaround.diff yes upstream pr41848.diff [4] yes yes pr42321.diff yes upstream pr42748.diff yes upstream pr43323.diff yes upstream pr44261.diff no no rename-info-files.diff no no rev146451.diff yes upstream s390-biarch.diff no no sh4_atomic_update.diff no no sh4-mode-switching.diff no no sh4-multilib.diff no no sh4-scheduling.diff no no sparc-force-cpu.diff no no testsuite-hardening-format.diff no no testsuite-hardening-fortify.diff no no testsuite-hardening-printf-types.diff no no
[1] not upstreamable, but maybe another patch would be. [2] Matthias to investigate. [3] Fedora origin. [4] Already submitted upstream, not in 4.5. [5] Requires review. [6] ARM part only. [7] issue closed upstream, no patch. [8] Julian to investigate. [9] Not interesting to Linaro, but Canonical would like CS to unbreak it for Ubuntu. [10] Part of this patch is already in 4.4
Andrew Stubbs
Fixed the subject.
On 16/06/10 14:03, Andrew Stubbs wrote:
Hi All,
Matthias and I have been throught the Ubuntu GCC 4.4 patch set and decided what to do with each of them in Linaro GCC 4.4 and 4.5. Some patches will be integrated into Linaro, and some will remain Debian/Ubuntu local.
The patches can be found here:
http://svn.debian.org/viewsvn/gcccvs/branches/sid/gcc-4.4/debian/patches/?pa...
Here are the patches in alphabetical order, and whether to apply to linaro gcc (yes/no) or already in 4.5 (upstream):
PATCH Linaro 4.4 4.5
ada-acats.diff yes yes ada-arm-eabi.diff yes upstream ada-bug564232.diff no no ada-default-project-path.diff no no ada-driver-check.diff no no ada-gcc-name.diff [1] no no ada-gnatvsn.diff [7] maybe maybe ada-libgnatprj.diff no no ada-libgnatvsn.diff no no ada-library-project-files-soname.diff no no ada-link-lib.diff no no ada-mips.diff no no ada-nobiarch-check.diff no no ada-polyorb-dsa.diff maybe upstream ada-sjlj.diff no no ada-symbolic-tracebacks.diff [2] maybe maybe alpha-ieee.diff no no alpha-ieee-doc.diff no no alpha-no-ev4-directive.diff no no arm-boehm-gc-locks.diff yes upstream armel-hilo-union-class.diff [8] maybe maybe arm-gcc-gcse-cs.diff yes upstream arm-unbreak-eabi-armv4t.diff no no boehm-gc-getnprocs.diff [1] maybe maybe boehm-gc-nocheck.diff no no cell-branch.diff [9] no upstream cell-branch-doc.diff [9] no upstream config-ml.diff no no cross-fixes.diff no no cross-include.diff no no deb-protoize.diff no no fix-warnings.diff no no gcc-arm-implicit-it.diff [5] maybe maybe gcc-arm-thumb2-sched.diff [10] yes upstream gcc-atom.diff in CS upstream gcc-atom-doc.diff in CS upstream gcc-build-id.diff yes upstream gcc-cloog-dl-cs.diff no no gcc-default-format-security.diff [1] no no gcc-default-fortify-source.diff [1] no no gcc-default-relro.diff [1] no no gcc-default-ssp.diff [1] no no gcc-d-lang.diff no no gcc-driver-extra-langs.diff no no gcc-hash-style-both.diff [1] no no gcc-hash-style-gnu.diff [1] no no gcc-ice-apport.diff no no gcc-ice-hack.diff [3] no no gcc-ix86-asm-generic32.diff no no gcc-multiarch-cs.diff no no gcc-multiarch-i686-cs.diff no no gcc-multilib64dir.diff no no gcc-pascal-lang.diff no no gcc-stack_chk_fail-check.diff yes upstream gcc-textdomain.diff [1] no no gcc-unwind-debug-hook.diff yes upstream gcj-use-atomic-builtins.diff yes upstream gcj-use-atomic-builtins-doc.diff yes upstream gold-and-ld.diff no no gold-and-ld-doc.diff no no hurd-changes.diff no no hurd-pthread.diff no no ignore-comp-fail.diff no no kbsd-gnu-ada.diff no no kbsd-gnu.diff no no libgomp-omp_h-multilib.diff [3] no no libjava-armel-unwind.diff no no libjava-atomic-builtins-eabi.diff yes upstream libjava-disable-plugin.diff no upstream libjava-disable-static.diff no upstream libjava-fixed-symlinks.diff no upstream libjava-jnipath.diff no no libjava-josm-fixes.diff yes upstream libjava-nobiarch-check.diff no no libjava-rpath.diff no no libjava-sjlj.diff no no libjava-stacktrace.diff [1,2] no no libjava-subdir.diff no no libstdc++-arm-no-check.diff no no libstdc++-arm-wno-abi.diff no no libstdc++-doclink.diff no no libstdc++-ldbl-compat.diff [4] yes yes libstdc++-man-3cxx.diff no no libstdc++-pic.diff no no libstdc++-test-installed.diff [5] maybe maybe libsupc++-vmi_class_type_info.diff yes upstream link-libs.diff no no m68k-allow-gnu99.diff no no mips-fix-loongson2f-nop-cs.diff no no mips-triarch.diff no no mudflap-nocheck.diff no no note-gnu-stack.diff [3] no no powerpc-biarch.diff no no pr25509.diff no upstream pr25509-doc.diff no upstream pr38333.diff no upstream pr39429.diff yes upstream pr39491.diff no no pr40133.diff yes upstream pr40134.diff [2,6] yes yes pr40521-revert-workaround.diff yes upstream pr41848.diff [4] yes yes pr42321.diff yes upstream pr42748.diff yes upstream pr43323.diff yes upstream pr44261.diff no no rename-info-files.diff no no rev146451.diff yes upstream s390-biarch.diff no no sh4_atomic_update.diff no no sh4-mode-switching.diff no no sh4-multilib.diff no no sh4-scheduling.diff no no sparc-force-cpu.diff no no testsuite-hardening-format.diff no no testsuite-hardening-fortify.diff no no testsuite-hardening-printf-types.diff no no
[1] not upstreamable, but maybe another patch would be. [2] Matthias to investigate. [3] Fedora origin. [4] Already submitted upstream, not in 4.5. [5] Requires review. [6] ARM part only. [7] issue closed upstream, no patch. [8] Julian to investigate. [9] Not interesting to Linaro, but Canonical would like CS to unbreak it for Ubuntu. [10] Part of this patch is already in 4.4
Andrew Stubbs
Linaro-dev mailing list Linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
This is now on the wiki here: https://wiki.linaro.org/WorkingGroups/ToolChain/UbuntuGCCPatches
On 16/06/10 14:59, Andrew Stubbs wrote:
Fixed the subject.
On 16/06/10 14:03, Andrew Stubbs wrote:
Hi All,
Matthias and I have been throught the Ubuntu GCC 4.4 patch set and decided what to do with each of them in Linaro GCC 4.4 and 4.5. Some patches will be integrated into Linaro, and some will remain Debian/Ubuntu local.
The patches can be found here:
http://svn.debian.org/viewsvn/gcccvs/branches/sid/gcc-4.4/debian/patches/?pa...
Here are the patches in alphabetical order, and whether to apply to linaro gcc (yes/no) or already in 4.5 (upstream):
PATCH Linaro 4.4 4.5
ada-acats.diff yes yes ada-arm-eabi.diff yes upstream ada-bug564232.diff no no ada-default-project-path.diff no no ada-driver-check.diff no no ada-gcc-name.diff [1] no no ada-gnatvsn.diff [7] maybe maybe ada-libgnatprj.diff no no ada-libgnatvsn.diff no no ada-library-project-files-soname.diff no no ada-link-lib.diff no no ada-mips.diff no no ada-nobiarch-check.diff no no ada-polyorb-dsa.diff maybe upstream ada-sjlj.diff no no ada-symbolic-tracebacks.diff [2] maybe maybe alpha-ieee.diff no no alpha-ieee-doc.diff no no alpha-no-ev4-directive.diff no no arm-boehm-gc-locks.diff yes upstream armel-hilo-union-class.diff [8] maybe maybe arm-gcc-gcse-cs.diff yes upstream arm-unbreak-eabi-armv4t.diff no no boehm-gc-getnprocs.diff [1] maybe maybe boehm-gc-nocheck.diff no no cell-branch.diff [9] no upstream cell-branch-doc.diff [9] no upstream config-ml.diff no no cross-fixes.diff no no cross-include.diff no no deb-protoize.diff no no fix-warnings.diff no no gcc-arm-implicit-it.diff [5] maybe maybe gcc-arm-thumb2-sched.diff [10] yes upstream gcc-atom.diff in CS upstream gcc-atom-doc.diff in CS upstream gcc-build-id.diff yes upstream gcc-cloog-dl-cs.diff no no gcc-default-format-security.diff [1] no no gcc-default-fortify-source.diff [1] no no gcc-default-relro.diff [1] no no gcc-default-ssp.diff [1] no no gcc-d-lang.diff no no gcc-driver-extra-langs.diff no no gcc-hash-style-both.diff [1] no no gcc-hash-style-gnu.diff [1] no no gcc-ice-apport.diff no no gcc-ice-hack.diff [3] no no gcc-ix86-asm-generic32.diff no no gcc-multiarch-cs.diff no no gcc-multiarch-i686-cs.diff no no gcc-multilib64dir.diff no no gcc-pascal-lang.diff no no gcc-stack_chk_fail-check.diff yes upstream gcc-textdomain.diff [1] no no gcc-unwind-debug-hook.diff yes upstream gcj-use-atomic-builtins.diff yes upstream gcj-use-atomic-builtins-doc.diff yes upstream gold-and-ld.diff no no gold-and-ld-doc.diff no no hurd-changes.diff no no hurd-pthread.diff no no ignore-comp-fail.diff no no kbsd-gnu-ada.diff no no kbsd-gnu.diff no no libgomp-omp_h-multilib.diff [3] no no libjava-armel-unwind.diff no no libjava-atomic-builtins-eabi.diff yes upstream libjava-disable-plugin.diff no upstream libjava-disable-static.diff no upstream libjava-fixed-symlinks.diff no upstream libjava-jnipath.diff no no libjava-josm-fixes.diff yes upstream libjava-nobiarch-check.diff no no libjava-rpath.diff no no libjava-sjlj.diff no no libjava-stacktrace.diff [1,2] no no libjava-subdir.diff no no libstdc++-arm-no-check.diff no no libstdc++-arm-wno-abi.diff no no libstdc++-doclink.diff no no libstdc++-ldbl-compat.diff [4] yes yes libstdc++-man-3cxx.diff no no libstdc++-pic.diff no no libstdc++-test-installed.diff [5] maybe maybe libsupc++-vmi_class_type_info.diff yes upstream link-libs.diff no no m68k-allow-gnu99.diff no no mips-fix-loongson2f-nop-cs.diff no no mips-triarch.diff no no mudflap-nocheck.diff no no note-gnu-stack.diff [3] no no powerpc-biarch.diff no no pr25509.diff no upstream pr25509-doc.diff no upstream pr38333.diff no upstream pr39429.diff yes upstream pr39491.diff no no pr40133.diff yes upstream pr40134.diff [2,6] yes yes pr40521-revert-workaround.diff yes upstream pr41848.diff [4] yes yes pr42321.diff yes upstream pr42748.diff yes upstream pr43323.diff yes upstream pr44261.diff no no rename-info-files.diff no no rev146451.diff yes upstream s390-biarch.diff no no sh4_atomic_update.diff no no sh4-mode-switching.diff no no sh4-multilib.diff no no sh4-scheduling.diff no no sparc-force-cpu.diff no no testsuite-hardening-format.diff no no testsuite-hardening-fortify.diff no no testsuite-hardening-printf-types.diff no no
[1] not upstreamable, but maybe another patch would be. [2] Matthias to investigate. [3] Fedora origin. [4] Already submitted upstream, not in 4.5. [5] Requires review. [6] ARM part only. [7] issue closed upstream, no patch. [8] Julian to investigate. [9] Not interesting to Linaro, but Canonical would like CS to unbreak it for Ubuntu. [10] Part of this patch is already in 4.4
Andrew Stubbs
Linaro-dev mailing list Linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
On Wed, Jun 16, 2010, Andrew Stubbs wrote:
Matthias and I have been throught the Ubuntu GCC 4.4 patch set and decided what to do with each of them in Linaro GCC 4.4 and 4.5. Some patches will be integrated into Linaro, and some will remain Debian/Ubuntu local.
This is awesome, thanks for the review!
I wonder whether we should document that using tags in the patch files themselves.
http://svn.debian.org/viewsvn/gcccvs/branches/sid/gcc-4.4/debian/patches/?pa...
It's good you captured the revision of the review in here; are the gcc-4.5 patches a strict subset of the gcc-4.4 ones?
I suppose we should plan reviewing patches which get added to gcc-4.x packages as well from time to time; we should have a process to get the interesting ones in gcc-linaro at least.
[1] not upstreamable, but maybe another patch would be.
Some patches were not tagged at all, are these all patches which are upstreamable or Ubuntu specific or something else?
On 16/06/10 20:27, Loïc Minier wrote:
[1] not upstreamable, but maybe another patch would be.
Some patches were not tagged at all, are these all patches which are upstreamable or Ubuntu specific or something else?
By tagged, you mean I did not have a note for them? Usually that just means I had nothing interesting to say about them.
We used upstreamablilty as part of the fitness criteria for Linaro. The patches tagged with note [1] are patches that are not themselves upstreamable, and so perhaps not fit for Linaro, but which it might be interesting to reimplement in an upstreamable way, and apply that to Linaro. Perhaps the patch could be made conditional on a configure option, or some such thing.
Andrew
On Thu, Jun 17, 2010, Andrew Stubbs wrote:
Some patches were not tagged at all, are these all patches which are upstreamable or Ubuntu specific or something else?
By tagged, you mean I did not have a note for them? Usually that just means I had nothing interesting to say about them.
Yes
We used upstreamablilty as part of the fitness criteria for Linaro. The patches tagged with note [1] are patches that are not themselves upstreamable, and so perhaps not fit for Linaro, but which it might be interesting to reimplement in an upstreamable way, and apply that to Linaro. Perhaps the patch could be made conditional on a configure option, or some such thing.
A lot of patches don't have the '[1]' note but have no comment on why they wouldn't be upstreamable or can't be included in Linaro. I was wondering if they were all Ubuntu specific patches. Perhaps they are patches which Linaro doesn't care about but might or might not go upstream as pushed by Ubuntu, is that a fair description?
On 17/06/10 10:08, Loïc Minier wrote:
On Thu, Jun 17, 2010, Andrew Stubbs wrote:
We used upstreamablilty as part of the fitness criteria for Linaro. The patches tagged with note [1] are patches that are not themselves upstreamable, and so perhaps not fit for Linaro, but which it might be interesting to reimplement in an upstreamable way, and apply that to Linaro. Perhaps the patch could be made conditional on a configure option, or some such thing.
A lot of patches don't have the '[1]' note but have no comment on why they wouldn't be upstreamable or can't be included in Linaro. I was wondering if they were all Ubuntu specific patches. Perhaps they are patches which Linaro doesn't care about but might or might not go upstream as pushed by Ubuntu, is that a fair description?
It either means the patch is not upstreamable, even if you modified it lots, or that we wouldn't be interested in doing so.
The absence of note [1] may mean that the patch is not interesting, rather than implying that it is upstreamable.
Andrew
-
Andrew Stubbs -
Loïc Minier