Dear Minku, Please ignore this patch. As i have removed #define GPIO_DRV_FAST 0x0 #define GPIO_DRV_SLOW 0x1

as these are not defined for s5pc2xx. But being reffered in s5p_gpio.c. I will add again and send the patch. Regards, Chander

On 18 April 2011 09:31, Chander Kashyap chander.kashyap@linaro.org wrote:

Macro values for Pull Up and Driver Strength were wrong.

Signed-off-by: Chander Kashyap chander.kashyap@linaro.org

arch/arm/include/asm/arch-s5pc2xx/gpio.h | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm/include/asm/arch-s5pc2xx/gpio.h b/arch/arm/include/asm/arch-s5pc2xx/gpio.h index 05e5b3e..e49edd4 100644 --- a/arch/arm/include/asm/arch-s5pc2xx/gpio.h +++ b/arch/arm/include/asm/arch-s5pc2xx/gpio.h @@ -99,14 +99,12 @@ void gpio_set_rate(struct s5p_gpio_bank *bank, int gpio, int mode); /* Pull mode */ #define GPIO_PULL_NONE 0x0 #define GPIO_PULL_DOWN 0x1 -#define GPIO_PULL_UP 0x2 +#define GPIO_PULL_UP 0x3

/* Drive Strength level */ #define GPIO_DRV_1X 0x0 -#define GPIO_DRV_2X 0x1 -#define GPIO_DRV_3X 0x2 +#define GPIO_DRV_3X 0x1 +#define GPIO_DRV_2X 0x2 #define GPIO_DRV_4X 0x3 -#define GPIO_DRV_FAST 0x0 -#define GPIO_DRV_SLOW 0x1

#endif

1.7.1