Chander Kashyap (2): Exynos: PWM: Add TCMPB3 field in pwm structure Exynos: Fix ARM Clock frequency calculation
arch/arm/cpu/armv7/exynos/clock.c | 15 +++++++++------ arch/arm/include/asm/arch-exynos/pwm.h | 2 +- 2 files changed, 10 insertions(+), 7 deletions(-)
Add TCMPB3 field in pwm structure, earliar this was res1.
Signed-off-by: Chander Kashyap chander.kashyap@linaro.org --- arch/arm/include/asm/arch-exynos/pwm.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/arch-exynos/pwm.h b/arch/arm/include/asm/arch-exynos/pwm.h index d0cf3cb..3e95160 100644 --- a/arch/arm/include/asm/arch-exynos/pwm.h +++ b/arch/arm/include/asm/arch-exynos/pwm.h @@ -57,7 +57,7 @@ struct s5p_timer { unsigned int tcmpb2; unsigned int tcnto2; unsigned int tcntb3; - unsigned int res1; + unsigned int tcmpb3; unsigned int tcnto3; unsigned int tcntb4; unsigned int tcnto4;
Dear Chander Kashyap,
In message 1324285004-32354-2-git-send-email-chander.kashyap@linaro.org you wrote:
Add TCMPB3 field in pwm structure, earliar this was res1.
Signed-off-by: Chander Kashyap chander.kashyap@linaro.org
arch/arm/include/asm/arch-exynos/pwm.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/arch-exynos/pwm.h b/arch/arm/include/asm/arch-exynos/pwm.h index d0cf3cb..3e95160 100644
You submit a V2 patch, but without any indication what was changed ???
Where is the _mandatory_ change log?
Best regards,
Wolfgang Denk
Hi Wolfgsng Denk,
On 19 December 2011 14:33, Wolfgang Denk wd@denx.de wrote:
Dear Chander Kashyap,
In message 1324285004-32354-2-git-send-email-chander.kashyap@linaro.org you wrote:
Add TCMPB3 field in pwm structure, earliar this was res1.
Signed-off-by: Chander Kashyap chander.kashyap@linaro.org
arch/arm/include/asm/arch-exynos/pwm.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/arch-exynos/pwm.h
b/arch/arm/include/asm/arch-exynos/pwm.h
index d0cf3cb..3e95160 100644
You submit a V2 patch, but without any indication what was changed ???
Changes are in Patch2/2. I have mentioned them in Patch2/2.
Where is the _mandatory_ change log?
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Always try to do things in chronological order; it's less confusing that way.
Dear Chander Kashyap,
On 19 December 2011 17:56, Chander Kashyap chander.kashyap@linaro.org wrote:
Add TCMPB3 field in pwm structure, earliar this was res1.
Signed-off-by: Chander Kashyap chander.kashyap@linaro.org
arch/arm/include/asm/arch-exynos/pwm.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
applied to u-boot-samsung. Thanks,Minkyu Kang.-- from. prom. www.promsoft.net
Earliar ARM clock frequency was calculated by: MOUTAPLL/(DIVAPLL + 1) which is actually returning SCLKAPLL. It is fixed by calculating it as follows: ARMCLK=MOUTCORE / (DIVCORE + 1) / (DIVCORE2 + 1)
Signed-off-by: Chander Kashyap chander.kashyap@linaro.org --- Changes for V2: - Fixed commit comment - Fixed comment in clock.c "exynos4_get_arm_clk ()" - Renamed dout_apll to armclk in clock.c "exynos4_get_arm_clk ()" arch/arm/cpu/armv7/exynos/clock.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c index 64de262..0c199cd 100644 --- a/arch/arm/cpu/armv7/exynos/clock.c +++ b/arch/arm/cpu/armv7/exynos/clock.c @@ -102,17 +102,20 @@ static unsigned long exynos4_get_arm_clk(void) struct exynos4_clock *clk = (struct exynos4_clock *)samsung_get_base_clock(); unsigned long div; - unsigned long dout_apll; - unsigned int apll_ratio; + unsigned long armclk; + unsigned int core_ratio; + unsigned int core2_ratio;
div = readl(&clk->div_cpu0);
- /* APLL_RATIO: [26:24] */ - apll_ratio = (div >> 24) & 0x7; + /* CORE_RATIO: [2:0], CORE2_RATIO: [30:28] */ + core_ratio = (div >> 0) & 0x7; + core2_ratio = (div >> 28) & 0x7;
- dout_apll = get_pll_clk(APLL) / (apll_ratio + 1); + armclk = get_pll_clk(APLL) / (core_ratio + 1); + armclk /= (core2_ratio + 1);
- return dout_apll; + return armclk; }
/* exynos4: return pwm clock frequency */
Dear Chander Kashyap,
On 19 December 2011 17:56, Chander Kashyap chander.kashyap@linaro.org wrote:
Earliar ARM clock frequency was calculated by: MOUTAPLL/(DIVAPLL + 1) which is actually returning SCLKAPLL. It is fixed by calculating it as follows: ARMCLK=MOUTCORE / (DIVCORE + 1) / (DIVCORE2 + 1)
Signed-off-by: Chander Kashyap chander.kashyap@linaro.org
Changes for V2: - Fixed commit comment - Fixed comment in clock.c "exynos4_get_arm_clk ()" - Renamed dout_apll to armclk in clock.c "exynos4_get_arm_clk ()" arch/arm/cpu/armv7/exynos/clock.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-)
applied to u-boot-samsung.
Thanks, Minkyu Kang.
-
Chander Kashyap -
Minkyu Kang -
Wolfgang Denk