On 01/07/2013 10:58 PM, Rafael J. Wysocki wrote:
Hi,
Thanks for the patch!
I'd like Daniel to have a look at it still.
I agree with this patch. I was about to send exactly the same.
Thanks Krzysztof for fixing this.
On Monday, January 07, 2013 08:12:01 PM Krzysztof Mazur wrote:
Commit bf4d1b5ddb78f86078ac6ae0415802d5f0c68f92 (cpuidle: support multiple drivers) changed the number of initialized state kobjects in cpuidle_add_state_sysfs() from device->state_count to drv->state_count, but leaved device->state_count in cpuidle_remove_state_sysfs(). Those two values might have different values, causing for instance NULL pointer dereference in cpuidle_remove_state_sysfs().
Signed-off-by: Krzysztof Mazur krzysiek@podlesie.net
Acked-by: Daniel Lezcano daniel.lezcano@linaro.org
On Monday, January 07, 2013 11:56:36 PM Daniel Lezcano wrote:
On 01/07/2013 10:58 PM, Rafael J. Wysocki wrote:
Hi,
Thanks for the patch!
I'd like Daniel to have a look at it still.
I agree with this patch. I was about to send exactly the same.
Thanks Krzysztof for fixing this.
On Monday, January 07, 2013 08:12:01 PM Krzysztof Mazur wrote:
Commit bf4d1b5ddb78f86078ac6ae0415802d5f0c68f92 (cpuidle: support multiple drivers) changed the number of initialized state kobjects in cpuidle_add_state_sysfs() from device->state_count to drv->state_count, but leaved device->state_count in cpuidle_remove_state_sysfs(). Those two values might have different values, causing for instance NULL pointer dereference in cpuidle_remove_state_sysfs().
Signed-off-by: Krzysztof Mazur krzysiek@podlesie.net
Acked-by: Daniel Lezcano daniel.lezcano@linaro.org
OK, thanks.
I have a pull request for 3.8-rc3 ready, so I'll send this one in the next round.
Thanks, Rafael