From: Venkatraman S venkat@linaro.org
Signed-off-by: Venkatraman S venkat@linaro.org --- drivers/mfd/twl4030-irq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index 8a7ee31..ac3a27d 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c @@ -34,7 +34,7 @@ #include <linux/slab.h>
#include <linux/i2c/twl.h> - +#include <mach/irqs.h> #include "twl-core.h"
/*
On Tue, 23 Aug 2011, Venkatraman S wrote:
From: Venkatraman S venkat@linaro.org
Signed-off-by: Venkatraman S venkat@linaro.org
Same issue here, however it is not obvious what <mach/irqs.h> provides that the code relies on. In such cases it is a good idea to state it in the commit log so if the solution is not satisfactory then it is easier for reviewers to suggest alternatives.
drivers/mfd/twl4030-irq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index 8a7ee31..ac3a27d 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c @@ -34,7 +34,7 @@ #include <linux/slab.h> #include <linux/i2c/twl.h>
+#include <mach/irqs.h> #include "twl-core.h" /* -- 1.7.1
On 24 August 2011 00:05, Nicolas Pitre nicolas.pitre@linaro.org wrote:
On Tue, 23 Aug 2011, Venkatraman S wrote:
From: Venkatraman S venkat@linaro.org
Signed-off-by: Venkatraman S venkat@linaro.org
Same issue here, however it is not obvious what <mach/irqs.h> provides that the code relies on. In such cases it is a good idea to state it in the commit log so if the solution is not satisfactory then it is easier for reviewers to suggest alternatives.
Ok. I was on a blind #include binge during Linaro connect. Will add the details and repost.
-
Nicolas Pitre -
Venkatraman S