Hi Luis,
Can you help me review this patch?
Kind Regards,
Zhengwang
-------- Original Message -------- From: 阮正旺 Sent: Mon, 15 Apr 2019 15:10:40 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Hi all,
I found several compiling errors while building pm-qa with Android, the error logs as below.
=======
external/pm-qa/cpuidle/cpuidle_killer.c:34:21: error: unused parameter 'sig' [-Werror,-Wunused-parameter] void sighandler(int sig) ^ external/pm-qa/cpuidle/cpuidle_killer.c:39:18: error: unused parameter 'sig' [-Werror,-Wunused-parameter] void timeout(int sig) ^ external/pm-qa/cpuidle/cpuidle_killer.c:108:14: error: unused parameter 'argc' [-Werror,-Wunused-parameter] int main(int argc, char *argv[]) ^ external/pm-qa/cpuidle/cpuidle_killer.c:108:26: error: unused parameter 'argv' [-Werror,-Wunused-parameter] int main(int argc, char *argv[])
=======
This is caused because Android enabled '-Wall -Werror' compiling parameters by default, so we need to disable it in pm-qa project.
Kind Regards,
Zhengwang
-------- Original Message -------- From: Zhengwang Ruan Sent: Mon, 15 Apr 2019 15:02:54 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Android enables '-Wall -Werror' compiling parameters by default, as a result compiling errors are caused in cpuidle and utils, so add '-Wno-error' to disable this check.
Signed-off-by: Zhengwang Ruanruanzw@xiaopeng.com
cpuidle/Android.mk | 1 + utils/Android.mk | 1 + 2 files changed, 2 insertions(+)
diff --git a/cpuidle/Android.mk b/cpuidle/Android.mk index f0dc52d..041b7f6 100644 --- a/cpuidle/Android.mk +++ b/cpuidle/Android.mk @@ -23,6 +23,7 @@ LOCAL_MODULE := cpuidle_killer systemtarball: cpuidle_killer systemimage: cpuidle_killer LOCAL_SRC_FILES:= cpuidle_killer.c +LOCAL_CFLAGS += -Wno-error LOCAL_SHARED_LIBRARIES := libcutils libc LOCAL_MODULE_TAGS := tests LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) diff --git a/utils/Android.mk b/utils/Android.mk index 0fee7bf..6484bfc 100644 --- a/utils/Android.mk +++ b/utils/Android.mk @@ -11,6 +11,7 @@ define $(module_name)_etc_add_executable systemtarball: $1 systemimage: $1 LOCAL_SRC_FILES := $1.c
- LOCAL_CFLAGS += -Wno-error LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_EXECUTABLE) endef
Sorry for the delay, i was out on vacation and i'm back today.
The change below looks OK to me.
I'll track who's responsible for pm-qa and will get this through.
On 4/16/19 1:05 AM, 阮正旺 wrote:
Hi Luis,
Can you help me review this patch?
Kind Regards,
Zhengwang
-------- Original Message -------- From: 阮正旺 Sent: Mon, 15 Apr 2019 15:10:40 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Hi all,
I found several compiling errors while building pm-qa with Android, the error logs as below.
=======
external/pm-qa/cpuidle/cpuidle_killer.c:34:21: error: unused parameter 'sig' [-Werror,-Wunused-parameter] void sighandler(int sig) ^ external/pm-qa/cpuidle/cpuidle_killer.c:39:18: error: unused parameter 'sig' [-Werror,-Wunused-parameter] void timeout(int sig) ^ external/pm-qa/cpuidle/cpuidle_killer.c:108:14: error: unused parameter 'argc' [-Werror,-Wunused-parameter] int main(int argc, char *argv[]) ^ external/pm-qa/cpuidle/cpuidle_killer.c:108:26: error: unused parameter 'argv' [-Werror,-Wunused-parameter] int main(int argc, char *argv[])
=======
This is caused because Android enabled '-Wall -Werror' compiling parameters by default, so we need to disable it in pm-qa project.
Kind Regards,
Zhengwang
-------- Original Message -------- From: Zhengwang Ruan Sent: Mon, 15 Apr 2019 15:02:54 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Android enables '-Wall -Werror' compiling parameters by default, as a result compiling errors are caused in cpuidle and utils, so add '-Wno-error' to disable this check.
Signed-off-by: Zhengwang Ruanruanzw@xiaopeng.com
cpuidle/Android.mk | 1 + utils/Android.mk | 1 + 2 files changed, 2 insertions(+)
diff --git a/cpuidle/Android.mk b/cpuidle/Android.mk index f0dc52d..041b7f6 100644 --- a/cpuidle/Android.mk +++ b/cpuidle/Android.mk @@ -23,6 +23,7 @@ LOCAL_MODULE := cpuidle_killer systemtarball: cpuidle_killer systemimage: cpuidle_killer LOCAL_SRC_FILES:= cpuidle_killer.c +LOCAL_CFLAGS += -Wno-error LOCAL_SHARED_LIBRARIES := libcutils libc LOCAL_MODULE_TAGS := tests LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) diff --git a/utils/Android.mk b/utils/Android.mk index 0fee7bf..6484bfc 100644 --- a/utils/Android.mk +++ b/utils/Android.mk @@ -11,6 +11,7 @@ define $(module_name)_etc_add_executable systemtarball: $1 systemimage: $1 LOCAL_SRC_FILES := $1.c
- LOCAL_CFLAGS += -Wno-error LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_EXECUTABLE) endef
Hi Luis,
Thank you && looking forward to your further response!
Kind Regards,
Zhengwang
-------- Original Message -------- From: Luis Machado Sent: Mon, 29 Apr 2019 12:21:38 -0300 To: 阮正旺 Cc: Linaro-dev Subject: Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Sorry for the delay, i was out on vacation and i'm back today.
The change below looks OK to me.
I'll track who's responsible for pm-qa and will get this through.
On 4/16/19 1:05 AM, 阮正旺 wrote:
Hi Luis,
Can you help me review this patch?
Kind Regards,
Zhengwang
-------- Original Message -------- From: 阮正旺 Sent: Mon, 15 Apr 2019 15:10:40 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Hi all,
I found several compiling errors while building pm-qa with Android, the error logs as below.
=======
external/pm-qa/cpuidle/cpuidle_killer.c:34:21: error: unused parameter 'sig' [-Werror,-Wunused-parameter] void sighandler(int sig) ^ external/pm-qa/cpuidle/cpuidle_killer.c:39:18: error: unused parameter 'sig' [-Werror,-Wunused-parameter] void timeout(int sig) ^ external/pm-qa/cpuidle/cpuidle_killer.c:108:14: error: unused parameter 'argc' [-Werror,-Wunused-parameter] int main(int argc, char *argv[]) ^ external/pm-qa/cpuidle/cpuidle_killer.c:108:26: error: unused parameter 'argv' [-Werror,-Wunused-parameter] int main(int argc, char *argv[])
=======
This is caused because Android enabled '-Wall -Werror' compiling parameters by default, so we need to disable it in pm-qa project.
Kind Regards,
Zhengwang
-------- Original Message -------- From: Zhengwang Ruan Sent: Mon, 15 Apr 2019 15:02:54 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Android enables '-Wall -Werror' compiling parameters by default, as a result compiling errors are caused in cpuidle and utils, so add '-Wno-error' to disable this check.
Signed-off-by: Zhengwang Ruanruanzw@xiaopeng.com
cpuidle/Android.mk | 1 + utils/Android.mk | 1 + 2 files changed, 2 insertions(+)
diff --git a/cpuidle/Android.mk b/cpuidle/Android.mk index f0dc52d..041b7f6 100644 --- a/cpuidle/Android.mk +++ b/cpuidle/Android.mk @@ -23,6 +23,7 @@ LOCAL_MODULE := cpuidle_killer systemtarball: cpuidle_killer systemimage: cpuidle_killer LOCAL_SRC_FILES:= cpuidle_killer.c +LOCAL_CFLAGS += -Wno-error LOCAL_SHARED_LIBRARIES := libcutils libc LOCAL_MODULE_TAGS := tests LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) diff --git a/utils/Android.mk b/utils/Android.mk index 0fee7bf..6484bfc 100644 --- a/utils/Android.mk +++ b/utils/Android.mk @@ -11,6 +11,7 @@ define $(module_name)_etc_add_executable systemtarball: $1 systemimage: $1 LOCAL_SRC_FILES := $1.c + LOCAL_CFLAGS += -Wno-error LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_EXECUTABLE) endef
Hi Zhengwang,
Thanks for the patch. But I can't find your original patch in linaro-dev list and archive: https://lists.linaro.org/pipermail/linaro-dev/2019-April/thread.html#18429 Can you resend it to linaro-dev so I can get and apply it ?
Thanks, Vincent
On Tue, 30 Apr 2019 at 08:13, 阮正旺 ruanzw@xiaopeng.com wrote:
Hi Luis,
Thank you && looking forward to your further response!
Kind Regards,
Zhengwang
-------- Original Message -------- From: Luis Machado Sent: Mon, 29 Apr 2019 12:21:38 -0300 To: 阮正旺 Cc: Linaro-dev Subject: Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Sorry for the delay, i was out on vacation and i'm back today.
The change below looks OK to me.
I'll track who's responsible for pm-qa and will get this through.
On 4/16/19 1:05 AM, 阮正旺 wrote:
Hi Luis,
Can you help me review this patch?
Kind Regards,
Zhengwang
-------- Original Message -------- From: 阮正旺 Sent: Mon, 15 Apr 2019 15:10:40 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Hi all,
I found several compiling errors while building pm-qa with Android, the error logs as below.
=======
external/pm-qa/cpuidle/cpuidle_killer.c:34:21: error: unused parameter 'sig' [-Werror,-Wunused-parameter] void sighandler(int sig) ^ external/pm-qa/cpuidle/cpuidle_killer.c:39:18: error: unused parameter 'sig' [-Werror,-Wunused-parameter] void timeout(int sig) ^ external/pm-qa/cpuidle/cpuidle_killer.c:108:14: error: unused parameter 'argc' [-Werror,-Wunused-parameter] int main(int argc, char *argv[]) ^ external/pm-qa/cpuidle/cpuidle_killer.c:108:26: error: unused parameter 'argv' [-Werror,-Wunused-parameter] int main(int argc, char *argv[])
=======
This is caused because Android enabled '-Wall -Werror' compiling parameters by default, so we need to disable it in pm-qa project.
Kind Regards,
Zhengwang
-------- Original Message -------- From: Zhengwang Ruan Sent: Mon, 15 Apr 2019 15:02:54 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Android enables '-Wall -Werror' compiling parameters by default, as a result compiling errors are caused in cpuidle and utils, so add '-Wno-error' to disable this check.
Signed-off-by: Zhengwang Ruanruanzw@xiaopeng.com
cpuidle/Android.mk | 1 + utils/Android.mk | 1 + 2 files changed, 2 insertions(+)
diff --git a/cpuidle/Android.mk b/cpuidle/Android.mk index f0dc52d..041b7f6 100644 --- a/cpuidle/Android.mk +++ b/cpuidle/Android.mk @@ -23,6 +23,7 @@ LOCAL_MODULE := cpuidle_killer systemtarball: cpuidle_killer systemimage: cpuidle_killer LOCAL_SRC_FILES:= cpuidle_killer.c +LOCAL_CFLAGS += -Wno-error LOCAL_SHARED_LIBRARIES := libcutils libc LOCAL_MODULE_TAGS := tests LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) diff --git a/utils/Android.mk b/utils/Android.mk index 0fee7bf..6484bfc 100644 --- a/utils/Android.mk +++ b/utils/Android.mk @@ -11,6 +11,7 @@ define $(module_name)_etc_add_executable systemtarball: $1 systemimage: $1 LOCAL_SRC_FILES := $1.c
- LOCAL_CFLAGS += -Wno-error LOCAL_MODULE_PATH :=
$(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_EXECUTABLE) endef
linaro-dev mailing list linaro-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-dev
Hi Vincent,
I have resent it with subject as '[PATCH PM-QA v2] Android.mk: fix compiling errors caused by unused parameters', please help me review it again!
Thanks,
Zhengwang
-------- Original Message -------- From: Vincent Guittot Sent: Thu, 2 May 2019 09:20:07 +0200 To: 阮正旺 Cc: Luis Machado, Linaro-dev Subject: Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Hi Zhengwang,
Thanks for the patch. But I can't find your original patch in linaro-dev list and archive: https://lists.linaro.org/pipermail/linaro-dev/2019-April/thread.html#18429 Can you resend it to linaro-dev so I can get and apply it ?
Thanks, Vincent
On Tue, 30 Apr 2019 at 08:13, 阮正旺 ruanzw@xiaopeng.com wrote:
Hi Luis,
Thank you && looking forward to your further response!
Kind Regards,
Zhengwang
-------- Original Message -------- From: Luis Machado Sent: Mon, 29 Apr 2019 12:21:38 -0300 To: 阮正旺 Cc: Linaro-dev Subject: Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Sorry for the delay, i was out on vacation and i'm back today.
The change below looks OK to me.
I'll track who's responsible for pm-qa and will get this through.
On 4/16/19 1:05 AM, 阮正旺 wrote:
Hi Luis,
Can you help me review this patch?
Kind Regards,
Zhengwang
-------- Original Message -------- From: 阮正旺 Sent: Mon, 15 Apr 2019 15:10:40 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Hi all,
I found several compiling errors while building pm-qa with Android, the error logs as below.
=======
external/pm-qa/cpuidle/cpuidle_killer.c:34:21: error: unused parameter 'sig' [-Werror,-Wunused-parameter] void sighandler(int sig) ^ external/pm-qa/cpuidle/cpuidle_killer.c:39:18: error: unused parameter 'sig' [-Werror,-Wunused-parameter] void timeout(int sig) ^ external/pm-qa/cpuidle/cpuidle_killer.c:108:14: error: unused parameter 'argc' [-Werror,-Wunused-parameter] int main(int argc, char *argv[]) ^ external/pm-qa/cpuidle/cpuidle_killer.c:108:26: error: unused parameter 'argv' [-Werror,-Wunused-parameter] int main(int argc, char *argv[])
=======
This is caused because Android enabled '-Wall -Werror' compiling parameters by default, so we need to disable it in pm-qa project.
Kind Regards,
Zhengwang
-------- Original Message -------- From: Zhengwang Ruan Sent: Mon, 15 Apr 2019 15:02:54 +0800 To: Linaro-dev Cc: Zhengwang Ruan Subject: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters
Android enables '-Wall -Werror' compiling parameters by default, as a result compiling errors are caused in cpuidle and utils, so add '-Wno-error' to disable this check.
Signed-off-by: Zhengwang Ruanruanzw@xiaopeng.com
cpuidle/Android.mk | 1 + utils/Android.mk | 1 + 2 files changed, 2 insertions(+)
diff --git a/cpuidle/Android.mk b/cpuidle/Android.mk index f0dc52d..041b7f6 100644 --- a/cpuidle/Android.mk +++ b/cpuidle/Android.mk @@ -23,6 +23,7 @@ LOCAL_MODULE := cpuidle_killer systemtarball: cpuidle_killer systemimage: cpuidle_killer LOCAL_SRC_FILES:= cpuidle_killer.c +LOCAL_CFLAGS += -Wno-error LOCAL_SHARED_LIBRARIES := libcutils libc LOCAL_MODULE_TAGS := tests LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) diff --git a/utils/Android.mk b/utils/Android.mk index 0fee7bf..6484bfc 100644 --- a/utils/Android.mk +++ b/utils/Android.mk @@ -11,6 +11,7 @@ define $(module_name)_etc_add_executable systemtarball: $1 systemimage: $1 LOCAL_SRC_FILES := $1.c
- LOCAL_CFLAGS += -Wno-error LOCAL_MODULE_PATH :=
$(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_EXECUTABLE) endef
linaro-dev mailing list linaro-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-dev
-
Luis Machado -
Vincent Guittot -
阮正旺