[PATCH PM-QA v2] thermal/thermal_06.sh: add missing get_os before check the return value
'ps' have different output between Android and ubuntu, and test suite use get_os to determine which OS the scripts are running on.
at commit 84479a38, thermal: Get correct PID for heat_cpu based on OS this patch want to get PID based on OS, but it looks thermal_06.sh foget to add get_os before checking the OS.
Signed-off-by: Li Zhijian lizhijian@cn.fujitsu.com --- thermal/thermal_06.sh | 1 + 1 file changed, 1 insertion(+)
diff --git a/thermal/thermal_06.sh b/thermal/thermal_06.sh index d8bcd23..6fdc469 100755 --- a/thermal/thermal_06.sh +++ b/thermal/thermal_06.sh @@ -50,6 +50,7 @@ check_trip_point_change() { trip_type=0 trip_type_path=0 $CPU_HEAT_BIN & + get_os if [ $? -eq 1 ]; then cpu_pid=$(ps | grep heat_cpu| awk '{print $1}') else
On 16 October 2017 at 20:02, Li Zhijian lizhijian@cn.fujitsu.com wrote:
'ps' have different output between Android and ubuntu, and test suite use get_os to determine which OS the scripts are running on.
at commit 84479a38, thermal: Get correct PID for heat_cpu based on OS this patch want to get PID based on OS, but it looks thermal_06.sh foget to add get_os before checking the OS.
Signed-off-by: Li Zhijian lizhijian@cn.fujitsu.com
Patch applied. Thank you!
thermal/thermal_06.sh | 1 + 1 file changed, 1 insertion(+)
diff --git a/thermal/thermal_06.sh b/thermal/thermal_06.sh index d8bcd23..6fdc469 100755 --- a/thermal/thermal_06.sh +++ b/thermal/thermal_06.sh @@ -50,6 +50,7 @@ check_trip_point_change() { trip_type=0 trip_type_path=0 $CPU_HEAT_BIN &
- get_os if [ $? -eq 1 ]; then cpu_pid=$(ps | grep heat_cpu| awk '{print $1}') else
-- 2.15.0.rc0
linaro-dev mailing list linaro-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-dev
-
Li Zhijian -
Lisa Nguyen