-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
the kernel does not compile when CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
it fails with :
CHK include/linux/version.h CHK include/generated/utsrelease.h make[1]: `include/generated/mach-types.h' is up to date. CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC drivers/clocksource/clksrc-dbx500-prcmu.o drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: type defaults to ?int? in declaration of ?DEFINE_CLOCK_DATA? drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: parameter names (without types) in function declaration drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?sched_clock?: drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: implicit declaration of function ?cyc_to_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: (Each undeclared identifier is reported only once drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: for each function it appears in.) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_update_sched_clock?: drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: implicit declaration of function ?update_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_init?: drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: implicit declaration of function ?init_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: ?cd? undeclared (first use in this function) make[2]: *** [drivers/clocksource/clksrc-dbx500-prcmu.o] Error 1 make[1]: *** [drivers/clocksource] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 make: *** Waiting for unfinished jobs....
Is it dead code ?
Thanks
-- Daniel
- -- http://www.linaro.org/ Linaro.org ? Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro Facebook | http://twitter.com/#!/linaroorg Twitter | http://www.linaro.org/linaro-blog/ Blog
On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
the kernel does not compile when CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
it fails with :
CHK include/linux/version.h CHK include/generated/utsrelease.h make[1]: `include/generated/mach-types.h' is up to date. CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC drivers/clocksource/clksrc-dbx500-prcmu.o drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: type defaults to ?int? in declaration of ?DEFINE_CLOCK_DATA? drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: parameter names (without types) in function declaration drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?sched_clock?: drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: implicit declaration of function ?cyc_to_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: (Each undeclared identifier is reported only once drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: for each function it appears in.) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_update_sched_clock?: drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: implicit declaration of function ?update_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_init?: drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: implicit declaration of function ?init_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: ?cd? undeclared (first use in this function) make[2]: *** [drivers/clocksource/clksrc-dbx500-prcmu.o] Error 1 make[1]: *** [drivers/clocksource] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 make: *** Waiting for unfinished jobs....
Is it dead code ?
No if it was dead it shouldn't get compiled.
It' probably just some fallout from Marc's rewrite of the sched_clock() stuff, I'll see if I can cook a patch and send off to Marc.
Yours, Linus Walleij
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/02/2012 01:59 PM, Linus Walleij wrote:
On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
the kernel does not compile when CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
it fails with :
CHK include/linux/version.h CHK include/generated/utsrelease.h make[1]: `include/generated/mach-types.h' is up to date. CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC drivers/clocksource/clksrc-dbx500-prcmu.o drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: type defaults to ?int? in declaration of ?DEFINE_CLOCK_DATA? drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: parameter names (without types) in function declaration drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?sched_clock?: drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: implicit declaration of function ?cyc_to_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: (Each undeclared identifier is reported only once drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: for each function it appears in.) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_update_sched_clock?: drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: implicit declaration of function ?update_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_init?: drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: implicit declaration of function ?init_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: ?cd? undeclared (first use in this function) make[2]: *** [drivers/clocksource/clksrc-dbx500-prcmu.o] Error 1 make[1]: *** [drivers/clocksource] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 make: *** Waiting for unfinished jobs....
Is it dead code ?
No if it was dead it shouldn't get compiled.
It' probably just some fallout from Marc's rewrite of the sched_clock() stuff, I'll see if I can cook a patch and send off to Marc.
Ok, thanks. I will test the patch you sent.
it seems also the commit :
commit c15def1cc30edeaa74a97205c936be82cdc86df6 Author: Linus Walleij linus.walleij@linaro.org Date: Thu Dec 15 13:38:40 2011 +0100
ARM: ux500: remove support for early silicon revisions
The DB8500 ED (Early Drop) and V1 are only available inside of ST-Ericsson or partners, we have actively replaced and scrapped these prototypes. All Nova products on the open market (such as the Snowball board) are based on V2 and later ASIC variants. So let us focus on supporting the silicon that will be used and delete this to get a clear overview.
Signed-off-by: Linus Walleij linus.walleij@linaro.org
removed the U8500_PRCMU_TCDM_BASE_V1 macro definition but it is still used in drivers/mfd/db8500-prcmu.c
The compilation fails with:
drivers/mfd/db8500-prcmu.c: In function ?db8500_prcmu_early_init?: drivers/mfd/db8500-prcmu.c:2107: error: ?U8500_PRCMU_TCDM_BASE_V1? undeclared (first use in this function) drivers/mfd/db8500-prcmu.c:2107: error: (Each undeclared identifier is reported only once drivers/mfd/db8500-prcmu.c:2107: error: for each function it appears in.) make[2]: *** [drivers/mfd/db8500-prcmu.o] Error 1 make[1]: *** [drivers/mfd] Error 2 make[1]: *** Waiting for unfinished jobs....
- --
http://www.linaro.org/ Linaro.org ? Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro Facebook | http://twitter.com/#!/linaroorg Twitter | http://www.linaro.org/linaro-blog/ Blog
On Mon, Jan 2, 2012 at 2:55 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
it seems also the commit :
commit c15def1cc30edeaa74a97205c936be82cdc86df6 Author: Linus Walleij linus.walleij@linaro.org Date: Thu Dec 15 13:38:40 2011 +0100
ARM: ux500: remove support for early silicon revisions
The DB8500 ED (Early Drop) and V1 are only available inside of ST-Ericsson or partners, we have actively replaced and scrapped these prototypes. All Nova products on the open market (such as the Snowball board) are based on V2 and later ASIC variants. So let us focus on supporting the silicon that will be used and delete this to get a clear overview.
Signed-off-by: Linus Walleij linus.walleij@linaro.org
removed the U8500_PRCMU_TCDM_BASE_V1 macro definition but it is still used in drivers/mfd/db8500-prcmu.c
Yes, I have sent the patch removing it from the PRCMU driver to the ARM SoC maintainers (you're on CC) so they can merge it into their ux500 branch, I intended to do it this way (Sam already ACK:ed it) but screwed up some way.
Yours, Linus Walleij
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/02/2012 02:55 PM, Daniel Lezcano wrote:
On 01/02/2012 01:59 PM, Linus Walleij wrote:
On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
the kernel does not compile when CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
it fails with :
CHK include/linux/version.h CHK include/generated/utsrelease.h make[1]: `include/generated/mach-types.h' is up to date. CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC drivers/clocksource/clksrc-dbx500-prcmu.o drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: type defaults to ?int? in declaration of ?DEFINE_CLOCK_DATA? drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: parameter names (without types) in function declaration drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?sched_clock?: drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: implicit declaration of function ?cyc_to_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: (Each undeclared identifier is reported only once drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: for each function it appears in.) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_update_sched_clock?: drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: implicit declaration of function ?update_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_init?: drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: implicit declaration of function ?init_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: ?cd? undeclared (first use in this function) make[2]: *** [drivers/clocksource/clksrc-dbx500-prcmu.o] Error 1 make[1]: *** [drivers/clocksource] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 make: *** Waiting for unfinished jobs....
Is it dead code ?
No if it was dead it shouldn't get compiled.
It' probably just some fallout from Marc's rewrite of the sched_clock() stuff, I'll see if I can cook a patch and send off to Marc.
Ok, thanks. I will test the patch you sent.
it seems also the commit :
commit c15def1cc30edeaa74a97205c936be82cdc86df6 Author: Linus Walleij linus.walleij@linaro.org Date: Thu Dec 15 13:38:40 2011 +0100
ARM: ux500: remove support for early silicon revisions
The DB8500 ED (Early Drop) and V1 are only available inside of ST-Ericsson or partners, we have actively replaced and scrapped these prototypes. All Nova products on the open market (such as the Snowball board) are based on V2 and later ASIC variants. So let us focus on supporting the silicon that will be used and delete this to get a clear overview.
Signed-off-by: Linus Walleij linus.walleij@linaro.org
removed the U8500_PRCMU_TCDM_BASE_V1 macro definition but it is still used in drivers/mfd/db8500-prcmu.c
The compilation fails with:
drivers/mfd/db8500-prcmu.c: In function ?db8500_prcmu_early_init?: drivers/mfd/db8500-prcmu.c:2107: error: ?U8500_PRCMU_TCDM_BASE_V1? undeclared (first use in this function) drivers/mfd/db8500-prcmu.c:2107: error: (Each undeclared identifier is reported only once drivers/mfd/db8500-prcmu.c:2107: error: for each function it appears in.) make[2]: *** [drivers/mfd/db8500-prcmu.o] Error 1 make[1]: *** [drivers/mfd] Error 2 make[1]: *** Waiting for unfinished jobs....
Please ignore, I missed your patch fixing this. I still have to improve my message filters :)
Thanks -- Daniel
_______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
- -- http://www.linaro.org/ Linaro.org ? Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro Facebook | http://twitter.com/#!/linaroorg Twitter | http://www.linaro.org/linaro-blog/ Blog
On Mon, Jan 02, 2012 at 01:59:10PM +0100, Linus Walleij wrote:
On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
the kernel does not compile when CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
Should this be in our default configs, or one of our tested configs, so we can catch this in a CI loop?
On Mon, Jan 2, 2012 at 4:25 PM, Christian Robottom Reis kiko@linaro.org wrote:
On Mon, Jan 02, 2012 at 01:59:10PM +0100, Linus Walleij wrote:
On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
the kernel does not compile when CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
Should this be in our default configs, or one of our tested configs, so we can catch this in a CI loop?
It should be in the defconfig already, the problem showed up for Daniel exactly because it was configured in.
Yours, Linus Walleij
On Tue, Jan 03, 2012 at 08:19:37AM +0100, Linus Walleij wrote:
On Mon, Jan 2, 2012 at 4:25 PM, Christian Robottom Reis kiko@linaro.org wrote:
On Mon, Jan 02, 2012 at 01:59:10PM +0100, Linus Walleij wrote:
On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
the kernel does not compile when CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
Should this be in our default configs, or one of our tested configs, so we can catch this in a CI loop?
It should be in the defconfig already, the problem showed up for Daniel exactly because it was configured in.
Okay, then the question is what do we need to do to make a box go red and have people notified when it breaks?
On Tue, Jan 3, 2012 at 7:20 AM, Christian Robottom Reis kiko@linaro.orgwrote:
On Tue, Jan 03, 2012 at 08:19:37AM +0100, Linus Walleij wrote:
On Mon, Jan 2, 2012 at 4:25 PM, Christian Robottom Reis kiko@linaro.org
wrote:
On Mon, Jan 02, 2012 at 01:59:10PM +0100, Linus Walleij wrote:
On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
the kernel does not compile when CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
Should this be in our default configs, or one of our tested configs, so we can catch this in a CI loop?
It should be in the defconfig already, the problem showed up for Daniel exactly because it was configured in.
It doesn't seem to be one of the currently tested configs - it sounds like it should be added though (infrastructure added to cc list).
Okay, then the question is what do we need to do to make a box go red and have people notified when it breaks?
The box would go red if it were tested, but the mechanisms for registering, subscribing to, and getting notifications on events does not yet exist so it would require someone to check for things like this. It's on our radar as something that needs to be added.
Thanks, Paul Larson
Hello Linus,
On Wed, Jan 4, 2012 at 9:37 AM, Paul Larson paul.larson@linaro.org wrote:
On Tue, Jan 3, 2012 at 7:20 AM, Christian Robottom Reis kiko@linaro.orgwrote:
On Tue, Jan 03, 2012 at 08:19:37AM +0100, Linus Walleij wrote:
On Mon, Jan 2, 2012 at 4:25 PM, Christian Robottom Reis <
kiko@linaro.org> wrote:
On Mon, Jan 02, 2012 at 01:59:10PM +0100, Linus Walleij wrote:
On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
the kernel does not compile when CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
Should this be in our default configs, or one of our tested configs,
so
we can catch this in a CI loop?
If we need a build to be set up on ci.linaro.org I could do that for you. Please file a bug for the same @ https://bugs.launchpad.net/linaro-ci. Refer to the instructions @ https://wiki.linaro.org/Platform/Infrastructure/LinaroCIQuickReference when for creating a new CI job.
It should be in the defconfig already, the problem showed up for Daniel exactly because it was configured in.
It doesn't seem to be one of the currently tested configs - it sounds like it should be added though (infrastructure added to cc list).
Okay, then the question is what do we need to do to make a box go red and have people notified when it breaks?
The box would go red if it were tested, but the mechanisms for registering, subscribing to, and getting notifications on events does not yet exist so it would require someone to check for things like this. It's on our radar as something that needs to be added.
Thanks, Paul Larson
On Tue, Jan 3, 2012 at 2:20 PM, Christian Robottom Reis kiko@linaro.org wrote:
On Tue, Jan 03, 2012 at 08:19:37AM +0100, Linus Walleij wrote:
It should be in the defconfig already, the problem showed up for Daniel exactly because it was configured in.
Okay, then the question is what do we need to do to make a box go red and have people notified when it breaks?
Since this was a simple compilation issue, it's indicated already by Stephen Rothwells "kisskb" system: http://kisskb.ellerman.id.au/kisskb/branch/9/
I actually poll the above web page for my machines, sadly not every day due to other duties...
Yours, Linus Walleij
-
Christian Robottom Reis -
Daniel Lezcano -
Deepti Kalakeri -
Linus Walleij -
Paul Larson