On 4 February 2013 18:02, Borislav Petkov bp@alien8.de wrote:
On Mon, Feb 04, 2013 at 05:54:18PM +0530, Viresh Kumar wrote:
One important point i would like to highlight is: governors directory would be present in cpu/cpu*/cpufreq/ now instead of cpu/cpufreq/.
Uh, hold on, isn't this breaking a bunch of userspace with this move? Also, on all those other systems which don't need per-policy governors, we probably don't need this. So maybe this should be made optional, to be enabled by a config option IMO...
That's why i am highlighting it again and again. :) What i believe is, the place where this directory was present earlier (cpu/cpufreq/) wasn't the right place. Everything else was in cpu/cpu*/cpufreq, then why this in cpu/cpufreq/ ?
I don't know how much of a pain it would be to fix userspace for it, but i know it wouldn't be that small.
I had another idea of doing this only for platforms where we have multiple struct policy alive at the same time. But didn't wanted to implement it before discussing this further.