On 16/03/11 at 05:31pm, Sachin Kamat wrote:
Hi Arnd, Alexander,
Some of the work arounds are just make shift solutions so that those dependent on the build can carry on with their work. Meanwhile as you guys said, the underlying problem needs to be addressed and fixed. This might take a while.
Maybe a comment just above each of these 'make shift solutions' will help you a) locate them later to fix up and b) give commentary on why you are temporarily doing them.
Regards Sachin
Regards, Jamie.
On 16 March 2011 17:17, Arnd Bergmann arnd@arndb.de wrote:
On Wednesday 16 March 2011, Sachin Kamat wrote:
--- a/elfcopy.c +++ b/elfcopy.c @@ -2456,7 +2456,6 @@ update_symbol_values(Elf *elf, GElf_Ehdr *ehdr, out why and also figure out whether the zero
value should have
been adjusted, after all. */
ASSERT(!(shdr_info[sym->st_shndx].shdr.sh_flags& SHF_ALLOC));
ASSERT(shdr_info[i].shdr.sh_type == SHT_SYMTAB); }Like the -Werror changes that Alexander commented on, this change circumvents the error output, but does not address the underlying problem. If you remove an assertion, that at least needs a very good explanation why the assertion was incorrect in the first place.
Arnd-- With warm regards, Sachin
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev