Re: [PATCH 1/3] sched: Do not ignore grouped tasks during HMP forced migration.

Fixing Linaro dev addresss.

On 16 May 2013 22:18, Chris Redpath chris.redpath@arm.com wrote:

If the entity is not a task, it is a cfs group rq. Iterate up to find the task entity.

Change-Id: I7cab7aba0798f6f14e38ad32e566d90e5937ffbc Signed-off-by: Chris Redpath chris.redpath@arm.com

---

kernel/sched/fair.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5ecfb1b..0f9941e 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6474,10 +6474,19 @@ static void hmp_force_up_migration(int this_cpu) target = cpu_rq(cpu); raw_spin_lock_irqsave(&target->lock, flags); curr = target->cfs.curr;

•           if (!curr || !entity_is_task(curr)) {
  

•           if (!curr) {
                    raw_spin_unlock_irqrestore(&target->lock, flags);
                    continue;
            }
  

•           if (!entity_is_task(curr)) {
  

•                   struct cfs_rq *cfs_rq;
  

•                   cfs_rq = group_cfs_rq(curr);
  

•                   while (cfs_rq) {
  

•                           curr = cfs_rq->curr;
  

•                           cfs_rq = group_cfs_rq(curr);
  

•                   }
  

•           }
            p = task_of(curr);
            if (hmp_up_migration(cpu, curr)) {
                    if (!target->active_balance) {
  

-- 1.7.9.5