On Tue, 2012-02-07 at 17:52 +0530, Ashish Jangam wrote:
> Can you consider adding yourself or David as maintainer ? Not a must,
> but no one else would really be able to support the driver.
Thank for this, you can add my name.
> > +Supported chips:
> > + * Dialog Semiconductors DA9052-BC and DA9053-AA/Bx PMICs
> > + Prefix: 'da9052'
> > + Datasheet: Kindly visit www.dialog-semiconductor.com and request for the
> > + official datasheet.
> > +
> Maybe, but that doesn't seem to be straightforward. The web site has no
> search field, and I am not sure who to contact in the contact list. And
> since there does not seem to be support in the US, I am not sure if one
> is expected to contact someone in Europe or Taiwan or some other place.
>
> Maybe you can let me know how exactly to get the datasheets - I like to
> keep those around for chips we are supporting.
You need to request for DA9052/53 datasheet from
www.dialog-semiconductor.com/DA9053.php
>
> > +static ssize_t da9052_read_tjunc(struct device *dev,
> > + struct device_attribute *devattr, char *buf)
> > +{
> > + struct da9052_hwmon *hwmon = dev_get_drvdata(dev);
> > + int tjunc, toffset, result;
> > +
> > + tjunc = da9052_reg_read(hwmon->da9052, DA9052_TJUNC_RES_REG);
> > + if (tjunc < 0)
> > + return tjunc;
> > +
> > + toffset = da9052_reg_read(hwmon->da9052, DA9052_T_OFFSET_REG);
> > + if (toffset < 0)
> > + return toffset;
> > +
> > + if ((tjunc - toffset) == 0)
> > + result = 0;
> > + else
> > + /* Degrees celsius = 1.708 * (TJUNC_RES - T_OFFSET) - 108.8 */
> > + result = 1708 * (tjunc - toffset) - 108800;
> > +
>
> Hmm.
> tjunc = 1, toffset = 2:
> return 1708 * (-1) - 108800 = -108800 - 1708 = -110508
> tjunc = 2, toffset = 2:
> return 0
> tjunc = 3, toffset = 2:
> return 1780 * 1 - 108800 = -108800 + 1708 = -107092
>
> I am not saying this is wrong, not having access to the data sheet, but
> it is a bit odd. Why is the 0-difference case handled differently, and
> why does it return 0 and not, say, -108800 ?
>
> If tjunc - toffset < 0 is invalid (no idea if it is, of course), it
> might make sense to detect that condition.
toffset is the trim value used for improving the calculated temperature
accuracy so considering this tjunc - toffset <=0 seems to be not
applicable cases. I will correct this along with your other comments and
will re-submit the patch.
Since CONFIG_IRQ_TIME_ACCOUNTING is architecture-agnostic,
move it from x86 area to common code.
Signed-off-by: Dmitry Antipov <dmitry.antipov(a)linaro.org>
---
arch/x86/Kconfig | 11 -----------
lib/Kconfig.debug | 11 +++++++++++
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5bed94e..4759676 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -805,17 +805,6 @@ config SCHED_MC
making when dealing with multi-core CPU chips at a cost of slightly
increased overhead in some places. If unsure say N here.
-config IRQ_TIME_ACCOUNTING
- bool "Fine granularity task level IRQ time accounting"
- default n
- ---help---
- Select this option to enable fine granularity task irq time
- accounting. This is done by reading a timestamp on each
- transitions between softirq and hardirq state, so there can be a
- small performance impact.
-
- If in doubt, say N here.
-
source "kernel/Kconfig.preempt"
config X86_UP_APIC
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 8745ac7..d6d7afc 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -299,6 +299,17 @@ config SCHEDSTATS
application, you can say N to avoid the very slight overhead
this adds.
+config IRQ_TIME_ACCOUNTING
+ bool "Fine granularity task level IRQ time accounting"
+ default n
+ ---help---
+ Select this option to enable fine granularity task irq time
+ accounting. This is done by reading a timestamp on each
+ transitions between softirq and hardirq state, so there can be a
+ small performance impact.
+
+ If in doubt, say N here.
+
config TIMER_STATS
bool "Collect kernel timers statistics"
depends on DEBUG_KERNEL && PROC_FS
--
1.7.7.6
If you were at the Snowball Audio session today (or wanted to be but
were not able to make it) by popular demand a "part 2" session has
been scheduled for Tuesday February 7th at 11:00 am in the Blue room.
See you there!
--
Regards,
Tom
"Where's the kaboom!? There was supposed to be an earth-shattering
kaboom!" Marvin Martian
Multimedia Tech Lead | Linaro.org │ Open source software for ARM SoCs
w) tom.gall att linaro.org
w) tom_gall att vnet.ibm.com
h) tom_gall att mac.com
http://connect.linaro.org/events/event/lcq1-12/#schedule
The Linaro Multimedia Team for 1Q Linaro Connect has 3 main goals.
1) We'll be identifying further candidates for NEON focused
optimization.2) We'll be syncing up with the landing teams to discuss
the state of audio on the various boards, thinking about how we can be
more effective, and planning our next efforts.3) We'll be working with
the Graphics team on the next steps surrounding dmb_buf usage.
In summary the sessions are:
Codecs:Codec NEON optimization - possibilities and priorities
Audio:Tiny AlsaLinaro speech recognitionPanda, Panda ES audio Snowball
AudioOrigen Audioimx53 audio
Unified Memory Manager:Evolution of the general dma-buf frameworkUMM -
further enablement on member platforms
I would anticipate we'll add a neon session so be on the lookout for that!
Stop by and interact with the team, we're located in Salon 3 on the
2nd floor with the Graphics team.
--
Regards,
Tom
"Where's the kaboom!? There was supposed to be an earth-shattering
kaboom!" Marvin Martian
Multimedia Tech Lead | Linaro.org │ Open source software for ARM SoCs
w) tom.gall att linaro.org
w) tom_gall att vnet.ibm.com
h) tom_gall att mac.com
Hi.
I'm curious how/if remote participation is going to work during this
connect. Unlike past events we will not have the advantage of the
Canonical IS teams that made everything just work. This probably
includes the microphones in each room, the IRC channels, the projectors
and the magic wifi.
Is there any general way to participate remotely during this event or
should I just bug my friends to place a laptop on a chair and run google
hangouts?
Thanks
ZK
--
Zygmunt Krynicki
Linaro Validation Team
Hey,
Additionally to the sessions we'll have over the week, here are
another 2 important links for our group:
- Plans and Goals for Linaro Connect Q1.12:
https://wiki.linaro.org/Platform/DevPlatform/Connect/Q1.12/Plans
- Hacking Sessions:
https://wiki.linaro.org/Platform/DevPlatform/Connect/Q1.12/HackingSessions
If you're interested on having a 'hands-on' at any topic described at
this wiki pages, please visit room Salon 4. We have all needed
hardware there, from boards to monitors, so we can easily get on
hacking.
Thanks,
--
Ricardo Salveti de Araujo